fhrbek / poker-league Goto Github PK

The deepest form in the prize rules contains a typo; the 'Location' label is there twice but the second one should be 'Prize Money' instead.

A timestamp field should consist of two separate fields - date + time; date should have a date-picker popup.

In addition, there should be a nice "announcement lead" input field, separating days from hours (e.g. [2] days [12] hours instead of confusing [60] hours).

Forms already support validation. However, the errors are not presented in the UI. In addition, validations should be reviewed and fully implemented for all forms.

For second game and further, no player list to choose from is displayed but it should.

Some asynchronous callbacks should put a fully transparent glass over the app and the waiting cursor until the response is received.

At the same time, editor forms should be cleared before data arrives since otherwise (as they are reused for different entities) it's confusing if user wait for the server to start and still sees old data in the form.

1. Create a competition, give it a name
2. Edit the competition, change the name (it updates)
3. Edit the competition again, change the name once again

The latest name is not displayed until next page refresh.

The invitation displays wrong time if the tournament takes plays in a time zone with active DST (should add another hour).

If the invitation confirmation page is just refreshed then answering the question does not refresh data even though everything is ok in the background.

Render tournament description in the view. Use simple markup parser to enable inserting links in the following format:

[http://www.foo.bar|This is foo]

If the second part is not specified, use the HREF as text.

It's too many clicking to mark the winner explicitly - instead it should be done automatically once there are only two players remaining and the second one is marked as 'seat-open'.

Typically on small devices, but sometimes even on large screens, pop-up windows run out of visible viewport and it may make impossible to click the control buttons.

Pop-up windows should always fit in visible viewport and use inner scroll bars to allow access to their inner content.

If the tournament is set to send emails too early (e.g. 30 days before the event) the emails are not sent. The reason is in the integer overflow in the condition (30 days is resolved into too many milliseconds). An explicit cast to long should fix it.

If a player wants to confirm an invitation too late, they should get a phone number to call instead of an online confirmation.

We already maintain migration SQL scripts (up/down) but there's no automation based on it. It should be specified and implemented.

The splash screen disappears right after the bootstrap script is loaded. However, it may take some time until the database is initiated. The splash screen should remain displayed until the application starts to move.

If something happens on the server side (typically an IllegalArgumentException), client only reports error 500 on the server. It would be nice to deliver the message to the user.

The tournament should have a timezone and emails sent should convert the date and time accordingly.

Currently the application is open to public which is unacceptable. There should be user accounts (pairable with the players) and a default administration account. For simplicity only two security levels should be supported: admin (read+write everything) and a player (read-only everything). Users shouldn't be required to register on any third-party service and account should only be created by an administrator.

1. Create a competition with certain players
2. Register a tournament
3. Add an invitation for a player that's not listed in the competition
4. Start a game
5. Seat-open a player who different from the 'guest' player
6. Check ranking - the rank is shifted by 1 (less than it should be)

Once the 'guest' player is registered in the competition, everything works fine.

When an entity is merged it may take a large structure with it even though it's not needed, it's risky and sometimes it takes so long that it fails (why does not it report an error then?).

Entities should be stripped before they're merged unless relationships are part of the relevant data.

When an invitation is added, the invitation table is rerendered with data apparently stolen from a different tournament. On hide/show it rerenders with correct data.

If there's no tournament and no data change is detected the page does not find current tournament just by the time change. If there's no current tournament, it should find the nearest tournament time and schedule a forced refresh for that time.

The invitation confirmation page and current tournament page should render scroll bars so that user could see the whole content if it's too large.

Statistics are refreshed on each visibility changed even if no data version is detected. This wastes resources and should be optimized.

Switching to # renders just a blank screen and app needs to be reloaded.

Something other than the Google box should be served as the favicon - for example, an Ace card or something like that.