feature request: accept both ; and , as keyword separators about biblatex-csl-converter

[johanneswilm]

That sounds good to me as long as it doesn't break anything. There are no examples of keywords that contain ";" characters?

[retorquere]

I haven't seen any, but the keywords field has no formal format. AAMOF I have one test case where someone had commas in the keywords (for chemical elements IIRC -- I'll find it soon enough) and who wanted to separate on <comma><space>, but not <comma>. I don't remember how I handled that (probably a postscript); the keywords field is the wild west of bibtex.

[johanneswilm]

To accept commas and semi-colons, this line should be changed to:

oFields[fKey] = fValue.split(/[,;]/g).map((string)=>{return string.trim()})

biblatex-csl-converter/src/import/biblatex.js

Line 487 in f1b4949

oFields[fKey] = fValue.split(',').map((string)=>{return string.trim()})

Having commas not work as separators and have spaces make a difference seems to go against the definition used in biblatex:

A separated list of keywords. These keywords are intended for the bibliographyfilters (see §§3.7.2and 3.12.4), they are usually not printed. Note that with the defaultseparator (comma), spaces around the separator are ignored.

page 27, http://tug.ctan.org/macros/latex/exptl/biblatex/doc/biblatex.pdf

[retorquere]

I'm not advocating for the comma-space thing, I was just describing the odd stuff you could find there 😄

[johanneswilm]

Ok, try with the line I mentioned above. If that works for your test files, feel free to update and merge it.

[retorquere]

How do releases work BTW?

[retorquere]

I done gone broke the tests.

[johanneswilm]

I forgot. I think we may have set it up to autorelease via travis if the tests go through. I can check it tomorrow if it still hasn't been released. :)

[retorquere]

No problem.