finagle / finagle-oauth2 Goto Github PK

View Code? Open in Web Editor NEW

84.0 84.0 22.0 140 KB

OAuth2 Server-Side Provider for Finagle

License: Apache License 2.0

Scala 96.75% Shell 3.25%

finagle finch oauth oauth2 scala

finagle-oauth2's People

Contributors

Stargazers

Watchers

finagle-oauth2's Issues

Update Readme with OAuthEndpoint examples

Migrate old tests to finagle-oauth2

Update for Finagle 6.42.0

Updating to Finagle 6.42.0 leads to errors such as this:
java.lang.NoSuchMethodError: com.twitter.finagle.http.HeaderMap.getAll

Would it be possible to get a new compatible release?

Update Reame with suitable examples

There is only one way to implement token service. But the protected service might be implemented in two usage ways of finagle-oauth2: w/o filter and w/ type-safe filter.

OAuthError should be convertible to Response

oAuthErrorToHttpResponse method in OAuth2

Make sure headers are correct

WWW-Authenticate: Bearer List(error="invalid_request", e, r, r, o, r, _, d, e, s, c, r, i, p, t, i, o, n, =, ", r, e, q, u, i, r, e, d,  , p, a, r, a, m, e, t, e, r, :,  , u, s, e, r, n, a, m, e, ")

OAuth2Filter should be configurable in terms of response

I'm thinking of trait mixing idea:

trait OAuthErrorHandler {
  def handleError(e: OAuthError): Response = ???
}
val auth = new OAuth2Filter(dataHandler) with OAuthErrorInJson

We can use trait mixing for token service

Like this:

trait OAuthTokenConverter {
  def convertToken(t: Token): Response
}
val tokenizer = new OAuth2Endpoint(dataHandler) with OAuthTokenInJson with OAuthErrorInJson

Authentification Filters

case class AuthorizedRequest[U](authInfo: AuthInfo[U]) extends RequestProxy

val f = new AuthentificateFilter[User] with OAuth2 {
  def apply(req: Request, service: Service[AuthorizedRequest[User], Response]): Future[Response] =
    // try authorize
    service(AuthorizedRequest(authInfo))
    // else bad request
}

Not sure where to ask this question, I'm about to implement OAuth2 for my application and the suitable grant type for my application is implicit. I've noticed that this library is not supporting it (or am I missing it), but the scala-oauth library does have it.

Is there a particular reason why it's not present and can I give it a shot to add it to this project?

finagle / finagle-oauth2 Goto Github PK

finagle-oauth2's People

Contributors

Stargazers

Watchers

Forkers

finagle-oauth2's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs