firebase / friendlyeats-ios

Friendly Eats

This is the source code that accompanies the Firestore iOS Codelab.

The codelab will walk you through developing a restaurant recommendation app powered by Cloud Firestore on iOS.

If you don't want to do the codelab and would rather view the completed sample code, see the Firebase iOS Quickstart repository or the codelab-complete branch.

friendlyeats-ios's Issues

Request for SwiftUI version

Hello. Could you please create a new version of this example project using SwiftUI? Thanks!

Code doesn't compile on codelab-complete branch

The codelab-complete branch doesn't compile for me because it's missing the import Firebase statement for the use of the Timestamp object in Restaurant.swift. This import statement is on the master branch but it appears it never made it to the codelab-complete branch.

Project is outdated

Hello. I want to learn more about Firestore so I cloned this project and followed tutorial. It didn't work because the code is outdated. Any plan to update this?

query OR

Hi guys,

How can I query with OR value?

Nested Documents

Hello everyone,

You put (reviews as Collection) inside Restaurants Collections.

What different between this and reviews collection in the base path, and set rest_id and user_id inside it??

The xcworkspace name is incorrect.

https://codelabs.developers.google.com/codelabs/firestore-ios/index.html?index=..%2F..%2Findex#2

The above URL is written

Open FireEats.xcworkspace in Xcode and run it (Cmd+R).

, but correctly

Open FriendlyEats.xcworkspace in Xcode and run it (Cmd+R).

Is not it?
I got it soon, but I reported it just in case.

How to Paginate the Query

I using this example but I am not able to paginate the data. Can you please assist me to get data filtered or not filtered to be paginated.
I am getting the pagination examples without filter feature

Issue with Step 3 and Auth UI

The current Cloud Firestore Codelab misses a crucial component on Step 3, as it does not show how to add sign in providers on the sign in screen. I was stuck for a while as to why the AuthViewController was blank.

I added code to the RestaurantsTableViewController.swift to fix this issue:

Inside viewDidAppear(_ animated: Bool) {

let actionCodeSettings = ActionCodeSettings()
    actionCodeSettings.handleCodeInApp = true
    actionCodeSettings.setIOSBundleID("your bundle id here")

    let auth = FUIAuth.defaultAuthUI()!
    let provider = FUIEmailAuth.init(authAuthUI: auth, signInMethod: EmailLinkAuthSignInMethod, forceSameDevice: false, allowNewEmailAccounts: true, actionCodeSetting: actionCodeSettings)

    if auth.auth?.currentUser == nil {
      auth.providers = [provider]
      present(auth.authViewController(), animated: true, completion: nil)
    }

Please update the tutorial to reflect this.

Thanks!

Code incorrectly added in project

Hi, I'm following Cloud Firestore iOS Codelab, and in step 4 the tutorial instructs to add the following lines of code to RestaurantTableViewCell.populate(restaurant:):

nameLabel.text = restaurant.name
cityLabel.text = restaurant.city
categoryLabel.text = restaurant.category
starsView.rating = Int(restaurant.averageRating.rounded())
priceLabel.text = priceString(from: restaurant.price)

Project already has those lines added :) The tutorial has to be updated or those lines should be removed from the code

Greetings

Migrathing from CocoaPods to SwiftPM

Overview

If all libraries used in this application are compatible with SwiftPM, then we should move to SwiftPM.

The following libraries can be found in the Podfile.

• SDWebImage
• FirebaseUI/Auth
• FirebaseUI/Email
• FirebaseUI/Google
• Firebase/Firestore

Japanese

## 概要 このアプリケーションで使われているすべてのライブラリがSwiftPMと互換性があるなら、SwiftPMに移行すべきだ。

以下のライブラリはPodfileにあります。

• SDWebImage
• FirebaseUI/Auth
• FirebaseUI/Email
• FirebaseUI/Google
• Firebase/Firestore

Codelab Typo

The Codelab instructions, codelab-complete branch, and quickstart-ios repo have three slightly different versions of one line; the one in the instructions does not compile.

In the Codelab instructions this line is giving a build error of

Value of optional type '[String : Any]?' must be unwrapped to a value of type '[String : Any]':

guard let restaurant = Restaurant(dictionary: restaurantSnapshot.data()) else {`

The codelab-complete branch states

guard let data = restaurantSnapshot.data(),
let restaurant = Restaurant(dictionary: data) else {

The quickstart-ios repo uses a flatmap and an init:
guard let restaurant = restaurantSnapshot.data().flatMap(Restaurant.init(dictionary:)) else {

Showing All Messages :-1: SWIFT_VERSION '3.0' is unsupported, supported versions are: 4.0, 4.2, 5.0. (in target 'FriendlyEats')

Showing All Messages
👎 SWIFT_VERSION '3.0' is unsupported, supported versions are: 4.0, 4.2, 5.0. (in target 'FriendlyEats')

Search by name

Hello

How do you search by restaurants names?
Firestore isn't able to search by contains a text.

What the best solutions to search by text?

Thank you

GoogleUtilities

GoogleUtilities seems to be involved in a pod install error if I use the current podfile when following the **https://codelabs.developers.google.com/codelabs/firestore-ios/#2 sample process?

I get a GoogleUtilities build error 'GoogleUtilities/GULAppEnvironmentUtil.h' file' not found when using the friendlyeats podfile which includes:

pod 'SDWebImage'
pod 'FirebaseUI/Auth', '> 5.0'
pod 'FirebaseUI/Google', '> 5.0'
pod 'Firebase/Firestore'
pod 'Firebase/Core'

(uses GoogleUtilities 5.3.6)

In this case, no files exists under the Pods-GoogleUtilities folder

The app successfully builds when the following is added to the podfile:

pod 'GoogleUtilities', '<5.3.6'

Linking to internal Google link

On the last page of the iOS Codelab there is a link to the codelab-complete branch. However, this goes to an internal Google page which is asking for Google credentials to access. A link to the github branch will be more useful. Thanks!

https://codelabs.developers.google.com/codelabs/firestore-ios/#8

Detect network connection

Hello everyone,

How can we detect the connection of network when Put or Get some data in Firestore?
the error handling doesn't show anything when the connection failed or disconnect when handling data.

Thank you

Project still brings a lot of issues

I am following a tutorial, and I am on step 3. Simple stuff but my Xcode is on fire. I think easiest is to to show you my screen.

Error: Use of undeclared type 'Timestamp'

You need to add import FirebaseFirestore into Restaurant.swift file to suppress this error.

Ios

.

Use of unresolved identifier 'newReviewReference'

Stepping through Writing data in a transaction, I am getting the error Use of unresolved identifier 'newReviewReference'. I have search diligently but have not found any other mention of this problem and have revert and stepped through again to no resolve.

nit: Codelab stated to take 2 min

https://codelabs.developers.google.com/codelabs/firestore-ios/index.html?index=..%2F..%2Findex#0
suggests that the codelab should take 2 minutes to complete, while it's Android counterpart requires 37 min to complete.