fireship-io / fkit-course

The Full SvelteKit Course

SvelteKit - The Full Course

This repo contains the code for the Full SvelteKit Course on fireship.io

• Live Demo 🥋

Usage

To take advantage of this code you will need to add your own Firebase client project config and Firebase Admin SDK service account as explained in the course setup.

git clone <this-repo>
npm i
npm run dev

fkit-course's Issues

Locals are always empty

When trying to implement the server auth using the firebase admin sdk, locals are always empty. I cloned this repo down and used all of the code within this repo to test it to make sure it wasn't something i was doing and it was still broken.

Whenever I tried navigating to user/bio it would redirect to /login

formDefaults undesired mutation by setting a svelte store

fkit-course/src/routes/[username]/edit/+page.svelte

Line 24 in ce1b40a

const formDefaults = {

bind:value={$formData.title}
bind:value={$formData.url}

For some reason, are mutating the original

const formDefaults = {
    icon: 'custom',
    title: '',
    url: 'https://'
};

this is an undesired behavior since

formData.set(formDefaults);

is setting the values to the previous once, hence the form is not being resetted.

What is going on?

Missing information on how to seed the Firestore Database?

Hey,

Is it on purpose, that there is no info in the course - nor any to be found on the repo, about setting up the database?

I'm thinking in terms of it already having data in the video. I think this could confuse quite a few people.

Form validation doesn't check for validity

Hello, was just following along with the tutorial when I noticed I could still submit a non-alphanumeric username. Should this not be like so:

{#if isAvailable && isValid} <button class="btn btn-success">Confirm username @{username} </button> {/if}

or am I missing something?

https://github.com/fireship-io/fkit-course/blob/ce1b40a030c5461ba4e449a2c45eae6fdfcb4543/src/routes/login/username/%2Bpage.svelte#L101C9-L103C14

I got Error when doing login with admin sdk

Error :

SOLVED by changing typo in .env

does it has something to do with Oauth project name? because I change that name. is there step by step to fix this?

Firebase user document reads.

Hi!

Thanks for a great course.

It seems that userData gets fetched every time the AuthCheck component is used.
Is it possible to persist the userData on every page to ensure there are no unnecessary reads?

Add security rules

Hi Jeff, Great course!!

Would it be possible to share the rules you used for firestore and storage please?

Maybe create a branch using sveltefire

I am wondering if this implementation would be better by using sveltefire. Are there any plans to upgrade this course or maybe create a new sveltekit / firebase course?

Drop effect bug in the drag & drop reordering

When you create 3 links, and drag the middle one to either over the top or bottom one repeatedly, the hover effect only works every second time even though the swapping action is executed successfully. I assume there is some comparison whether the current dragged item is the same as the one that we are dragging over but this seems to have a bug and compares it with the wrong object.

Cool website btw ;)