Comments (9)
@fivetran-catfritz in addition to working through this feature request, would you be able to remove the test here as it has been shown to not be accurate for all implementations.
We were also able to identify that per Intercom's documentation, this test can in fact fail and the data is not incorrect. See here for the Intercom docs explaining the nobody_admin
assignee_type. In these cases, the assignee_id will be null. As such, we will want to remove the test.
from dbt_intercom.
Awesome ;)
+1 on the above test. It's failing for us too but the data is inherently correct.
from dbt_intercom.
@ccbrandenburg Thank you for submitting this feature request. We have added this to our current projects and plan to have a test branch for you to try in the next week or so. We'll keep you posted!
from dbt_intercom.
Hi @ccbrandenburg I have a created a test branch for you to try out. You'll just need to add the below to you packages.yml
in place of the normal dbt_intercom
.
- git: https://github.com/fivetran/dbt_intercom.git
revision: feature/add-conversation-passthroughs
warn-unpinned: false
The var to add your dbt_project.yml
for your list of passthrough columns for conversation_history
is intercom__conversation_history_pass_through_columns
.
Please let me know how this works for you and if it is producing what you would expect!
from dbt_intercom.
Unfortunately I can't get it to work.
Deleted the fivetran-stripe package to make sure there are no dependencies causing issues.
Added this to the dbt_project.yml
:
intercom__conversation_history_pass_through_columns: [custom_customer, custom_description]
But the compiled sql fails and is not pulling in the two field names. I tried wrapping the fields with ' '
and " "
but did not help.
from dbt_intercom.
Hi @ccbrandenburg thank you for trying this out! I took a closer look and made some adjustments that are now proving out on my end. Would you mind giving it another whirl?
from dbt_intercom.
@fivetran-catfritz works like a charm! Tests are passing now too.
Thanks for the quick package improvement
from dbt_intercom.
@ccbrandenburg Awesome! Thanks again for testing that out. We will be pushing out a new release with these changes in the next day or so!
from dbt_intercom.
The update has been released. Closing out the issue!
from dbt_intercom.
Related Issues (20)
- This package should include metrics from the statistical model outlined in github link below HOT 1
- test issue
- Intercom Version Compatibility
- BUG - [Duplicates in intercom__admin_metrics] HOT 4
- [Feature] Add SLA metrics to Intercom reports
- [Feature] Add new Intercom fields for real-time performance tracking based on conversation type and rating
- [Feature] Configure business hour variables
- Failure on intercom__conversation_metrics model build HOT 2
- [Feature] Databricks compatibility
- [Feature] README Updates HOT 1
- Ignore Nulls - Postgres HOT 3
- [Bug] Package version range in latest README is incorrect HOT 1
- [Bug] first_admin_response_at can be grouped under "part_type= 'assignment'" HOT 2
- LISTAGG limit error on Redshift in intercom__contact_enhanced HOT 2
- Incorrect FIRST_CLOSE_AT on intercom__conversation_metrics HOT 15
- When two events occur at the same time, they should be separated. HOT 4
- [Feature] Intercom API Upgrade and History Changes HOT 1
- dbt run fails HOT 10
- Add support for Intercom Events HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dbt_intercom.