GithubHelp home page GithubHelp logo

Comments (9)

fivetran-joemarkiewicz avatar fivetran-joemarkiewicz commented on May 17, 2024 1

@fivetran-catfritz in addition to working through this feature request, would you be able to remove the test here as it has been shown to not be accurate for all implementations.

We were also able to identify that per Intercom's documentation, this test can in fact fail and the data is not incorrect. See here for the Intercom docs explaining the nobody_admin assignee_type. In these cases, the assignee_id will be null. As such, we will want to remove the test.

from dbt_intercom.

ccbrandenburg avatar ccbrandenburg commented on May 17, 2024 1

Awesome ;)

+1 on the above test. It's failing for us too but the data is inherently correct.

from dbt_intercom.

fivetran-catfritz avatar fivetran-catfritz commented on May 17, 2024

@ccbrandenburg Thank you for submitting this feature request. We have added this to our current projects and plan to have a test branch for you to try in the next week or so. We'll keep you posted!

from dbt_intercom.

fivetran-catfritz avatar fivetran-catfritz commented on May 17, 2024

Hi @ccbrandenburg I have a created a test branch for you to try out. You'll just need to add the below to you packages.yml in place of the normal dbt_intercom.

- git: https://github.com/fivetran/dbt_intercom.git
  revision: feature/add-conversation-passthroughs
  warn-unpinned: false

The var to add your dbt_project.yml for your list of passthrough columns for conversation_history is intercom__conversation_history_pass_through_columns.

Please let me know how this works for you and if it is producing what you would expect!

from dbt_intercom.

ccbrandenburg avatar ccbrandenburg commented on May 17, 2024

Unfortunately I can't get it to work.

Deleted the fivetran-stripe package to make sure there are no dependencies causing issues.

Added this to the dbt_project.yml:
intercom__conversation_history_pass_through_columns: [custom_customer, custom_description]
But the compiled sql fails and is not pulling in the two field names. I tried wrapping the fields with ' ' and " " but did not help.
Screenshot 2023-03-15 at 15 20 54

from dbt_intercom.

fivetran-catfritz avatar fivetran-catfritz commented on May 17, 2024

Hi @ccbrandenburg thank you for trying this out! I took a closer look and made some adjustments that are now proving out on my end. Would you mind giving it another whirl?

from dbt_intercom.

ccbrandenburg avatar ccbrandenburg commented on May 17, 2024

@fivetran-catfritz works like a charm! Tests are passing now too.

Thanks for the quick package improvement

from dbt_intercom.

fivetran-catfritz avatar fivetran-catfritz commented on May 17, 2024

@ccbrandenburg Awesome! Thanks again for testing that out. We will be pushing out a new release with these changes in the next day or so!

from dbt_intercom.

fivetran-catfritz avatar fivetran-catfritz commented on May 17, 2024

The update has been released. Closing out the issue!

from dbt_intercom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.