Comments (15)
Thanks @fivetran-joemarkiewicz
Will take a look and get back to you.
from dbt_intercom.
Hi @alvarosiman thanks so much for opening this issue and raising the incorrect first close to our team.
When looking at our code to calculate first_close_at
I see that we are grabbing the first created_at field for the filtered results in the cte where part_type = 'close' and author_type = 'admin'
. Are you able to confirm if the close entry you are highlighting was done by an admin?
If it was not closed by an admin I would be curious to get your thoughts if that should still be counted as a first close time?
from dbt_intercom.
Hi Joe, thanks for your reply!
I see, that's what I thought was happening. Based on how Fivetran packages treat Intercom data it would make sense to have a first_admin_close_at
similar to the first_admin_response_at
and last_admin_response_at
Intercom has many new functionalities, including very useful bots that can close conversations if an admin has responded and the end customer has been inactive after x amount of minutes.
This is actually the case for most of our conversations. The user starts it, the admin responds and provides a solution or asks them a follow up question, but the end user doesn't respond again. Since having the admin close after responding would not make sense if the conversation isn't clearly finished, Intercom's bot asks the user if they are still there and closes the conversation telling them they can re-open it if they want to continue.
So in general it would be great to have a first_admin_close_at
and a first_close_at
regardless of if it was an admin
from dbt_intercom.
Thanks for the quick reply!
I was not aware of the bots Intercom may deploy to help automate these types of conversation parts (makes sense to me!). I would also agree with you that expanding the model to have two different versions of close_at can help users who leverage bots in their workflows. Would it be difficult on your end to manage these two fields when analyzing the data?
If not, then I feel this is an appropriate update to the package and can fold this into our upcoming sprint.
from dbt_intercom.
I think there would be no issue on our side managing the two separate fields, it would make our analytics more accurate and give us more flexibility.
That would be great! When would the next sprint finish? And would we just have to update the package version to get access to this? Thanks!
from dbt_intercom.
Our next sprint begins Wednesday of next week. As this is likely a relatively small update we should be able to turn this around in the first half of the sprint.
Yup! Once the update is applied you will be able to install the newest version of the package to capture the changes. As we will likely be adding a new field and changing the definition of the first_close_at
field, I would be most comfortable with this being a breaking change. So the next version will be v0.7.0
.
Additionally, we will share a WIP branch here before releasing in case you wanted to validate on your end that changes look good before making the official release.
from dbt_intercom.
Thanks Joe! When do you think we will we be able to validate on our side? and if it's taken on the first half of the sprint would it be released by the end of this week or the next?
from dbt_intercom.
Hi @alvarosiman I think conservatively we should have a working branch over to you to test by the end of this week. Realistically, this will be released early next week if all goes well during validation.
from dbt_intercom.
Great, thanks for the update!
from dbt_intercom.
Hi @alvarosiman I wanted to post back that we currently have a working version of the package with the changes discussed earlier in this thread. If you have a moment, it would be great if you would be able to validate the changes on your end and confirm they make sense and are accurate.
You can test the changes by replacing your existing package dependency for intercom within your packages.yml
with the following dependency:
packages:
- git: https://github.com/fivetran/dbt_intercom.git
revision: feature/close-at-updates
warn-unpinned: false
You can see a full view of the updates applied in this branch by inspecting the notes and files changed within PR #41
Let me know if you have any questions. Thanks!
from dbt_intercom.
Hi @fivetran-joemarkiewicz! Hope you are doing well. I checked a couple of runs and the information seems to be accurate. Thanks!
from dbt_intercom.
Brilliant! Thanks for checking. I will kick off the review process internally and will share once this is live.
from dbt_intercom.
Hi @fivetran-joemarkiewicz hope everything is well! Is there an update on this PR? Do you think it will get released soon?
from dbt_intercom.
Hi @alvarosiman this is currently in the internal release process. I imagine you can expect this to be released today!
from dbt_intercom.
Hi @alvarosiman the changes from the branch I linked above are now live on the dbt hub! You can upgrade your package to the latest version (v0.7.0) in order to capture these changes.
As such, I will close this issue. Please feel free to reopen if the issue continues to persist on your end. Thanks again for helping work through this update!
from dbt_intercom.
Related Issues (20)
- test issue
- Intercom Version Compatibility
- BUG - [Duplicates in intercom__admin_metrics] HOT 4
- [Feature] Add SLA metrics to Intercom reports
- [Feature] Add new Intercom fields for real-time performance tracking based on conversation type and rating
- [Feature] Configure business hour variables
- Failure on intercom__conversation_metrics model build HOT 2
- [Feature] Databricks compatibility
- [Feature] README Updates HOT 1
- Ignore Nulls - Postgres HOT 3
- [Bug] Package version range in latest README is incorrect HOT 1
- [Bug] first_admin_response_at can be grouped under "part_type= 'assignment'" HOT 2
- [Feature] Adding passthrough Custom Attributes also for Conversations HOT 9
- LISTAGG limit error on Redshift in intercom__contact_enhanced HOT 2
- When two events occur at the same time, they should be separated. HOT 4
- [Feature] Intercom API Upgrade and History Changes HOT 1
- [Bug] Update or Remove Conversation Contact History from Conversation End Models HOT 1
- dbt run fails HOT 10
- Add support for Intercom Events HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dbt_intercom.