GithubHelp home page GithubHelp logo

Comments (6)

SychO9 avatar SychO9 commented on June 17, 2024 1

@luceos it's actually not possible to override the frontend side limit, which is hard coded to 20 per page in the request. As far as I can tell. So the backend one doesn't have an effect as it's just a maximum.

The relevant code is in DiscussionListState and PaginatedListState.

from framework.

luceos avatar luceos commented on June 17, 2024

The max limit is set to 50 by default. But you should be able to override this for the given controller using an extender.

Reference:

/**
* Set the maximum number of results.
*/
public function setMaxLimit(int $max): void
{
$this->maxLimit = $max;
}

How to extend this max limit:

https://docs.flarum.org/extend/api#extending-api-controllers


This solution solves your issue, if you need further help feel free to post on discuss at https://discuss.flarum.org

from framework.

luceos avatar luceos commented on June 17, 2024

@luceos it's actually not possible to override the frontend side limit, which is hard coded to 20 per page in the request. As far as I can tell. So the backend one doesn't have an effect as it's just a maximum.

The relevant code is in DiscussionListState and PaginatedListState.

It would make more sense then to modify core so that only the backend restrictions apply; like carrying that value from the backend into the frontend for re-use?

from framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.