GithubHelp home page GithubHelp logo

com.makemkv.makemkv's People

Contributors

ahappyuser avatar bollian avatar dockde avatar eszlari avatar fakeshemp avatar flathubbot avatar hfiguiere avatar jamesbelchamber avatar jstebbins avatar lhw avatar mastercactapus avatar matmaul avatar michaelkuhn avatar parasense avatar refi64 avatar tingping avatar wberrier avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

com.makemkv.makemkv's Issues

Respect user-selected data directory location

MakeMKV flatpak fails to respect user preference for data directory location.

Steps to reproduce:

  1. Open MakeMKV preferences
  2. Set data directory to alternate path and close application
  3. Re-open and find all preferences reset since app seeks data dir in /home/${USER}/.MakeMKV

Also, rather than defaulting to /home/${USER}/.MakeMKV, shouldn't the default location for the data directory be /home/${USER}/.var/app/com.makemkv.MakeMKV/.MakeMKV thereby more closely adhering to flatpak confinement conventions?

Update to 1.17.4

Hello, please update to 1.17.4 (29.5.2023), the previous version 1.17.3 expires today. Many thanks!

Internal error: openssl test 0050 failed

Updated to the 1.17.5 and now opening the program I see this error message:

Internal error: openssl test 0050 failed

Any idea what's wrong?

Using Linux Mint 20.3 Cinnamon.

Makemkv wont run

flatpak run com.makemkv.MakeMKV
Failed to create wl_display (No such file or directory)
qt.qpa.plugin: Could not load the Qt platform plugin "wayland" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, xcb.

Can't save rip to alternative hard drive

Currently, the only filesystems that the MakeMKV Flatpak is allowed to access are /home and optical drives. You can see the filesystem permissions in com.makemkv.MakeMKV.json:

  • "--filesystem=home" (grants access to /home/<USERNAME>)
  • "--device=all" (grants access to optical drives, but not alternative hard drives)

There are use cases in which it may not be acceptable for the user to save their rips in their /home directory. For example, my /home directory is on a small SSD, and I wouldn't be able to fit the contents of a dual-layer Blu-ray (let alone a 3D Blu-ray or UltraHD Blu-ray) in my /home directory. I normally configure space-intensive applications to save their large files either to my internal HDD, or to an external HDD. But the MakeMKV Flatpak can't access either the internal or external HDD, due to lack of permissions.

I can see 2 ways of fixing this (note: I don't have any prior experience with Flatpak development, other than following bug reports, so some of my example code may be wrong):

  • Grant MakeMKV raw access to all mounted partitions

    This is probably the quickest and easiest solution, but less secure. I assume adding "--filesystem=/media", "--filesystem=/mnt", "--filesystem=/run/media" and "--filesystem=/run/mount" would cover the default mount points of almost all Linux distros.

  • Using the FileChooser portal, allow the user to grant MakeMKV access to a folder at runtime

    This is the more secure option, as you wouldn't need to grant MakeMKV raw access to any directories (not even /home). MakeMKV would then default to saving its configuration files and dumps to a location within the sandbox, and its rips to another location within the sandbox. However, the user could change these locations to whatever suits them, by changing the "MakeMKV data directory" and "Output folder", respectively.

I know that KeePassXC (which also depends on the KDE runtime) has been using FileChooser for a while (see flathub/org.keepassxc.KeePassXC#2 for evidence of this); as such, it might be useful to study how the KeePassXC Flatpak works.

error while loading shared libraries: libmakemkv.so.1: cannot open shared object file: No such file or directory

error while loading shared libraries: libmakemkv.so.1: cannot open shared object file: No such file or directory

This error occurs when i try to run sdftool or makemkvcon from /var/lib/flatpak/app/com.makemkv.MakeMKV/current/f3608af10eb2297e03057c78cf7bb20b55ce00996b2a042b6097a30574e639d5/files/bin I have been having major issues trying to build makemkv for my distro and installed flatpak instead. I want to get libredrive working but since i have no avenues to use the flash tool to do that im kinda stuck and would really appreciate some help or a fix if this is truely a bug and not my own linux incompetence.

Please update to 1.17.7

Hello. Thanks for your time maintaining this project. I received an error message when starting the app to please update or register. The current version is 1.17.7. Please update this when you have a chance. Thanks!

Can't Integrate With VLC

I had no trouble with integration when I installed "manually" with the bin and oss folders, but ever since I uninstalled that version and installed the Flatpak, I've been unable to play Blu-Rays with VLC.

I should probably mention that I'm running Debian 11 (Bullseye).

This disc requires Java runtime (JRE), but none was found.

When trying to archive a BD+ disc, I got the following warning in the output log:

This disc requires Java runtime (JRE), but none was found. Certain functions will fail, please install Java. See http://www.makemkv.com/bdjava/ for details.

Also, the resulting MKV file seemed to be slightly broken, or at least some segments were saved in the wrong order, causing skips in the movie. When running MakeMKV without flatpak (via the AUR package) so it would use the JRE I have installed on my system, the MKV file was saved correctly.

Would it be possible to include a Java runtime in this flatpak? You can look at how PrismLauncher (a Minecraft launcher, which also requires a JRE) does it here: https://github.com/flathub/org.prismlauncher.PrismLauncher/blob/master/org.prismlauncher.PrismLauncher.yml

Flatpak is out of date.

The flatpak is currently on 1.16.5 and the latest is 1.16.7. Would it be possible to update it please?
Thank you.

Update to 1.17.6

Hello! It looks like there's a new release, which causes the currently packaged version to fail to launch. If no one else gets a chance before me, I'll try to make a PR with the update.

Error starting MakeMKV

Hello,
every time I start MakeMKV I get the following error:

Failed to create wl_display (No such file or directory)
qt.qpa.plugin: Could not load the Qt platform plugin "wayland" in "" even though it was found.
Qt: Session management error: Could not open network socket
info string reallocated, size=837

My specs:
kernel: 6.6.2-1-siduction-amd64
GPU: AMD Radeon RX 580
OS: Siduction (Debian Sid)

Update to 1.17.5

Hi! Since recently a new version has been released so I can't use the old one anymore. Would it be possible to update?

Project license should link to license

The appdata just says:

    <project_license>LicenseRef-proprietary AND GPL-2.0 AND LGPL-2.1-only</project_license>

Ideally this would link to the license online, similarly to those other projects on Flathub:

    <project_license>LicenseRef-proprietary=https://botfather.io/docs/legal/tos/</project_license>
    <project_license>LicenseRef-proprietary=https://code.visualstudio.com/license</project_license>
    <project_license>LicenseRef-proprietary=https://raw.githubusercontent.com/snes9xgit/snes9x/master/docs/snes9x-license.txt AND LGPL-2.1</project_license>
    <project_license>LicenseRef-proprietary=https://wwwimages2.adobe.com/content/dam/acom/en/legal/licenses-terms/pdf/Flash_Player_30_0.pdf</project_license>
    <project_license>LicenseRef-proprietary=https://www.spotify.com/us/legal/end-user-agreement/</project_license>
    <project_license>LicenseRef-proprietary=https://www.sublimetext.com/eula</project_license>

MakeMKV apparently does not work with openjdk11.

Please see here:
https://www.makemkv.com/forum/viewtopic.php?t=18879

With the bundled version of openjdk11 we see the following error in the debug log:

...
003344:0000 Using Java runtime from /app/jre/bin/java
java_exception(6) : java.lang.NullPointerException
java.lang.NullPointerException
	at com.makemkv.Runtime.a(Unknown Source)
	at com.makemkv.Runtime.b(Unknown Source)
	at com.makemkv.g.action(Unknown Source)
	at blues.Server.actionInvoke(Server.java:245)
	at blues.Server.access$000(Server.java:33)
	at blues.Server$1.run(Server.java:196)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
...

According to the MakeMKV forums the older java 1.8 should be used instead.
Perhaps the "sdk org.freedesktop.Sdk.Extension.openjdk8" could be used instead?

That said, I tried to configure an override so MakeMKV points at my system-wide java.

sudo flatpak override --filesystem=/usr/lib/jvm/ com.makemkv.MakeMKV

And, then of course configuring MakeMKV preferences accordingly to use "/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.275.b01-1.fc32.x86_64/jre/bin/java"

But that doesn't work either, the log goes like this:

004041:0000 Failed to execute external program 'java' from location '/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.275.b01-1.fc32.x86_64/jre/bin/java'

Does anybody have an idea of a way forward?

ccextractor fails to run

Attempting to rip DVD gives me:

Unable to execute external program 'ccextractor' as its path is not set in preferences
Failed to execute external program 'ccextractor' from location '/app/bin/mmccextr'

The file exists, but, something is wrong with it.

Disabling the subtitle in the title selection creates a proper mkv rip output.

Using FLAC profile fails ripping

I just tried for the first time the FLAC profile for a DTS-HD Master Audio stereo track and the rip fails. When the ripping starts, the "analyzing seamless segments" of the title just stays there the whole time, no actual ripping happens. During the whole process MakeMKV starts gradually hogging RAM (analyzing seamless segments for a while, and then RAM usage grows about 3-5 GB.. this repeats the longer you allow it to run) and eventually, when all available RAM is used, the swap starts to fill up too. In my case the ripping process ends before all RAM and swap space is used (otherwise it probably would crash the system) and MakeMKV reports:

Failed to save title 1 to file /home/USER/RIP/movie_t02.mkv
0 titles saved, 1 failed
Copy complete. 0 titles saved, 1 failed.

The last line appears in the log file.

16 GB RAM + about 10 GB of swap space is taken when the ripping process stops and MakeMKV doesn't release all that until the program is closed.

Tried to turn on the log, but there's nothing in the about 80,000 lines that would give any hint of why the process fails.

Ripping the title with the DTS-HD Master Audio stereo track with "default" profile works. Although, the rip informs this:

AV sync issue in stream 1 at 0:26:01.726 : audio changes from 16bps to 24bps, you won't be able to convert this track to any other format later, please use a conversion profile with audio transcoding
AV sync issue in stream 1 at 0:58:47.565 : audio changes from 16bps to 24bps, you won't be able to convert this track to any other format later, please use a conversion profile with audio transcoding
AV sync issue in stream 1 at 1:32:49.522 : audio changes from 16bps to 24bps, you won't be able to convert this track to any other format later, please use a conversion profile with audio transcoding

The audio drops out for a second on those points when playing the ripped DTS-HD MA track. The disc obviously has an authoring problem. I have already confirmed that the actual audio in that track is not faulty, it's the "encoding"/metadata/or something similar, don't know the technical stuff (I used ffmpeg to convert the ripped .dts track to .flac and it plays fine). I don't know how true that "you won't be able to convert this track to any other format later" statement is, but I wanted to try to rip straight to FLAC with MakeMKV.

I tried the FLAC profile with another title that doesn't have any problems listed when ripping with the "default" profile and the same problem happens.

I then tried with MakeMKV installed in Windows 10 (in VirtualBox) and ripping with FLAC profile worked just fine, no problems at all!

I did all tests from a disc backup (encryption removed) made with MakeMKV. The backup process didn't give any errors.

Very hard to find any similar problems from the net about this, there's this one from 2015 that mentions "if attempt to use the FLAC profile to convert the lossless audio into FLAC the program crashes once it begins “analyzing seamless segments”". That user is not using Flatpak though. In the 10th message of that topic, the user mentions what might have fixed the problem:

... I’m not sure what the difference was from running these steps, maybe the libffmpeg-devel package which I don’t think was installed was the difference

I vaguely remember seeing somebody mention at some website, maybe in the MakeMKV forum, that only the Windows installer installs MakeMKV's own ffmpeg.

So, maybe the problem is that Flatpak MakeMKV can't access ffmpeg?

I tried to install runtime/org.freedesktop.Platform.ffmpeg-full/x86_64/23.08 Flatpak (I believe the 23.08 branch is the same as Flatpak MakeMKV is currently using) and did the rip with FLAC profile again, but it fails the same way.

Anyone willing to test FLAC profile ripping with their Flatpak MakeMKV?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.