GithubHelp home page GithubHelp logo

io.freetubeapp.freetube's People

Contributors

aiz0 avatar bbhtt avatar erick555 avatar gitcontrib0 avatar jn64 avatar joshuamacklin avatar lctrs avatar leandrostanger avatar mat8913 avatar prestonn avatar samueltzr avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

io.freetubeapp.freetube's Issues

Freetube 0.9.3 Beta doesn't run

Running Freetube 0.9.3 Beta results in the following:

$ flatpak run io.freetubeapp.FreeTube
/app/bin/zypak-wrapper: line 24: /app/freetube/freetube: No such file or directory
$ flatpak list | rg freetube
FreeTube	io.freetubeapp.FreeTube	0.9.3 Beta	stable	user

App Icon not applying icon theme and could not add icon to dock in Solus

Issue in title. I was able to fix this by adding this line toStartupWMClass=FreeTube to the io.freetubeapp.FreeTube.desktop file. After the latest flatpak update I had to reapply this line to the file. I was hoping to this fix can be pushed to the upstream. Thanks.
Read here for more info on the topic: https://discuss.getsol.us/d/3227-in-budgie-some-flatpaks-won-t-save-to-the-panel
It seems to affect other GNOME based environments as well.

Will switching to Electron Builder be a problem?

Hey there @mat8913

I've been recently having some issues with getting the extension to work with the latest version of Electron provided by electron-forge. I'm only in the early stages of this, but I'm thinking about switching over to Electron Builder for future builds of FreeTube. Will this cause a problem with the Flatpak release? I see that Electron Builder doesn't support Flatpak but I'm not sure how the build process of it goes. If needed, I can keep electron-forge as a dependency but I'd primarily use Electron Builder moving forward. Curious on your thoughts with this.

Icon not showing up

In the screenshot provided in #6, the FreeTube icon isn't showing for some reason. On both my laptops (running GNOME) the icon does show, so further investigation is needed.

Please update FreeTube to 0.7.3

This update includes some pretty essential fixes to the errors which make the current flatpak version basically unusable.

No FreeTube icon in window (tab) when installed with flatpak on Xubuntu

Steps to reproduce

On Xubuntu LTS 22.04.01 install the latest FreeTube version (v0.18.0 Beta) using:

$ sudo flatpak install flathub io.freetubeapp.FreeTube

Log out & in, or even restart your machine.
The .desktop launcher shows the FreeTube icon.

Expected result

When launching FreeTube, the window desktop tab and window decoration should show the FreeTube icon for easy retrieval. This is especially useful when Alt+Tabbing between open applications.

Actual result

A generic window blue-white icon is shown instead.

Environment

  • Operating system:
    OS: Xubuntu 22.04.1 LTS x86_64
    Kernel: 5.15.0-58-generic
    DE: Xfce
    WM: Xfwm4
    WM Theme: Numix
    Theme: Greybird [GTK2/3]
    Icons: Faenza-Darker [GTK2], elementary-xfce-darker [GTK3]
  • Debug info (during installation):

Additional information

Other applications installed using flatpak do show their custom window icons on this system. E.g.: Jabref and Telegram Desktop. These applications have in common that they store an icon file in the directory: /var/lib/flatpak/exports/share/icons/hicolor/128x128/apps/

Register FreeTube as a web URL handler

FreeTube can open http urls, so the desktop entry should reflect that. You could add
text/html;text/xml;application/xhtml+xml;text/mml;x-scheme-handler/http;x-scheme-handler/https; to MimeType in the desktop file. That way apps like Junction will recognize it.

Data Settings options only show Donwloads folder

I clicked 'Data Settings' - 'Import Subscriptions' to import a .db file, but I only see the Home/Downloads folder. It is not possible to select other folders or disks. This does not happen in the appimage.
Edit: I tried all the other options in the Data Settings section and it's the same problem. For every button, only the Downloads folder shows and nothing else.

There was an error calling the Invidious API

I'm having the right error when I import my youtube subscriptions via file. I'm using the flatpak version of the official flathub repository.

https://postimg.cc/YjqwCQTn

Any idea?

I'm having the right error when I import my youtube subscriptions via file. I'm using the flatpak version of the official flathub repository.

https://postimg.cc/YjqwCQTn

Any idea?

My system:

System:
Host: vagnarok-PC Kernel: 4.18.0-16-generic x86_64 bits: 64
Desktop: Cinnamon 4.0.10 Distro: Linux Mint 19.1 Tessa
Machine:
Type: Desktop System: Itautec S.A. product: Infoway v: Corp
serial:
Mobo: Itautec S.A. model: ST 4262 v: ST-4262 Padrao 06(Itautec_M)
serial: BIOS: Itautec ST 4262 6.00 PG -SL2.1 v: FC
date: 08/21/2009
CPU:
Topology: Dual Core model: Intel Core2 Duo E8400 bits: 64 type: MCP
L2 cache: 6144 KiB
Speed: 2826 MHz min/max: 2000/2667 MHz Core speeds (MHz): 1: 2826 2: 2826
Graphics:
Device-1: NVIDIA G96 [GeForce 9500 GT] driver: nvidia v: 340.107
Display: x11 server: X.Org 1.20.1 driver: nvidia
unloaded: fbdev,modesetting,nouveau,vesa resolution: 1400x900~60Hz
OpenGL: renderer: GeForce 9500 GT/PCIe/SSE2 v: 3.3.0 NVIDIA 340.107
Audio:
Device-1: Intel 82801JD/DO HD Audio driver: snd_hda_intel
Sound Server: ALSA v: k4.18.0-16-generic
Network:
Device-1: Intel 82567LM-3 Gigabit Network driver: e1000e
IF: enp0s25 state: up speed: 100 Mbps duplex: full mac: 00:24:1d:f3:7a:35
Drives:
Local Storage: total: 2.28 TiB used: 1.20 TiB (52.4%)
ID-1: /dev/sda vendor: Western Digital model: WD5000AAKS-00D2B0
size: 465.76 GiB
ID-2: /dev/sdb vendor: Samsung model: HD204UI size: 1.82 TiB
ID-3: /dev/sdc type: USB vendor: SanDisk model: Cruzer Blade
size: 7.45 GiB
Partition:
ID-1: / size: 457.45 GiB used: 203.05 GiB (44.4%) fs: ext4 dev: /dev/sda1
Sensors:
System Temperatures: cpu: 48.0 C mobo: N/A gpu: nvidia temp: 52 C
Fan Speeds (RPM): N/A
Info:
Processes: 221 Uptime: 26m Memory: 7.67 GiB used: 3.54 GiB (46.2%)
Shell: bash inxi: 3.0.27

Idea: Moving to nightly Freetube builds

With respects to Electron 22.3.25 / Chrome 108 being pretty out of date and the security implications of running said older versions.

Would there be interest in moving the flatpak over to the Nightly builds where updates are much more frequent?
or maybe perhaps a new Freetube(Nightly) Flatpak.

0.7.1 is out.

Invidious Instances has been getting hit pretty hard with I.P bans, and 0.7.1 has a workaround for it.

Doesnt start on Wayland

I guess its not supported yet, but it would be great if we could use it on Wayland too.

Operating System: Kubuntu 21.10
KDE Plasma Version: 5.23.5
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.2
Kernel Version: 5.13.0-28-generic (64-bit)
Graphics Platform: Wayland

Sound interrupted when FreeTube window unfocused

Since updating to 0.20.0 the app became unable to play videos in the background. Whenever the window is not focused, the sound experiences long interruptions of silence.

Focusing the window, or even entering the desktop overview so that the window becomes visible, restores the sound.

This may be an upstream problem with the app, but my first guess is that it's a Flatpak permissions issue, which is why I started by reporting it here.

Rolling back to the previous commit from Flathub, 7869a90dd4ae09be42c15e77e3bae5e689a021ee8029a37dbf2882a0f22df684, fixes the problem for me.

[Bug]: Crash on flatpak + debian 12 (gnome 43.4 + x11)

Describe the bug

Open freetube
It's Crash

(the first time I was able to import my subscriptions in db format)

Expected Behavior

Just working joy
Issue Labels

causes crash, inconsistent behavior, visual bug

FreeTube Version

0.18.0 Beta

Operating System Version

Debian 12 (gnome 43.4 + x11)

Installation Method
Flathub

Additional informations :

I have tried to install Freetube with deb package and nightbuild deb package and for both it's works without any issue. So it's seems the issue came form Flatpak package

Plus, I has no issue on Debian 11 (gnome) with flatpak

Issue on freetube repo : #FreeTubeApp/FreeTube#3638

--socket=session-bus is an overly broad permission

This permission is a complete bypass of Flatpak's sandbox and is almost always the incorrect thing to to do.

Steps to resolve:

  1. Remove --socket=session-bus
  2. Run the application with --log-session-bus. This will print a log of which dbus calls are actually used and blocked.
  3. Add specific --talk-name=org.example.Name to talk to a service. Occasionally you'll need to add --own-name=org.example.Name to own a name but this is less common.

Let me know if you have any trouble tracking down a feature not working.

Stuttering playback when using video acceleration on XWayland

I decided lately to try using video acceleration with Freetube.

I have tried this in two devices running Fedora 37 (Gnome) and experienced exact the same behavior.

  • A laptop with an intel APU (Intel i7 1255U), using intel-media-driver.

  • A desktop with an AMD Radeon GPU (RX 6700 XT). Using amdgpu driver and mesa-va-drivers-freeworld.

In an X11 session

I managed to make video acceleration work (both with the flatpak and the rpm version of FreeTube) with the following command and everything worked fine.
flatpak run io.freetubeapp.FreeTube --disable-features=UseChromeOSDirectVideoDecoder --use-gl=egl

In a Wayland session

Freetube defaults to using XWayland. I managed to make video acceleration work with the previous command but the video playback is stuttering when video acceleration is turned on.

The catch

When using the rpm provided at the FreeTube website, the above issue does not happen. Video acceleration works on a Wayland session, by using XWayland, and the video is smooth and nice.

So, my question is: Could there exist some limitation when it comes to hardware acceleration when using Freetube in XWayland with flatpak?

Note: I managed to run FreeTube using Wayland (not XWayland) with the following command but was never able to make video acceleration work (neither with the flatpak nor with the rpm version).
flatpak run --nosocket=x11 --socket=fallback-x11 --socket=wayland io.freetubeapp.FreeTube --enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform=wayland --disable-features=UseChromeOSDirectVideoDecoder --use-gl=egl

Note2: I check if video acceleration is up and running by using the intel_gpu_top command. One can also get an indication about gpu usage with the radeontop command.

source of updates

Hi!

I've received an update for FreeTube today, but there seems no changes were made recently on any of the branches...
Is there a weird thing going on with flathub?

How do I check what's changed on my side?

freetube_updates

Add MPV and possibly Flatpak talk permissions

Adding the MPV and Flatpak session talk permissions by default will allow these workarounds for the mpv external player (FreeTubeApp/FreeTube#1735 (comment)) and mpv flatpak player (FreeTubeApp/FreeTube#1735 (comment)) to work without the use of flatpak-overide or Flatseal after 0b495c9. Once the code takes into account that it is installed in a flatpak, this will be required by default for the app to work smoothly. I can understand not implementing the talk bus for the entirety of Flatpak on the system (ie: the workaround for when mpv is installed as a Flatpak), but the MPV talk permission (for when MPV is installed as a binary on the system) only access one program and would seem safe from easily "escaping the sandbox".

org.freedesktop.Flatpak is the dbus bus name for flatpak, but I don't know the bus name for mpv you would need to use for the talks permission, and can't seem to find it online (it might be io.mpv.Mpv as that is what flatpak calls it, but I honestly don't know if flatpak names and dbus bus names are connected at all).

Flatpak broken after latest update

flatpak run io.freetubeapp.FreeTube
/app/bin/zypak-wrapper: line 24: /app/freetube/freetube: Not a directory
/app/bin/zypak-wrapper: line 24: exec: /app/freetube/freetube: cannot execute: Not a directory

Error when trying to watch videos

Hi,
I am not sure where to report this, whether it is a FlatPak FreeTube app related issue or general FreeTube related issue.

When trying to watch some videos (like fH14oI_PJAQ), I get the following errors:

Local API ERROR: Error: Status code: 404
Falling back to Invidious API

and then

Invidious API ERROR: {"error":"Could not extract video info. Instance is likely blocked."}

The video eventually fails to load and I get this empty player:

image

I mention that I am using the latest version of FreeTube available on FlatHub. A few videos are working but not many.
Thanks in advance

Need help flatpaking the remake

I'm trying to flatpak the upcoming remake: https://github.com/FreeTubeApp/FreeTube-Vue/tree/4728d38df09aa4f32d6d428b9c3a5ebe7ee2ee63

I'll post more details when I get some time on the weekend, but basically I'm getting this error:

Running: npm install --offline --cache=$FLATPAK_BUILDER_BUILDDIR/flatpak-node/npm-cache

> [email protected] install /run/build/freetube/node_modules/node-expat
> node-gyp rebuild

gyp WARN install got an error, rolling back install
gyp ERR! configure error 
gyp ERR! stack Error: getaddrinfo EAI_AGAIN nodejs.org
gyp ERR! stack     at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:64:26)
gyp ERR! System Linux 4.19.0-8-amd64
gyp ERR! command "/usr/lib/sdk/node12/bin/node" "/usr/lib/sdk/node12/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /run/build/freetube/node_modules/node-expat
gyp ERR! node -v v12.16.0
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok 
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/jest-haste-map/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /run/build/freetube/flatpak-node/npm-cache/_logs/2020-03-02T11_51_03_597Z-debug.log
Error: module freetube: Child process exited with code 1

Github Actions Bot to help with maintence

Is there any interest in adding a github actions bot to automatically make PRs / builds on new releases? Could make maintaining the flathub repo a breeze!

Plus with Flathubs push for more robust metadata, this could help close the Changelog issue and have it automated.

I could look into myself if no one else has experience using it.

Black Screen Upon Launch

I'm trying to use the flatpak on Fedora 36, but every time it launches it gives me the following errors, and proceeds to launch a black screen with the heading 'Subscriptions - FreeTube'. My best guess is it's something to do with my using Wayland (w/ proprietary nVidia drivers), but I'm not sure how to go about making it work.

LaunchProcess: failed to execvp:
xdg-settings
Gtk-Message: 08:26:37.045: Failed to load module "canberra-gtk-module"
Gtk-Message: 08:26:37.045: Failed to load module "pk-gtk-module"
Gtk-Message: 08:26:37.045: Failed to load module "canberra-gtk-module"
Gtk-Message: 08:26:37.045: Failed to load module "pk-gtk-module"
[2:0803/082637.065679:ERROR:bus.cc(393)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
libva error: vaGetDriverNameByIndex() failed with unknown libva error, driver_name = (null)
TypeError: Cannot destructure property 'value' of 'object null' as it is null.
    at /app/freetube/resources/app.asar/dist/main.js:1:4801
    at async W (/app/freetube/resources/app.asar/dist/main.js:1:4757)
    at async App.<anonymous> (/app/freetube/resources/app.asar/dist/main.js:1:8870)
(node:2) UnhandledPromiseRejectionWarning: Error: Cannot create a secure cookie from an insecure URL
(Use `freetube --trace-warnings ...` to show where the warning was created)
(node:2) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:2) UnhandledPromiseRejectionWarning: Error: Cannot create a secure cookie from an insecure URL
(node:2) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)

image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.