flathub / shared-modules

Common Flatpak modules that can be used as a git submodule

This repository contains commonly shared modules and is intended to be used as a git submodule.

Each submodule may include additional instructions to be used properly. Please check the folder containing that module to see if anything extra needs to be done.

To use shared modules for packaging an application, add the submodule:

git submodule add https://github.com/flathub/shared-modules.git

Then modules from this repository can be specified in a JSON manifest file like this:

"modules": [
  "shared-modules/SDL/SDL-1.2.15.json",
  {
    "name": "foo"
  }
]

And for a YAML manifest:

modules:
  - shared-modules/SDL/SDL-1.2.15.json

  - name: foo

To update the submodule:

git submodule update --remote --merge

To remove the submodule:

git submodule deinit -f -- shared-modules
rm -rf .git/modules/shared-modules
git rm -f shared-modules
rm .gitmodules

Please do not request adding modules unless they have many users in the Flathub repository.

All shared modules manifests in this repository are, and need to be, in the JSON format, which is supported by both Flatpak manifest formats, JSON and YAML.

shared-modules's Issues

WxWidgets seems to be used a lot

I've noticed that quite a few flatpaks use WxWidgets, each with their own custom build rules. Would it be worth adding it to the shared modules?

Add SDL_sound module

Please, consider adding SDL_sound module. It is required, for example, by compressed audio feature of DOSBox.

Update libsecret to 0.20.1

libsecret was recently updated: https://gitlab.gnome.org/GNOME/libsecret/-/tags

Building the Pygame module fails in the GNOME 3.30 runtime

The app Electrip is currently in the review process for Flathub. Besides the GNOME runtime it only requires Pygame as a dependency. Me and the reviewers would like to deploy it in the 3.30 runtime, however flatpak-builder crashes while building the dependency module pygame from shared-modules.

How to reproduce:

1. Build Electrip with this manifest that uses the 3.28 runtime. It works.
2. Change the runtime in the manifest to 3.30. Try again to build the app.
   The build fails with the following trace:

========================================================================
Building module pygame in /home/momits/Programme/electrip/.flatpak-builder/build/pygame-4
========================================================================
Applying patch pygame-add-search-dirs.patch
patching file config_unix.py
Running: pip3 install --ignore-installed --no-deps --prefix=/app .
Processing /run/build/pygame
Installing collected packages: pygame
  Running setup.py install for pygame ... error
    Complete output from command /usr/bin/python3.7 -u -c "import setuptools, tokenize;__file__='/tmp/pip-req-build-0wv7893c/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-vio75xwk/install-record.txt --single-version-externally-managed --prefix /app --compile:
    running install
    running build
    running build_py
    creating build
    creating build/lib.linux-x86_64-3.7
    creating build/lib.linux-x86_64-3.7/pygame
    copying lib/_numpysurfarray.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/freetype.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/sysfont.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/__init__.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/ftfont.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/locals.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/sndarray.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/_dummybackend.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/pkgdata.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/midi.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/macosx.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/camera.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/version.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/cursors.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/compat.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/colordict.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/sprite.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/_camera_vidcapture.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/surfarray.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/_camera_opencv_highgui.py -> build/lib.linux-x86_64-3.7/pygame
    copying lib/_numpysndarray.py -> build/lib.linux-x86_64-3.7/pygame
    creating build/lib.linux-x86_64-3.7/pygame/gp2x
    copying lib/gp2x/__init__.py -> build/lib.linux-x86_64-3.7/pygame/gp2x
    copying lib/gp2x/locals.py -> build/lib.linux-x86_64-3.7/pygame/gp2x
    copying lib/gp2x/constants.py -> build/lib.linux-x86_64-3.7/pygame/gp2x
    creating build/lib.linux-x86_64-3.7/pygame/threads
    copying lib/threads/Py25Queue.py -> build/lib.linux-x86_64-3.7/pygame/threads
    copying lib/threads/__init__.py -> build/lib.linux-x86_64-3.7/pygame/threads
    creating build/lib.linux-x86_64-3.7/pygame/tests
    copying test/mask_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/surfarray_tags.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/color_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/ftfont_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/scrap_tags.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/gfxdraw_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/__main__.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/cursors_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/imageext_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/sprite_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/imageext_tags.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/camera_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/scrap_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/surface_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/test_test_.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/pixelarray_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/mixer_music_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/sndarray_tags.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/display_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/freetype_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/threads_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/compat_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/overlay_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/cdrom_tags.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/transform_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/rwobject_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/joystick_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/font_tags.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/blit_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/midi_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/fastevent_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/sndarray_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/surflock_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/key_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/mixer_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/ftfont_tags.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/cdrom_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/pixelcopy_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/mouse_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/base_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/image_tags.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/draw_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/bufferproxy_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/midi_tags.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/mixer_tags.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/font_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/freetype_tags.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/math_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/sysfont_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/rect_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/surfarray_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/mixer_music_tags.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/event_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/time_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/image__save_gl_surface_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    copying test/image_test.py -> build/lib.linux-x86_64-3.7/pygame/tests
    creating build/lib.linux-x86_64-3.7/pygame/tests/test_utils
    copying test/test_utils/test_runner.py -> build/lib.linux-x86_64-3.7/pygame/tests/test_utils
    copying test/test_utils/buftools.py -> build/lib.linux-x86_64-3.7/pygame/tests/test_utils
    copying test/test_utils/run_tests.py -> build/lib.linux-x86_64-3.7/pygame/tests/test_utils
    copying test/test_utils/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests/test_utils
    copying test/test_utils/test_machinery.py -> build/lib.linux-x86_64-3.7/pygame/tests/test_utils
    copying test/test_utils/async_sub.py -> build/lib.linux-x86_64-3.7/pygame/tests/test_utils
    copying test/test_utils/endian.py -> build/lib.linux-x86_64-3.7/pygame/tests/test_utils
    copying test/test_utils/arrinter.py -> build/lib.linux-x86_64-3.7/pygame/tests/test_utils
    copying test/test_utils/png.py -> build/lib.linux-x86_64-3.7/pygame/tests/test_utils
    creating build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests
    copying test/run_tests__tests/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests
    copying test/run_tests__tests/run_tests__test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests
    creating build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/all_ok
    copying test/run_tests__tests/all_ok/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/all_ok
    copying test/run_tests__tests/all_ok/fake_2_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/all_ok
    copying test/run_tests__tests/all_ok/fake_6_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/all_ok
    copying test/run_tests__tests/all_ok/zero_tests_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/all_ok
    copying test/run_tests__tests/all_ok/no_assertions__ret_code_of_1__test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/all_ok
    copying test/run_tests__tests/all_ok/fake_5_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/all_ok
    copying test/run_tests__tests/all_ok/fake_3_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/all_ok
    copying test/run_tests__tests/all_ok/fake_4_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/all_ok
    creating build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/failures1
    copying test/run_tests__tests/failures1/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/failures1
    copying test/run_tests__tests/failures1/fake_2_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/failures1
    copying test/run_tests__tests/failures1/fake_3_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/failures1
    copying test/run_tests__tests/failures1/fake_4_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/failures1
    creating build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/incomplete
    copying test/run_tests__tests/incomplete/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/incomplete
    copying test/run_tests__tests/incomplete/fake_2_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/incomplete
    copying test/run_tests__tests/incomplete/fake_3_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/incomplete
    creating build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/infinite_loop
    copying test/run_tests__tests/infinite_loop/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/infinite_loop
    copying test/run_tests__tests/infinite_loop/fake_2_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/infinite_loop
    copying test/run_tests__tests/infinite_loop/fake_1_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/infinite_loop
    creating build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/print_stderr
    copying test/run_tests__tests/print_stderr/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/print_stderr
    copying test/run_tests__tests/print_stderr/fake_2_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/print_stderr
    copying test/run_tests__tests/print_stderr/fake_3_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/print_stderr
    copying test/run_tests__tests/print_stderr/fake_4_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/print_stderr
    creating build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/print_stdout
    copying test/run_tests__tests/print_stdout/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/print_stdout
    copying test/run_tests__tests/print_stdout/fake_2_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/print_stdout
    copying test/run_tests__tests/print_stdout/fake_3_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/print_stdout
    copying test/run_tests__tests/print_stdout/fake_4_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/print_stdout
    creating build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/incomplete_todo
    copying test/run_tests__tests/incomplete_todo/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/incomplete_todo
    copying test/run_tests__tests/incomplete_todo/fake_2_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/incomplete_todo
    copying test/run_tests__tests/incomplete_todo/fake_3_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/incomplete_todo
    creating build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/exclude
    copying test/run_tests__tests/exclude/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/exclude
    copying test/run_tests__tests/exclude/fake_2_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/exclude
    copying test/run_tests__tests/exclude/invisible_tag_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/exclude
    copying test/run_tests__tests/exclude/magic_tag_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/exclude
    creating build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/timeout
    copying test/run_tests__tests/timeout/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/timeout
    copying test/run_tests__tests/timeout/fake_2_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/timeout
    copying test/run_tests__tests/timeout/sleep_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/timeout
    creating build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/everything
    copying test/run_tests__tests/everything/incomplete_todo_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/everything
    copying test/run_tests__tests/everything/__init__.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/everything
    copying test/run_tests__tests/everything/fake_2_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/everything
    copying test/run_tests__tests/everything/sleep_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/everything
    copying test/run_tests__tests/everything/magic_tag_test.py -> build/lib.linux-x86_64-3.7/pygame/tests/run_tests__tests/everything
    creating build/lib.linux-x86_64-3.7/pygame/docs
    copying docs/__main__.py -> build/lib.linux-x86_64-3.7/pygame/docs
    copying docs/__init__.py -> build/lib.linux-x86_64-3.7/pygame/docs
    creating build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/sound.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/eventlist.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/aacircle.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/moveit.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/mask.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/prevent_display_stretching.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/stars.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/__init__.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/headless_no_windows_needed.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/fastevents.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/blit_blends.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/pixelarray.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/oldalien.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/aliens.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/scrap_clipboard.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/blend_fill.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/testsprite.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/sound_array_demos.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/midi.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/overlay.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/camera.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/chimp.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/glcube.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/scaletest.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/scroll.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/cursors.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/vgrade.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/fonty.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/freetype_misc.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/playmus.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/arraydemo.py -> build/lib.linux-x86_64-3.7/pygame/examples
    copying examples/liquid.py -> build/lib.linux-x86_64-3.7/pygame/examples
    running build_ext
    building 'pygame.imageext' extension
    creating build/temp.linux-x86_64-3.7
    creating build/temp.linux-x86_64-3.7/src
    x86_64-unknown-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O3 -Wall -O2 -g -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -fPIC -D_REENTRANT -DENABLE_NEWBUF=1 -I/usr/X11R6/include -I/app/include/SDL -I/app/include/SDL -I/usr/include -I/usr/include -I/usr/include/python3.7m -c src/imageext.c -o build/temp.linux-x86_64-3.7/src/imageext.o
    In file included from src/pygame.h:32,
                     from src/imageext.c:49:
    src/imageext.c: In function ‘opengltosdl’:
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/imageext.c:632:9: note: in expansion of macro ‘RAISE’
             RAISE (PyExc_RuntimeError, "Cannot get video surface.");
             ^~~~~
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/imageext.c:636:9: note: in expansion of macro ‘RAISE’
             RAISE (PyExc_RuntimeError, "Cannot find glReadPixels function.");
             ^~~~~
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/imageext.c:643:9: note: in expansion of macro ‘RAISE’
             RAISE (PyExc_MemoryError, "Cannot allocate enough memory for pixels.");
             ^~~~~
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/imageext.c:663:9: note: in expansion of macro ‘RAISE’
             RAISE (PyExc_SDLError, SDL_GetError ());
             ^~~~~
    x86_64-unknown-linux-gnu-gcc -pthread -shared -fstack-protector-strong -Wl,-z,relro,-z,now -fstack-protector-strong -Wl,-z,relro,-z,now -L/app/lib -fstack-protector-strong -Wl,-z,relro,-z,now -O2 -g -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.7/src/imageext.o -L/app/lib -L/app/lib -L/app/lib -L/app/lib -L/usr/lib/x86_64-linux-gnu -lSDL -lpthread -lSDL_image -lpng -ljpeg -lpython3.7m -o build/lib.linux-x86_64-3.7/pygame/imageext.cpython-37m-x86_64-linux-gnu.so -Wl,-rpath,/app/lib
    building 'pygame.font' extension
    x86_64-unknown-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O3 -Wall -O2 -g -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -fPIC -D_REENTRANT -DENABLE_NEWBUF=1 -I/usr/X11R6/include -I/app/include/SDL -I/app/include/SDL -I/usr/include/python3.7m -c src/font.c -o build/temp.linux-x86_64-3.7/src/font.o
    In file included from src/pygame.h:32,
                     from src/font.c:31:
    src/font.c: In function ‘font_init’:
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/font.c:619:9: note: in expansion of macro ‘RAISE’
             RAISE(PyExc_SDLError, "font not initialized");
             ^~~~~
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/font.c:724:9: note: in expansion of macro ‘RAISE’
             RAISE(PyExc_RuntimeError, SDL_GetError());
             ^~~~~
    x86_64-unknown-linux-gnu-gcc -pthread -shared -fstack-protector-strong -Wl,-z,relro,-z,now -fstack-protector-strong -Wl,-z,relro,-z,now -L/app/lib -fstack-protector-strong -Wl,-z,relro,-z,now -O2 -g -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.7/src/font.o -L/app/lib -L/app/lib -L/usr/lib/x86_64-linux-gnu -lSDL -lpthread -lSDL_ttf -lpython3.7m -o build/lib.linux-x86_64-3.7/pygame/font.cpython-37m-x86_64-linux-gnu.so -Wl,-rpath,/app/lib
    building 'pygame.mixer' extension
    x86_64-unknown-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O3 -Wall -O2 -g -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -fPIC -D_REENTRANT -DENABLE_NEWBUF=1 -I/usr/X11R6/include -I/app/include/SDL -I/app/include/SDL -I/usr/include/python3.7m -c src/mixer.c -o build/temp.linux-x86_64-3.7/src/mixer.o
    In file included from src/pygame.h:32,
                     from src/mixer.c:27:
    src/mixer.c: In function ‘_format_view_to_audio’:
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/mixer.c:136:9: note: in expansion of macro ‘RAISE’
             RAISE(PyExc_ValueError, "Array has unsupported item format");
             ^~~~~
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/mixer.c:165:13: note: in expansion of macro ‘RAISE’
                 RAISE(PyExc_ValueError, "Array has unsupported item format");
                 ^~~~~
    src/mixer.c: In function ‘_chunk_from_array’:
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/mixer.c:1363:9: note: in expansion of macro ‘RAISE’
             RAISE(PyExc_SDLError, "Mixer not initialized");
             ^~~~~
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/mixer.c:1371:13: note: in expansion of macro ‘RAISE’
                 RAISE(PyExc_ValueError,
                 ^~~~~
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/mixer.c:1378:13: note: in expansion of macro ‘RAISE’
                 RAISE(PyExc_ValueError,
                 ^~~~~
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/mixer.c:1383:13: note: in expansion of macro ‘RAISE’
                 RAISE(PyExc_ValueError,
                 ^~~~~
    src/mixer.c: In function ‘sound_init’:
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/mixer.c:1516:13: note: in expansion of macro ‘RAISE’
                 RAISE(PyExc_TypeError, arg_cnt_err_msg);
                 ^~~~~
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/mixer.c:1532:13: note: in expansion of macro ‘RAISE’
                 RAISE(PyExc_TypeError, arg_cnt_err_msg);
                 ^~~~~
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/mixer.c:1555:13: note: in expansion of macro ‘RAISE’
                 RAISE(PyExc_TypeError,
                 ^~~~~
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/mixer.c:1561:9: note: in expansion of macro ‘RAISE’
             RAISE(PyExc_TypeError, arg_cnt_err_msg);
             ^~~~~
    src/_pygame.h:206:46: warning: right-hand operand of comma expression has no effect [-Wunused-value]
     #define RAISE(x,y) (PyErr_SetString((x), (y)), (PyObject*)NULL)
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    src/mixer.c:1585:21: note: in expansion of macro ‘RAISE’
                         RAISE(PyExc_SDLError, SDL_GetError());
                         ^~~~~
    x86_64-unknown-linux-gnu-gcc -pthread -shared -fstack-protector-strong -Wl,-z,relro,-z,now -fstack-protector-strong -Wl,-z,relro,-z,now -L/app/lib -fstack-protector-strong -Wl,-z,relro,-z,now -O2 -g -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.7/src/mixer.o -L/app/lib -L/app/lib -L/usr/lib/x86_64-linux-gnu -lSDL -lpthread -lSDL_mixer -lpython3.7m -o build/lib.linux-x86_64-3.7/pygame/mixer.cpython-37m-x86_64-linux-gnu.so -Wl,-rpath,/app/lib
    building 'pygame.mixer_music' extension
    x86_64-unknown-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O3 -Wall -O2 -g -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -fPIC -D_REENTRANT -DENABLE_NEWBUF=1 -I/usr/X11R6/include -I/app/include/SDL -I/app/include/SDL -I/usr/include/python3.7m -c src/music.c -o build/temp.linux-x86_64-3.7/src/music.o
    x86_64-unknown-linux-gnu-gcc -pthread -shared -fstack-protector-strong -Wl,-z,relro,-z,now -fstack-protector-strong -Wl,-z,relro,-z,now -L/app/lib -fstack-protector-strong -Wl,-z,relro,-z,now -O2 -g -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.7/src/music.o -L/app/lib -L/app/lib -L/usr/lib/x86_64-linux-gnu -lSDL -lpthread -lSDL_mixer -lpython3.7m -o build/lib.linux-x86_64-3.7/pygame/mixer_music.cpython-37m-x86_64-linux-gnu.so -Wl,-rpath,/app/lib
    building 'pygame.scrap' extension
    x86_64-unknown-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O3 -Wall -O2 -g -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -fPIC -D_REENTRANT -DENABLE_NEWBUF=1 -I/usr/X11R6/include -I/app/include/SDL -I/usr/include/python3.7m -c src/scrap.c -o build/temp.linux-x86_64-3.7/src/scrap.o
    In file included from src/scrap.c:60:
    src/scrap_x11.c: In function ‘pygame_scrap_get_types’:
    src/scrap_x11.c:842:35: warning: passing argument 2 of ‘PyDict_Next’ from incompatible pointer type [-Wincompatible-pointer-types]
             while (PyDict_Next (dict, &pos, &key, NULL))
                                       ^~~~
    In file included from /usr/include/python3.7m/Python.h:90,
                     from src/scrap.h:27,
                     from src/scrap.c:30:
    /usr/include/python3.7m/dictobject.h:96:31: note: expected ‘Py_ssize_t *’ {aka ‘long int *’} but argument is of type ‘int *’
         PyObject *mp, Py_ssize_t *pos, PyObject **key, PyObject **value);
                       ~~~~~~~~~~~~^~~
    x86_64-unknown-linux-gnu-gcc -pthread -shared -fstack-protector-strong -Wl,-z,relro,-z,now -fstack-protector-strong -Wl,-z,relro,-z,now -L/app/lib -fstack-protector-strong -Wl,-z,relro,-z,now -O2 -g -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.7/src/scrap.o -L/app/lib -L/app/lib -L/usr/lib/x86_64-linux-gnu -lSDL -lpthread -lX11 -lpython3.7m -o build/lib.linux-x86_64-3.7/pygame/scrap.cpython-37m-x86_64-linux-gnu.so -Wl,-rpath,/app/lib
    building 'pygame.pypm' extension
    x86_64-unknown-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O3 -Wall -O2 -g -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -fPIC -D_REENTRANT -DENABLE_NEWBUF=1 -I/usr/X11R6/include -I/app/include/SDL -I/app/include -I/app/include -I/usr/include/python3.7m -c src/pypm.c -o build/temp.linux-x86_64-3.7/src/pypm.o
    src/pypm.c: In function ‘__Pyx_ErrRestore’:
    src/pypm.c:4976:18: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_type’; did you mean ‘curexc_type’?
         if ((tstate->exc_type != NULL) & (tstate->exc_type != Py_None)) {
                      ^~~~~~~~
                      curexc_type
    src/pypm.c:4976:47: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_type’; did you mean ‘curexc_type’?
         if ((tstate->exc_type != NULL) & (tstate->exc_type != Py_None)) {
                                                   ^~~~~~~~
                                                   curexc_type
    src/pypm.c:4977:28: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_type’; did you mean ‘curexc_type’?
             tmp_type = tstate->exc_type;
                                ^~~~~~~~
                                curexc_type
    src/pypm.c:4978:29: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_value’; did you mean ‘curexc_value’?
             tmp_value = tstate->exc_value;
                                 ^~~~~~~~~
                                 curexc_value
    src/pypm.c:4979:26: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_traceback’; did you mean ‘curexc_traceback’?
             tmp_tb = tstate->exc_traceback;
                              ^~~~~~~~~~~~~
                              curexc_traceback
    src/pypm.c:4982:17: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_type’; did you mean ‘curexc_type’?
             tstate->exc_type = 0;
                     ^~~~~~~~
                     curexc_type
    src/pypm.c:4983:17: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_value’; did you mean ‘curexc_value’?
             tstate->exc_value = 0;
                     ^~~~~~~~~
                     curexc_value
    src/pypm.c:4984:17: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_traceback’; did you mean ‘curexc_traceback’?
             tstate->exc_traceback = 0;
                     ^~~~~~~~~~~~~
                     curexc_traceback
    At top level:
    src/pypm.c:2845:13: warning: ‘__pyx_doc_4pypm_5Input___dealloc__’ defined but not used [-Wunused-variable]
     static char __pyx_doc_4pypm_5Input___dealloc__[] = "Close midi device if still open when the instance is destroyed.";
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    src/pypm.c:2673:13: warning: ‘__pyx_doc_4pypm_5Input___init__’ defined but not used [-Wunused-variable]
     static char __pyx_doc_4pypm_5Input___init__[] = "Instantiate MIDI input stream object.";
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    src/pypm.c:1359:13: warning: ‘__pyx_doc_4pypm_6Output___dealloc__’ defined but not used [-Wunused-variable]
     static char __pyx_doc_4pypm_6Output___dealloc__[] = "Close midi device if still open when the instance is destroyed.";
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    src/pypm.c:1091:13: warning: ‘__pyx_doc_4pypm_6Output___init__’ defined but not used [-Wunused-variable]
     static char __pyx_doc_4pypm_6Output___init__[] = "Instantiate MIDI output stream object.";
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    error: command 'x86_64-unknown-linux-gnu-gcc' failed with exit status 1
    
    ----------------------------------------
Command "/usr/bin/python3.7 -u -c "import setuptools, tokenize;__file__='/tmp/pip-req-build-0wv7893c/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-vio75xwk/install-record.txt --single-version-externally-managed --prefix /app --compile" failed with error code 1 in /tmp/pip-req-build-0wv7893c/
Error: module pygame: Der Kindprozess wurde mit Status 1 beendet

ibus-1.5.20 is available

Refer to https://github.com/ibus/ibus

Add scons

It's used by about 10 separate modules, including the Godot engine.

LAME is outdated

Latest version is 3.100.
I'm using that in Asunder so it might be worth updating LAME in the shared-modules if that gives no incompatibility issues.

https://github.com/flathub/ca.littlesvr.asunder/blob/master/ca.littlesvr.asunder.yaml

Lua 5.3 updates break org.videolan.VLC

See flathub/org.videolan.VLC#111. The changes introduced are https://github.com/flathub/shared-modules/compare/d6455cb..66c9eff#diff-da898bf556886005e6fb5da79432b74b.

Enable OpenGL and xmlpatterns in Qt4

It need's to build Natron and some dependencies (e.g. shiboken)

gtk2: ibus-gtk2 seems to be broken

The ibus-gtk2 from shared-modules seems to be kind of broken. It is incompatible with ibus from gnome 3.32 runtime, which leads to various errors.

/app/lib/gtk-2.0/2.10.0/immodules/im-ibus.so: undefined symbol: ibus_input_context_set_client_commit_preedit

Loading IM context type 'ibus' failed

It is because of this update, which wasn't even tested.
d0a6cbb#diff-d777a79bcc73b6cc559d97d83520af82

Updated ibus to version 1.5.20
No additional testing has been done.

See also:
ibus/ibus@a40631e#diff-89f00c622efbd628bdc82af366f0db91

ibus from the shared-modules repo: 1.5.20
ibus from the GNOME 3.32 runtime: 1.5.17

It looks like that GIMP has already hit this problem:
flathub/org.gimp.GIMP@54d10d2

ibus from gnome runtime has 1.5.17 version. ibus-gtk2 from shared-modules has 1.5.20 version.
This creates incompatibility.
In order to fix that downgrade ibus-gtk2 from shared-modules (essentially revert latest commit from there).

old SDL?

Do we really need that ancient deprecated SDL 1.x still?
It's latest v1.2.15 version is 6 years old already, and several projects start dropping support of it:
http://hg.icculus.org/icculus/SDL_sound/rev/b0389c65334c

Auto bump the shared-modules for sensitive ones

Shared-modules contains some of the sensitive modules. So far, updating the module here with the latest security patches isn't enough as the apps have to update their shared-modules submodule and re-build the app with it.

We can setup a Github action that creates a merge request automatically for each app that uses it on Flathub. This will make it easier for app maintainers too :)

VLC interface way too big.

VLC interface way too big, icons and text resolution is low.

I have NVidia and Intel grahpics cards, on my laptop,
I have no this has anything to do with them.

org.freedesktop.Platform.GL.nvidia-390-48/x86_64/1.4
org.freedesktop.Platform.VAAPI.Intel/x86_64/1.6

I have installed other applications an they work fine.

gtk2-common-themes: Add Mint-y themes

Mint likely has enough of a user base to justify. Just opening an issue to remember this. Patches welcomed of course.

git-init can cause process to fail if gpg signing set to true as global option

In case of libcanberra, a git init is performed due to a necessary action of applying a patch. If git is configured globally to require gpg signing (commit.gpgsign true) then git init will fail expecting a certain key to be available and useable at that moment.

Investigate SDL12-compat in the future

There is a compat library implementing SDL 1's API with SDL 2: https://hg.libsdl.org/sdl12-compat

This will be a great quality of life improvement for many applications such as gaining Wayland support. https://www.youtube.com/watch?v=3uVmUCuJpF4

So we should look into replacing SDL 1 here.

[libappindicator] SVG icon not supported: GdkPixbuf.PixbufError

I'm getting this error when using libappindicator, compiled from shared modules:

libretrack, Impossible to read image info from path '/app/libretrack/data/icons/app-icon.svg': GdkPixbuf.PixbufError: Failed to recognize image format

when building with normal Ubuntu or Fedora dependencies (without using Flatpak) everything works perfectly and the indicator show SVG icon.

QT4 doesn't compile with runtime 19.08

https://flathub.org/builds/#/builders/35/builds/1216

gtk2 build error

gtk2 does not seem to build anymore.

https://flathub.org/builds/#/builders/32/builds/32060

[RFE] Add SDL2

SDL2 is not available in shared-modules. Please, consider adding it.

Add texlive module

I am wondering if there is any interest in adding a texlive module here?

We've created a working flatpak installation for TexLive 2018 for UberWriter (https://github.com/UberWriter/uberwriter/issues/46)

We think TexLive could be something that makes sense to be shared amongst other apps that want to use LaTeX (also, it's a rather big package).

LAME fails to build on top of freedesktop unstable

The upcoming freedesktop release will upgrade gcc to gcc8, LAME doesn't seem to build due to some error related to this. Updating lame did not fix the failure. Here is the part of the build log that seems relevant:

make[2]: Leaving directory '/run/build/lame/libmp3lame'
Making all in frontend
make[2]: Entering directory '/run/build/lame/frontend'
gcc -DHAVE_CONFIG_H  -I. -I.. -I../libmp3lame -I../include -I..  -O2 -D_FORTIFY_SOURCE=2  -O2 -g -fstack-protector-strong     -MT lame_main.o -MD -MP -MF .deps/lame_main.Tpo -c -o lame_main.o lame_main.c
gcc -DHAVE_CONFIG_H  -I. -I.. -I../libmp3lame -I../include -I..  -O2 -D_FORTIFY_SOURCE=2  -O2 -g -fstack-protector-strong     -MT main.o -MD -MP -MF .deps/main.Tpo -c -o main.o main.c
gcc -DHAVE_CONFIG_H  -I. -I.. -I../libmp3lame -I../include -I..  -O2 -D_FORTIFY_SOURCE=2  -O2 -g -fstack-protector-strong     -MT brhist.o -MD -MP -MF .deps/brhist.Tpo -c -o brhist.o brhist.c
gcc -DHAVE_CONFIG_H  -I. -I.. -I../libmp3lame -I../include -I..  -O2 -D_FORTIFY_SOURCE=2  -O2 -g -fstack-protector-strong     -MT console.o -MD -MP -MF .deps/console.Tpo -c -o console.o console.c
mv -f .deps/main.Tpo .deps/main.Po
gcc -DHAVE_CONFIG_H  -I. -I.. -I../libmp3lame -I../include -I..  -O2 -D_FORTIFY_SOURCE=2  -O2 -g -fstack-protector-strong     -MT get_audio.o -MD -MP -MF .deps/get_audio.Tpo -c -o get_audio.o get_audio.c
get_audio.c: In function ‘read_32_bits_high_low’:
get_audio.c:186:5: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result[-Wunused-result]
     fread(bytes, 1, 4, fp);
     ^~~~~~~~~~~~~~~~~~~~~~
get_audio.c: In function ‘read_16_bits_low_high’:
get_audio.c:147:5: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result[-Wunused-result]
     fread(bytes, 1, 2, fp);
     ^~~~~~~~~~~~~~~~~~~~~~
get_audio.c: In function ‘read_32_bits_low_high’:
get_audio.c:160:5: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result[-Wunused-result]
     fread(bytes, 1, 4, fp);
     ^~~~~~~~~~~~~~~~~~~~~~
get_audio.c: In function ‘read_16_bits_high_low’:
get_audio.c:174:5: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result[-Wunused-result]
     fread(bytes, 1, 2, fp);
     ^~~~~~~~~~~~~~~~~~~~~~
get_audio.c: In function ‘read_ieee_extended_high_low’:
get_audio.c:115:5: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result[-Wunused-result]
     fread(bytes, 1, 10, fp);
     ^~~~~~~~~~~~~~~~~~~~~~~
mv -f .deps/console.Tpo .deps/console.Po
gcc -DHAVE_CONFIG_H  -I. -I.. -I../libmp3lame -I../include -I..  -O2 -D_FORTIFY_SOURCE=2  -O2 -g -fstack-protector-strong     -MT lametime.o -MD -MP -MF .deps/lametime.Tpo -c -o lametime.o lametime.c
mv -f .deps/lametime.Tpo .deps/lametime.Po
gcc -DHAVE_CONFIG_H  -I. -I.. -I../libmp3lame -I../include -I..  -O2 -D_FORTIFY_SOURCE=2  -O2 -g -fstack-protector-strong     -MT parse.o -MD -MP -MF .deps/parse.Tpo -c -o parse.o parse.c
mv -f .deps/brhist.Tpo .deps/brhist.Po
gcc -DHAVE_CONFIG_H  -I. -I.. -I../libmp3lame -I../include -I..  -O2 -D_FORTIFY_SOURCE=2  -O2 -g -fstack-protector-strong     -MT timestatus.o -MD -MP -MF .deps/timestatus.Tpo -c -o timestatus.o timestatus.c
mv -f .deps/lame_main.Tpo .deps/lame_main.Po
mv -f .deps/timestatus.Tpo .deps/timestatus.Po
mv -f .deps/get_audio.Tpo .deps/get_audio.Po
mv -f .deps/parse.Tpo .deps/parse.Po
/bin/sh ../libtool  --tag=CC   --mode=link gcc  -O2 -g -fstack-protector-strong      -L/app/lib -fstack-protector-strong -Wl,-z,relro,-z,now  -static  -o lame lame_main.o main.o brhist.o console.o get_audio.o lametime.o parse.o timestatus.o ../libmp3lame/libmp3lame.la -lncurses   -lm
libtool: link: gcc -O2 -g -fstack-protector-strong -fstack-protector-strong -Wl,-z -Wl,relro -Wl,-z -Wl,now -o lame lame_main.o main.o brhist.o console.o get_audio.o lametime.o parse.o timestatus.o  -L/app/lib../libmp3lame/.libs/libmp3lame.so -lncurses -lm -Wl,-rpath -Wl,/run/build/lame/libmp3lame/.libs -Wl,-rpath -Wl,/app/lib
/usr/lib/gcc/aarch64-unknown-linux-gnu/8.2.0/../../../../aarch64-unknown-linux-gnu/bin/ld: console.o: undefined reference to symbol 'tgetent'
/usr/lib/gcc/aarch64-unknown-linux-gnu/8.2.0/../../../../aarch64-unknown-linux-gnu/bin/ld: /usr/lib/aarch64-linux-gnu/libtinfo.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:469: lame] Error 1
make[2]: Leaving directory '/run/build/lame/frontend'
make[1]: *** [Makefile:452: all-recursive] Error 1
make[1]: Leaving directory '/run/build/lame'
make: *** [Makefile:381: all] Error 2
Error: module lame: Child process exited with code 2

For context, this was collected while attempting to build audacity against freedesktop unstable.

lame-3.100 is available

Refer to https://sourceforge.net/projects/lame/files/lame/

Deprecate lame in favour of org.freedesktop.Platform.GStreamer.mp3?

Hi there,

org.freedesktop.Platform.GStreamer.mp3 provides a mp3 encode/decoder and it's mantained by freedesktop. So is there any special need to share lame via the shared-modules?

Regards

linux-audio/ladspa.json: ladspa.org is not available

The domain ladspa.org is unavailable as of today. I don't know what happened, but here is whois output:

whois ladspa.org
[Querying whois.pir.org]
[whois.pir.org]
Domain Name: LADSPA.ORG
Registry Domain ID: D27160578-LROR
Registrar WHOIS Server: whois.ionos.com
Registrar URL: https://registrar.ionos.info/
Updated Date: 2022-03-08T02:45:30Z
Creation Date: 2000-05-16T10:35:52Z
Registry Expiry Date: 2023-05-16T10:35:52Z
Registrar Registration Expiration Date:
Registrar: 1&1 IONOS SE
Registrar IANA ID: 83
Registrar Abuse Contact Email: [email protected]
Registrar Abuse Contact Phone: [phone]
Reseller:
Domain Status: clientTransferProhibited https://icann.org/epp#clientTransferProhibited
Domain Status: serverTransferProhibited https://icann.org/epp#serverTransferProhibited
Domain Status: transferPeriod https://icann.org/epp#transferPeriod
Registrant Organization:
Registrant State/Province: LND
Registrant Country: GB
Name Server: NS1105.UI-DNS.COM
Name Server: NS1065.UI-DNS.BIZ
Name Server: NS1117.UI-DNS.DE
Name Server: NS1087.UI-DNS.ORG
DNSSEC: unsigned
URL of the ICANN Whois Inaccuracy Complaint Form https://www.icann.org/wicf/)
>>> Last update of WHOIS database: 2022-03-08T10:59:29Z <<<

For more information on Whois status codes, please visit https://icann.org/epp
...

This leads to build failures as we cannot access the LADSPA SDK:

Downloading http://www.ladspa.org/download/ladspa_sdk_1.15.tgz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0Failed to download sources: module ladspa: Could not resolve host: www.ladspa.org

qt4 module does not build with org.freedesktop.Sdk 18.08

The current revision of the runtime:
org.freedesktop.Sdk/x86_64/18.08 flathub 597122efa9e3

It should be easy to reproduce.

udev: Missing definition of exec_prefix in pkgconfig

During bluez' configure phase, the following error occurs:

checking for UDEV... yes
checking for udev_hwdb_new in -ludev... no
checking udev directory... Variable 'exec_prefix' not defined in '/app/share/pkgconfig/udev.pc'
configure: error: udev directory is required
Error: module bluez: Child process exited with code 1

Lame doesn’t build on fd.o 18.08

https://flathub.org/builds/#/builders/2/builds/4877

Update intltool

https://flathub.org/builds/#/builders/32/builds/10345

udev broke again

Fails to build again

/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: udev/udevd.o: in function `static_dev_create_from_modules':
/run/build/udev/udev/udevd.c:898: undefined reference to `makedev'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: udev/udevd.o: in function `is_devpath_busy':
/run/build/udev/udev/udevd.c:517: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udevd.c:540: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: udev/udev-event.o: in function `udev_event_apply_format':
/run/build/udev/udev/udev-event.c:233: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-event.c:241: undefined reference to `minor'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-event.c:357: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-event.c:374: undefined reference to `minor'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-event.c:374: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-event.c:385: undefined reference to `minor'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-event.c:385: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: udev/udev-event.o: in function `udev_event_execute_rules':
/run/build/udev/udev/udev-event.c:931: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-event.c:936: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-event.c:945: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-event.c:977: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: udev/udev-node.o: in function `udev_node_mknod':
/run/build/udev/udev/udev-node.c:99: undefined reference to `minor'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-node.c:99: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-node.c:111: undefined reference to `minor'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-node.c:111: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-node.c:84: undefined reference to `minor'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-node.c:84: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: udev/udev-node.o: in function `udev_node_add':
/run/build/udev/udev/udev-node.c:372: undefined reference to `minor'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-node.c:372: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-node.c:383: undefined reference to `minor'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-node.c:383: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: udev/udev-node.o: in function `udev_node_remove':
/run/build/udev/udev/udev-node.c:448: undefined reference to `minor'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-node.c:448: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: udev/udev-rules.o: in function `udev_rules_apply_to_event':
/run/build/udev/udev/udev-rules.c:2587: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/udev/udev-rules.c:2056: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: libudev/.libs/libudev-private.a(libudev-device.o): in function `udev_device_add_property_from_string_parse_finish':
/run/build/udev/libudev/libudev-device.c:468: undefined reference to `makedev'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: libudev/.libs/libudev-private.a(libudev-device.o): in function `udev_device_set_devnum':
/run/build/udev/libudev/libudev-device.c:158: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/libudev/libudev-device.c:160: undefined reference to `minor'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: libudev/.libs/libudev-private.a(libudev-device.o): in function `udev_device_read_uevent_file':
/run/build/udev/libudev/libudev-device.c:610: undefined reference to `makedev'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: libudev/.libs/libudev-private.a(libudev-device.o): in function `udev_device_get_devnum':
/run/build/udev/libudev/libudev-device.c:146: undefined reference to `makedev'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: libudev/.libs/libudev-private.a(libudev-device.o): in function `udev_device_get_id_filename':
/run/build/udev/libudev/libudev-device.c:1570: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/libudev/libudev-device.c:1572: undefined reference to `minor'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/libudev/libudev-device.c:1572: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: libudev/.libs/libudev-private.a(libudev-device.o): in function `udev_device_new_from_devnum':
/run/build/udev/libudev/libudev-device.c:752: undefined reference to `minor'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /run/build/udev/libudev/libudev-device.c:752: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: libudev/.libs/libudev-private.a(libudev-device.o): in function `udev_device_new_from_id_filename':
/run/build/udev/libudev/libudev-device.c:769: undefined reference to `makedev'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: libudev/.libs/libudev-private.a(libudev-enumerate.o): in function `scan_dir_and_add_devices':
/run/build/udev/libudev/libudev-enumerate.c:672: undefined reference to `major'
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: libudev/.libs/libudev-private.a(libudev-device-private.o): in function `udev_device_update_db':
/run/build/udev/libudev/libudev-device-private.c:122: undefined reference to `major'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:1955: udev/udevd] Error 1
make[2]: *** Waiting for unfinished jobs....
/usr/lib/gcc/x86_64-unknown-linux-gnu/8.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: extras/cdrom_id/cdrom_id.o: in function `is_mounted':
/run/build/udev/extras/cdrom_id/cdrom_id.c:132: undefined reference to `makedev'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:1756: extras/cdrom_id/cdrom_id] Error 1
make[1]: *** [Makefile:2624: all-recursive] Error 1
make: *** [Makefile:1445: all] Error 2

GLU does not build?

I'm trying to update the package net.pioneerspacesim.Pioneer. The build fails when trying to build GLU. Here's the build log:
https://flathub.org/builds/#/builders/10/builds/1719

udev build fails with freedesktop 18.08

The udev shared-module fails to build with org.freedesktop.Platform 18.08
Works with org.freedesktop.Platform 1.6 (also works with kde and gnome)
Flatpak version 1.2.3
Flatpak-builder version 1.05
This also affects the build bot.

/usr/bin/install: cannot create regular file '/usr/lib/systemd/system/udev-control.socket': Read-only file system /usr/bin/install: cannot create regular file '/usr/lib/systemd/system/udev-kernel.socket': Read-only file system /usr/bin/install: cannot create regular file '/usr/lib/systemd/system/udev.service': Read-only file system /usr/bin/install: cannot create regular file '/usr/lib/systemd/system/udev-trigger.service': Read-only file system /usr/bin/install: cannot create regular file '/usr/lib/systemd/system/udev-settle.service': Read-only file system make[3]: *** [Makefile:2534: install-systemdsystemunitDATA] Error 1 make[2]: *** [Makefile:3109: install-am] Error 2 make[1]: *** [Makefile:2624: install-recursive] Error 1 make: *** [Makefile:3103: install] Error 2

A simple test project:
a.test.project.yaml.txt

gtk2: gnome-themes-extra fails to build with FD.o 19.08beta

The gnome-themes-extra fails to find intltool-update and thus doesn't build with the new FD.o 19.08 runtime.

Builder log:

========================================================================
Building module gnome-themes-extra in /srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/build/gnome-themes-extra-1
========================================================================
�]2;flatpak-builder: Building gnome-themes-extra�FB: Running: tar xf /srv/buildbot/worker/downloads/downloads/7c4ba0bff001f06d8983cfc105adaac42df1d1267a2591798a780bac557a5819/gnome-themes-extra-3.28.tar.xz --no-same-owner --strip-components=1 -J
FB: Running: flatpak build --die-with-parent --nofilesystem=host --filesystem=/srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/build/gnome-themes-extra-1 --env=SOURCE_DATE_EPOCH=1562238821 '--env=CFLAGS=-O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' '--env=CXXFLAGS=-O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' '--env=LDFLAGS=-L/app/lib -Wl,-z,relro,-z,now -Wl,--as-needed' --env=CCACHE_DIR=/run/ccache/disabled --env=PATH=/app/bin:/usr/bin --env=LD_LIBRARY_PATH=/app/lib --env=PKG_CONFIG_PATH=/app/lib/pkgconfig:/app/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig --unshare=network /srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/rofiles/rofiles-Wvm4ji /bin/sh -c 'sed -i '\''s/icons//'\'' themes/HighContrast/Makefile.am'
FB: Running: flatpak build --die-with-parent --env=FLATPAK_BUILDER_BUILDDIR=/run/build/gnome-themes-extra --nofilesystem=host --filesystem=/srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/build/gnome-themes-extra-1 --bind-mount=/run/build/gnome-themes-extra=/srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/build/gnome-themes-extra-1 --build-dir=/run/build/gnome-themes-extra --bind-mount=/run/ccache=/srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/ccache --unshare=network --env=SOURCE_DATE_EPOCH=1562238821 '--env=CFLAGS=-O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' '--env=CXXFLAGS=-O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' '--env=LDFLAGS=-L/app/lib -Wl,-z,relro,-z,now -Wl,--as-needed' --env=CCACHE_DIR=/run/ccache/disabled --env=PATH=/app/bin:/usr/bin --env=LD_LIBRARY_PATH=/app/lib --env=PKG_CONFIG_PATH=/app/lib/pkgconfig:/app/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig --env=FLATPAK_BUILDER_N_JOBS=48 --env=NOCONFIGURE=1 /srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/rofiles/rofiles-Wvm4ji ./autogen.sh
libtoolize: putting auxiliary files in '.'.
libtoolize: linking file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: linking file 'm4/libtool.m4'
libtoolize: linking file 'm4/ltoptions.m4'
libtoolize: linking file 'm4/ltsugar.m4'
libtoolize: linking file 'm4/ltversion.m4'
libtoolize: linking file 'm4/lt~obsolete.m4'
configure.ac:20: installing './compile'
configure.ac:9: installing './missing'
themes/Adwaita/gtk-2.0/Makefile.am: installing './depcomp'
FB: Running: flatpak build --die-with-parent --env=FLATPAK_BUILDER_BUILDDIR=/run/build/gnome-themes-extra --nofilesystem=host --filesystem=/srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/build/gnome-themes-extra-1 --bind-mount=/run/build/gnome-themes-extra=/srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/build/gnome-themes-extra-1 --build-dir=/run/build/gnome-themes-extra --bind-mount=/run/ccache=/srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/ccache --unshare=network --env=SOURCE_DATE_EPOCH=1562238821 '--env=CFLAGS=-O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' '--env=CXXFLAGS=-O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' '--env=LDFLAGS=-L/app/lib -Wl,-z,relro,-z,now -Wl,--as-needed' --env=CCACHE_DIR=/run/ccache/disabled --env=PATH=/app/bin:/usr/bin --env=LD_LIBRARY_PATH=/app/lib --env=PKG_CONFIG_PATH=/app/lib/pkgconfig:/app/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig --env=FLATPAK_BUILDER_N_JOBS=48 /srv/buildbot/worker/build-x86_64-7/build/.flatpak-builder/rofiles/rofiles-Wvm4ji ./configure --prefix=/app --disable-dependency-tracking --disable-gtk3-engine
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
...
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking whether NLS is requested... yes
./configure: line 9904: intltool-update: command not found
checking for intltool >= 0.40.0...  found
configure: error: Your intltool is too old.  You need intltool 0.40.0 or later.
�]2;flatpak-builder: Cleanup gnome-themes-extra�Error: module gnome-themes-extra: Child process exited with code 1

Add Qt5 and PyQt5

This is used in a vast number of packages. Would be a lot easier to maintain it only once.

org.freedesktop.Sdk.Extension.shared-modules ?

Maybe I'm missing something, but wouldn't it make sense to turn shared-modules into a SDK extension?

This would bring us:

1. shorter compile times
2. not having to mess with git modules (annoying with Github's web GUI)

udev having problems building

udev doesn't build using flatpak-builder 1.0.0 on aarch64, against freedesktop-sdk 18.08. It seems to try to strip binaries in .flatpak-builder/, but I'm unfamiliar with how flatpak-builder works, so I'm unsure if this behaviour is expected or not.

Relevant build log:

compressing debuginfo in: /home/nvidia/net.sourceforge.ExtremeTuxRacer/.flatpak-builder/rofiles/rofiles-cwr7Kt/files/libexec/udevd
Warning: eu-elfcompress not installed, will not compress debuginfo
stripping /home/nvidia/net.sourceforge.ExtremeTuxRacer/.flatpak-builder/rofiles/rofiles-cwr7Kt/files/libexec/udevd to /home/nvidia/net.sourceforge.ExtremeTuxRacer/.flatpak-builder/rofiles/rofiles-cwr7Kt/files/lib/debug/libexec/udevd.debug
Error: module udev: Failed to execute child process "eu-strip" (No such file or directory)

Python 2 and Gtk+2: PyGtk

In another pull request, I've included a file that combines the shared-modules/gtk2 module with the shared-modules/python2 module:

flathub/flathub#2121

The file pk2gtk2.json builds pygtk which is needed for many old UI applications who rely on both Python 2 and Gtk+2. Since both of these technologies are deprecated and multiple distributions have been busy removing their libraries, I think it would be a good addition to Flathub to have a shared-module to support these older applications in a limited, containerized fashion.

Add clutter and clutter-gtk

Clutter and clutter-gtk are deprecated and are not going to be part of the GNOME 42 runtimes and some apps still rely on it, it could be a good idea to have it here as a low maintenance module.

For reference, this is how it looks on one of my projects.

        {
            "name": "cogl",
            "config-opts": [
                "--disable-cogl-gst",
                "--enable-xlib-egl-platform",
                "--enable-wayland-egl-platform"
            ],
            "sources": [
                {
                    "type": "git",
                    "url": "https://gitlab.gnome.org/GNOME/cogl.git",
                    "branch": "cogl-1.22"
                }
            ]
        },
        {
            "name": "mtdev",
            "buildsystem": "autotools",
            "sources": [
                {
                    "type": "git",
                    "url": "https://github.com/rydberg/mtdev.git"
                }
            ]
        },
        {
            "name": "libinput",
            "buildsystem": "meson",
            "config-opts": [
                "-Dlibwacom=false",
                "-Dtests=false",
                "-Ddocumentation=false"
            ],
            "sources": [
                {
                    "type": "git",
                    "url": "https://gitlab.freedesktop.org/libinput/libinput.git"
                }
            ]
        },
        {
            "name": "clutter",
            "buildsystem": "meson",
            "config-opts": [
                "-Ddocumentation=false",
                "-Dbackends=x11,wayland"
            ],
            "sources": [
                {
                    "type": "git",
                    "url": "https://gitlab.gnome.org/GNOME/clutter.git"
                }
            ]
        },
        {
            "name": "clutter-gtk",
            "buildsystem": "autotools",
            "sources": [
                {
                    "type": "git",
                    "url": "https://gitlab.gnome.org/GNOME/clutter-gtk.git"
                }
            ]
        },

See https://gitlab.gnome.org/GNOME/gnome-nibbles/-/merge_requests/31.

[QUESTION] Why didn't shared-modules merge modules from casept/flatpak-modules?

1. Is there any difference between shared-modules and casept/flatpak-modules.
2. Why didn't shared-modules merge modules from casept/flatpak-modules?
3. Is the goal of shared-modules to keep every modern library that's not included in freedesktop.Platform if not then why?

SDL_mixer module cannot be compiled

I am getting this error when trying to use the SDL_mixer-1.2.12.json module:

./configure: line 13698: syntax error near unexpected token `$SMPEG_VERSION,'
./configure: line 13698: `    AM_PATH_SMPEG($SMPEG_VERSION, have_smpeg=yes, have_smpeg=no)'

Add wine

Wine would be a super useful shared module to have. Since winepak is either dead or on hiatus, it would be nice for Flathub to officially support it.

What are your thoughts?

Add TCL as shared library

I just tried to re-work the TCL module in the Element flatpak using flathub/im.riot.Riot#187

Since I remember that originally the TCL module was just copied from some other sqlcipher user, I though it might be worth to check whether one wants to create it as a shared library:

https://github.com/flathub/edu.stanford.Almond/blob/96a338a6196673e8e34093cf5d7dcb3e39d64b3c/edu.stanford.Almond.json#L219-L234
https://github.com/flathub/cc.retroshare.retroshare-gui/blob/f04704b9677b815b546ea4edef349c7e1b4a8785/cc.retroshare.retroshare-gui.yaml#L31-L41
https://github.com/flathub/org.openmsx.openMSX/blob/d550ba3e2088c3141025ff5f285c7fa4774f9040/org.openmsx.openMSX.yaml#L31-L42
https://github.com/flathub/org.kde.skrooge/blob/7ae18045b2aca325517cf2bf23ec6694e1be250e/org.kde.skrooge.json#L31-L48
https://github.com/flathub/io.github.qtox.qTox/blob/132b9dd57c95b04602c4893042462d94284c6ac8/io.github.qtox.qTox.json#L42-L56
https://github.com/flathub/com.gitlab.guillermop.MasterKey/blob/33603d9836dcaae008e920026bdecf2001b3597e/com.gitlab.guillermop.MasterKey.json#L25-L45
https://github.com/flathub/im.riot.Riot/blob/644f94ae656ef25518a7d48cf9b78210b7d009f9/im.riot.Riot.yaml#L54-L63

Given the amount of applications that use TCL at least as part of their built process, I think we could consider unify the efforts, as it's also not updated in any meaningful way in most of those applications.

cannot run fluidsynth

I'm trying to use the pygame module, which contains fluidsynth.
When I build my app flatpak, fluidsynth binary can't find the shared library libfluidsynth.so. Within the container:

[📦 org.frescobaldi.Frescobaldi frescobaldi]$ fluidsynth --version
fluidsynth: error while loading shared libraries: libfluidsynth.so.1: cannot open shared object file: No such file or directory

[📦 org.frescobaldi.Frescobaldi frescobaldi]$ ldd /app/bin/fluidsynth 
	linux-vdso.so.1 (0x00007ffe64ded000)
	libfluidsynth.so.1 => not found
	libc.so.6 => /usr/lib/x86_64-linux-gnu/libc.so.6 (0x00007fdb3c9ff000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fdb3cbe2000)

[📦 org.frescobaldi.Frescobaldi frescobaldi]$ ls -l  /app/lib64/
totale 432
lrwxrwxrwx 1 fede fede     18  9 ott 01.54 libfluidsynth.so -> libfluidsynth.so.1
lrwxrwxrwx 1 fede fede     22  9 ott 01.54 libfluidsynth.so.1 -> libfluidsynth.so.1.5.2
-rwxr-xr-x 4 fede fede 435976  1 gen  1970 libfluidsynth.so.1.5.2
drwxr-xr-x 2 fede fede   4096  1 gen  1970 pkgconfig

clutter: Disable gtk-doc generation

I built a test app that just builds shared-modules/clutter/clutter.json. It's 22 MB of which 8 MB is API documentation.

$ (cd `flatpak info -l app/uk.me.wjt.Test/x86_64/master`; ( du -h --max-depth=2 files | sort -h | tail -n5 ))
3.3M	files/lib
6.4M	files/share/gir-1.0
8.1M	files/share/gtk-doc
15M	files/share
21M	files

I tried writing the obvious patch but it had no effect.

commit 0ada6db8c75ee0193f3d937e01e297efee84df1a (HEAD -> clutter-cleanup)
Author: Will Thompson <[email protected]>
Date:   Mon Jun 13 14:46:46 2022 +0100

    clutter: Disable gtk-doc in all modules
    
    This makes for a faster build and smaller apps.

diff --git a/clutter/clutter.json b/clutter/clutter.json
index cb6baaa..4a964f8 100644
--- a/clutter/clutter.json
+++ b/clutter/clutter.json
@@ -12,6 +12,7 @@
             "name": "cogl",
             "config-opts": [
                 "--disable-cogl-gst",
+                "--disable-gtk-doc",
                 "--enable-xlib-egl-platform",
                 "--enable-wayland-egl-platform"
             ],
@@ -26,6 +27,7 @@
         {
             "name": "clutter",
             "config-opts": [
+                "--disable-gtk-doc",
                 "--enable-egl-backend",
                 "--enable-wayland-backend"
             ],
@@ -39,6 +41,9 @@
         },
         {
             "name": "clutter-gst",
+            "config-opts": [
+                "--disable-gtk-doc"
+            ],
             "sources": [
                 {
                     "type": "archive",

So I have given up.

Set up code owners for modules

For details on what code owners is:

• https://github.blog/2017-07-06-introducing-code-owners/
• https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

As shared-modules grows and gets more security sensitive modules we should have maintainers for each module so there is somebody taking responsibility for what is here rather than it becoming a dumping ground.

(Brought up because of #84)

Proposal for maintainers (need volunteers):

• SDL
• cld2
• dbus-glib (@TingPing)
• glew
• glu
• gtk2 (@TingPing)
• gudev (@Erick555)
• intltool (@TingPing)
• lame
• libappindicator (@TingPing)
• libmad
• libsecret (@Lctrs)
• lua
• python (@bilelmoussaoui)
• pygame
• qt4
• smpeg
• openjpeg (@bochecha)

Then in the future all new modules will require an owner to be added.

dbus-glib download hangs

[...]
Downloading https://dbus.freedesktop.org/releases/dbus-glib/dbus-glib-0.110.tar.gz
  0     0    0     0    0     0      0      0 --:--:--  0:00:59 --:--:--     0
Failed to download sources: module dbus-glib: Connection timed out after 60000 milliseconds
$ wget https://dbus.freedesktop.org/releases/dbus-glib/dbus-glib-0.110.tar.gz
--2019-08-02 11:47:07--  https://dbus.freedesktop.org/releases/dbus-glib/dbus-glib-0.110.tar.gz
Resolving dbus.freedesktop.org (dbus.freedesktop.org)... 131.252.210.176, 2610:10:20:722:a800:ff:feda:470f
Connecting to dbus.freedesktop.org (dbus.freedesktop.org)|131.252.210.176|:443... ^C

This already happened in the recent past with GStreamer downloads. The best course of action would be to replace the tarball download with a pinned git checkout:

diff --git a/flatpak/org.gnome.Totem.json b/flatpak/org.gnome.Totem.json
index cbc2a4ebd..bf4a2a43f 100644
--- a/flatpak/org.gnome.Totem.json
+++ b/flatpak/org.gnome.Totem.json
@@ -280,9 +280,10 @@
             ],
             "sources": [
                 {
-                    "type": "archive",
-                    "url": "https://dbus.freedesktop.org/releases/dbus-glib/dbus-glib-0.110.tar.gz",
-                    "sha256": "7ce4760cf66c69148f6bd6c92feaabb8812dee30846b24cd0f7395c436d7e825"
+                    "type": "git",
+                    "url": "https://gitlab.freedesktop.org/dbus/dbus-glib.git",
+                    "tag": "dbus-glib-0.110",
+                    "commit": "ffeb6909967ff79585a7ede85227da94f04ecb01"
                 }
             ]
         },

Qt4 is kind of broken on x86_64: unable to load Qt4 plug-ins

The Qt4 shared module is kind of broken on x86_64. This may apply to aarch64 as well.
Because of this, any Qt4-based application is unable to load Qt4 plug-ins, especially libq*.so (libqgif.so, libqico.so, libqjpeg.so, libqmng.so, libqsvg.so, libqtga.so, libqtiff.so).
I believe that this problem is related to the QT_BUILD_KEY/QT_BUILD_KEY_COMPAT value.

Steps to reproduce:
1. Get the flatpak package for XnRetro v1.01: https://github.com/scx/xnretro-flatpak/tree/v1.01

git checkout -b v1.01 https://github.com/scx/xnretro-flatpak.git

2. Remove these lines from the qt.yaml file:

skip-arches:
  - aarch64
  - x86_64

3. Build flatpak package on x86_64 host:

flatpak-builder "build" "com.xnview.XnRetro.yaml" --force-clean --install-deps-from="flathub"

4. Run flatpak shell:

flatpak-builder --run "build" "com.xnview.XnRetro.yaml" "sh"

4a. Enable debug messages:

export QT_DEBUG_PLUGINS=1 
export QML_IMPORT_TRACE=1

4b. Run the app:

xnretro

4c. Open a file:

File → Open

You should get something like this:

QFactoryLoader::QFactoryLoader() looking at "/app/XnRetro/lib/imageformats/libqgif.so" 
In /app/lib/qt4/plugins/imageformats/libqgif.so:
  Plugin uses incompatible Qt library
  expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"
"The plugin '/app/lib/qt4/plugins/imageformats/libqgif.so' uses incompatible Qt library. Expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"" 
         not a plugin 
QFactoryLoader::QFactoryLoader() looking at "/app/XnRetro/lib/imageformats/libqico.so" 
In /app/lib/qt4/plugins/imageformats/libqico.so:
  Plugin uses incompatible Qt library
  expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"
"The plugin '/app/lib/qt4/plugins/imageformats/libqico.so' uses incompatible Qt library. Expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"" 
         not a plugin 
QFactoryLoader::QFactoryLoader() looking at "/app/XnRetro/lib/imageformats/libqjpeg.so" 
In /app/lib/qt4/plugins/imageformats/libqjpeg.so:
  Plugin uses incompatible Qt library
  expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"
"The plugin '/app/lib/qt4/plugins/imageformats/libqjpeg.so' uses incompatible Qt library. Expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"" 
         not a plugin 
QFactoryLoader::QFactoryLoader() looking at "/app/XnRetro/lib/imageformats/libqmng.so" 
In /app/lib/qt4/plugins/imageformats/libqmng.so:
  Plugin uses incompatible Qt library
  expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"
"The plugin '/app/lib/qt4/plugins/imageformats/libqmng.so' uses incompatible Qt library. Expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"" 
         not a plugin 
QFactoryLoader::QFactoryLoader() looking at "/app/XnRetro/lib/imageformats/libqsvg.so" 
In /app/lib/qt4/plugins/imageformats/libqsvg.so:
  Plugin uses incompatible Qt library
  expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"
"The plugin '/app/lib/qt4/plugins/imageformats/libqsvg.so' uses incompatible Qt library. Expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"" 
         not a plugin 
QFactoryLoader::QFactoryLoader() looking at "/app/XnRetro/lib/imageformats/libqtga.so" 
In /app/lib/qt4/plugins/imageformats/libqtga.so:
  Plugin uses incompatible Qt library
  expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"
"The plugin '/app/lib/qt4/plugins/imageformats/libqtga.so' uses incompatible Qt library. Expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"" 
         not a plugin 
QFactoryLoader::QFactoryLoader() looking at "/app/XnRetro/lib/imageformats/libqtiff.so" 
In /app/lib/qt4/plugins/imageformats/libqtiff.so:
  Plugin uses incompatible Qt library
  expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"
"The plugin '/app/lib/qt4/plugins/imageformats/libqtiff.so' uses incompatible Qt library. Expected build key "x86_64 linux g++-8.2.0 full-config", got "i386 linux g++-8.2.0 full-config"" 
         not a plugin 

It seems that this is an old Qt4 issue.
https://bugreports.qt.io/browse/QTBUG-33102

Build problem & won't fix for Qt 4. It's been like that since 2005, when Qt 4.0 was released.
When compiling Qt 4 on a 64-bit system, you should always run:
i386 configure -platform linux-g++-32
This is fixed in Qt 5 by a complete rewrite of the Qt arch-specific code.

We have almost the same problem, just the opposite.

So far, I have tried this:

        "arch": {
            "arm": {
                 "config-opts": [
                     "-platform", "linux-g++-32"
                 ]
             },
            "aarch64": {
                 "config-opts": [
                     "-platform", "linux-g++-64"
                 ]
             },
            "i386": {
                 "config-opts": [
                     "-platform", "linux-g++-32"
                 ]
             },
            "x86_64": {
                 "config-opts": [
                     "-platform", "linux-g++-64"
                 ]
             }
        },

as well as this:

        "arch": {
            "aarch64": {
                 "config-opts": [
                     "-platform", "linux-g++"
                 ]
             },
            "x86_64": {
                 "config-opts": [
                     "-platform", "linux-g++"
                 ]
             }
        },

and this:

        "arch": {
            "x86_64": {
                 "config-opts": [
                     "-arch", "x86_64"
                 ]
             }
        },

Unfortunately, none of them solved the problem.
I stopped trying because I actually need Qt4 only for i386 builds.

Add gtk3, gtk4

Wrong checksum for lua 5.4.4

Using the lua5.4 module results in the following error message for me:

Failed to download sources: module lua-5.4: Wrong sha256 checksum for lua-5.4.4.tar.gz, expected "2ff89bbea22a7c8b910d6b006f5ba4559edcf468a25537cedf9988ed90f6b450", was "164c7849653b80ae67bec4b7473b884bf5cc8d2dca05653475ec2ed27b9ebf61"

Indeed, when I manually download https://www.lua.org/ftp/lua-5.4.4.tar.gz I get the checksums

digest	result
md5	bd8ce7069ff99a400efd14cf339a727b
sha1	03c27684b9d5d9783fb79a7c836ba1cdc5f309cd
sha256	164c7849653b80ae67bec4b7473b884bf5cc8d2dca05653475ec2ed27b9ebf61

The first two match the published ones at https://www.lua.org/download.html

Glew out of date (2.2.0 available)

Version 2.2.0 available (created 2020-03-16). Currently in manifest used 2.1.0 version which was created 2017-07-31.
It might be worth it to upgrade?