GithubHelp home page GithubHelp logo

Comments (4)

FlorianRappl avatar FlorianRappl commented on May 27, 2024 1

I am all in favor of supporting both object- and array-style externals. But I find the custom syntax with '=>' to map a value to something else a bit unnecessary, as we already have objects to map a value to another.

True but we require a string representation for handing that over internally. This string representation is the direct consequence. In my opinion its fairly straight forward to understand.

I agree with the clarity of the object representation though. It's a good call 🍻!

from parcel-plugin-externals.

FlorianRappl avatar FlorianRappl commented on May 27, 2024

I think we can go for both.

I introduced this syntax to make it optional, e.g., using

{
  "externals": [
    "react"
  ]
}

is valid, too. This could be interesting if React is / should not be a peer dependency, but desired as an external (but with the default fallback to require('react').

I would introduce the alternative with an object which will be converted respectively (${key} => ${value}).

How does that sound?

cc @subhero24

from parcel-plugin-externals.

subhero24 avatar subhero24 commented on May 27, 2024

I am all in favor of supporting both object- and array-style externals. But I find the custom syntax with '=>' to map a value to something else a bit unnecessary, as we already have objects to map a value to another.

from parcel-plugin-externals.

FlorianRappl avatar FlorianRappl commented on May 27, 2024

I published a preview version. Let me know if it works as expected / any other things to improve.

https://www.npmjs.com/package/parcel-plugin-externals/v/0.2.0-pre.20191021.1

cc @subhero24

from parcel-plugin-externals.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.