flow-launcher / flow.launcher.pluginsmanifest Goto Github PK

The python-passed workflow is failing because it uses GitHub's bot account to commit changes. However it does not have write access to the repo.

@jjw24

As our thought #59, it happened to Timestamp.

https://github.com/Flow-Launcher/Flow.Launcher.PluginsManifest/runs/3096655566?check_suite_focus=true#step:5:36

 95%|█████████▌| 20/21 [00:03<00:00,  5.34it/s]Traceback (most recent call last):
  File "/home/runner/work/Flow.Launcher.PluginsManifest/Flow.Launcher.PluginsManifest/./ci/src/updater.py", line 55, in <module>
    plugin_infos_new = batch_plugin_infos(plugin_infos)
  File "/home/runner/work/Flow.Launcher.PluginsManifest/Flow.Launcher.PluginsManifest/./ci/src/updater.py", line 50, in batch_plugin_infos
    return [batch_github_plugin_info(info) for info in tqdm(plugin_infos)]
  File "/home/runner/work/Flow.Launcher.PluginsManifest/Flow.Launcher.PluginsManifest/./ci/src/updater.py", line 50, in <listcomp>
    return [batch_github_plugin_info(info) for info in tqdm(plugin_infos)]
  File "/home/runner/work/Flow.Launcher.PluginsManifest/Flow.Launcher.PluginsManifest/./ci/src/updater.py", line 40, in batch_github_plugin_info
    assets = latest_rel["assets"]
KeyError: 'assets'

id needs to be unique as is used for matching existing plugin to download/update. Since this info is manually added into plugin.json, let's enforce it with auto checker here.

Need to also take into consideration of default flow launcher plugins' ids as well.

Hey @jjw24 found a bug in the notion search plugin. It was difficult to test the plugin in dev because it can't call the main FlowLauncher class. I ended up doing testing by editing the code in the app's plugin folder.

I pushed the fix and v0.1.5 is the last release. But the manifest still says 0.1.4. Is there anything else I need to do?

https://github.com/danielduckworth/Flow.Launcher.Plugin.NotionSearch

Thanks,
Daniel.

Release v2.2.0 for Toggl Track has been skipped by the auto-updater for some reason---I wonder if this is because the release workflow was running at precisely the same time as the auto-update ci?

The release tag was first created at 21:07, at the same time as the auto-update commit

But the release .zip wasn't added by the release workflow until 21:09

I haven't had a chance to look into the update script code, but perhaps some internal flag has set v2.2.0 as 'seen', but the actual update errored as it couldn't find the release file?
Meaning subsequent releases might see it as already released and ignore?

If the release notes are too long, the embed field value will be longer than Discord's 1024 limit, and the webhook will fail to fire.

My plugin is recently updated, and i see it is updated in plugins.json, but not in the Plugin Store. How long does it take to update the plugin in the plugin store as well?

Update check to fail on attributes that are not needed in the plugins.json file

as a developer, It will be very good to know how many people install my plugins, so can you add it plugin store under the plugin name and description?

I think we can follow the way Updater.cs checking the newest update for Flow to automatically get the newest update for plugins instead of storing the direct download link in plugin.json.
This can avoid updating pluginsmanifest every time plugins update. Or checking the update is also part of the review process?

my steps:

1. clone of repo
2. create a local branch
3. update the plugins.json file
4. push local branch to remote => Failed!!! => no permission.

How are the steps to update the plugins.json file with my plugin?

Both are useful for me. But I still use Wox more often.Thank you very much.

I am able to uninstall standard plugins(calculator, bookmarks,...) but not to install them again.

Plugin autoupdater has been paused to troubleshoot an issue causing the manifest file to break, resulting in Plugin Store not displaying anything.

For the time being, feel free to submit a pull request to update the plugin version manually.

Relates to Flow-Launcher/Flow.Launcher#2307

Should we use more keywords?

The following contents are plugin.json.

{
  "ID": "D2D2C23B084D411DB66FE0C79D6C2A6E",
  "ActionKeyword": "*",
  "Name": "Everything",
  "Description": "Search Everything",
  "Author": "qianlifeng,orzfly",
  "Version": "1.1.2",
  "Language": "csharp",
  "Website": "https://github.com/Flow-Launcher/Flow.Launcher",
  "IcoPath": "Images\\find.png",
  "ExecuteFileName": "Flow.Launcher.Plugin.Everything.dll",
  "Disabled": false
}

name, version, and url keywords are too few.

I think some other keywords need for that.

• ID: It can be clear different plugins. It is necessary.
• Description: It also needs.
• Author: It would need.
• website: It is the plugin homepage link. It is necessary. I think it needs to change to another name called homepage or else.
• url: I think this should change another name. It is called downloadURL. So it can distinguish website.
• name & version just keep.

We could build an online plugin service via this file.

And we should write a guide on how to make a standard to build flow plugin.

I make update for my AudFlow plugin to make it small, faster and some users face problems with the last open and it will work great now
when i publish the v2.0.0 there are this problem

It appear because a problem with library i change to , It should install manually , I add every thing in Lib folder , can you accept the update ?

We can add IcoPath to the plugin manifest since we almost require a plugin to have their icon. It can be a cdn link or direct link to the icon published in github.

Closed to #57.

is there a way to set it so the pipeline status check will also be bypassed if it's not touching the plugins file?

An easy way is to revert #57.
I guess there would get another better way to do this.

Hi,

I'm the author of the Google Calendar plugin. I think the plugin got broken after the upgrade to the new Python version and sadly I didn't manage to fix it then and don't have the time now. Can the plugin be removed, then people won't download a broken plugin.

Thanks in advance.

Runners original url is no longer applicable, update it to the runner repo url instead.

Related Flow-Launcher/docs#32

Update test python plugin ci to find python plugin that does not have tested field- current method only checks the last plugin to see if it is python. This might not work if there is more than one submission or if the new plugin is not in the last entry (e.g. from resolving main branch conflict).

Change to update etag only when it doesn't exist ie a new plugin. It seems from the commits etag changes every now or so.

I made a cool youtube video downloader plugin in this repo: https://github.com/DeepVoyager253/FlowLauncherYTDownload

and i didnt really understand how to send it for verification. if possible, i would like it to be reviewed here, and in case it doesnt pass, i want to know how i can improve it to make it better!

I want to make a database connection plugin. How can I store the password from this database?
It's good if I can store it in the Flow.Launcher so that you can easily change it. Is it safe?

Hi there.

As I see, currently Flow Launcher displays plugins in plugin store in the same order as they are present in plugins.json.
For small number of plugins it was fine, but right now when a lot of plugins have been created for Flow Launcher a lot of very useful and appreciated by users plugins may be at the end of the list in shadow of plugins created earlier.

My proposed quick and easy solution for this problem is to reorder plugins in plugin.json using downloads_count property exposed by GitHub API:
https://api.github.com/repos/{repository_author}/{repository_name}/releases.

Changes in the code will perform:

1. Send a request to the API
2. Iterate through records from API and sum downloads_count property
3. Order items by sum of downloads_count

As we know Flow Launcher is becoming a powerful tool thanks to it's strong community and plugins, this feature will result in much more pleasing user experience, especially for new users:

• New users will know right away which plugins are widely used and appreciated.
• Plugin store will be less cluttered with non-widely used plugins as they will be at the end of the list.
• Better UI experience as you do not have to scroll to the bottom of a large list to find something specific that is popular.

As title.

And I will do some try on my fork

Issue Description:
Yesterday (about 24 hours ago) I have published new release of a plugin (in version 1.2.0) to my repository. Plugin entry is present in plugins.json file. For some reason CI Auto Updater that is executed every 3 hours is not increasing initial version from 1.1.0 to 1.2.0.

Affected Repository:
https://github.com/KrystianLesniak/Flow.Launcher.Plugin.GamesLauncher

    {
        "ID": "54545DC7B3A542DBB6C7DA50DEAD455B",
        "Name": "GamesLauncher",
        "Description": "Search and launch games from multiple platforms like Steam, Epic Games etc.",
        "Author": "KrystianLesniak",
        "Version": "1.1.0",
        "Language": "csharp",
        "Website": "https://github.com/KrystianLesniak/Flow.Launcher.Plugin.GamesLauncher",
        "UrlDownload": "https://github.com/KrystianLesniak/Flow.Launcher.Plugin.GamesLauncher/releases/download/v1.1.0/GamesLauncher.zip",
        "UrlSourceCode": "https://github.com/KrystianLesniak/Flow.Launcher.Plugin.GamesLauncher/tree/main",
        "IcoPath": "https://cdn.jsdelivr.net/gh/krystianlesniak/Flow.Launcher.Plugin.GamesLauncher@master/Flow.Launcher.Plugin.GamesLauncher/icon.png",
        "DateAdded": "2023-08-22T14:44:38Z",
        "LatestReleaseDate": null
    }

Repository have tags in this format: "v1.0.0", "v1.1.0", "v1.2.0"
Release titles are: "v1.0.0", "v1.1.0", "v1.2.0"
Attached zip with binaries is without version suffix - "GamesLauncher.zip" instead of for example "GamesLauncher-1.2.0.zip".

Additional Context:
It's very unlikely as the source of issue but initial entry in plugins.json was made with version 1.1.0 instead of 1.0.0.

Summary:
The custom Continuous Integration (CI) system in repository is designed to automatically update information about plugins every 3 hours, but it has not updated my plugin information for the past 24 hours.

Thank you for your attention to this issue. Please let me know if you need any further information or assistance in resolving this issue. I would be happy to help as much as I can, I have tried to investigate issue myself but I am not really expertise in Python language.