contracts's People
Forkers
doruciocleacontracts's Issues
feature request: deposit token
- interface and implementation to deposit ETH.
- reference implementation: https://github.com/matter-labs/zksync/blob/1cda8c7c1a9bfbec6491a1e4634b0fc33b206834/contracts/contracts/ZkSync.sol#L174
- use L1 address (ETH address) instead of L2 address (franklin address) for now
- we'd better have lib like in https://github.com/Loopring/protocols/blob/master/packages/loopring_v3/contracts/core/impl/libexchange/ExchangeDeposits.sol and https://github.com/Loopring/protocols/blob/a0639b1c4f7fa8d065f2ea251dbd80d86ec85509/packages/loopring_v3/contracts/core/impl/ExchangeV3.sol#L39
- unless it costs more gas
- token registeration
- interface and implementation to deposit ERC20
L1 "internal transfer"
chore: migration & deployment testing tools
not an emergency
TODOs with priority
proxy and Upgradeable pattern
Governance mechanism
- pause token
- ...
test: force report error if event not detected
bump OpenZeppelin-contracts to v4.1.0
these looks great:
- UpgradeableProxy (#2)
- safemath:
chage bjjPubkey type from string to bytes32
Currently I am using string because it always fails on emitting correct event messages everytime I try with bytes32
double check address(this)
upgrade proxy
check exodus mode
not an emergency
DESIGN: use uint128 or uint256 for amount?
registerWithdrawal
rollup (block verification & submission)
maintain a map for balance to withdraw
add NewPriorityRequest event check in token.js test
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.