flyntwp / flynt-core Goto Github PK

Since TWIG is just a templating language for files, not just HTML files, is a good practice to append the file type extension to file name so code editors can guess and configure themselves accordingly.

I just wanted to know your point of view regarding this.

I figured out that installing this package via Composer without using a registered SSH key will not work and you'll need to enter a Github Auth Token which can't be done in a lot of terminal emulators because copy/paste is disabled.

Maybe it's just better to use HTTPS so you don't need a Github account to use this.

Currently it wants to install from [email protected]:bleech/wp-starter-plugin.git

As far as I can see from the code, Flynt is currently not capable of having nested/grouped components. This can get confusing for bigger projects, especially if you want to create a set of shared components (which seems also not possible currently).

For shared components we currently using this workaround to register a twig namespace and reference it in a sibling template. How do you at bleech realise shared components currently? E.g. have a teaser article shown in a grid and in a listing.

add_filter('timber/loader/loader', function($loader) {
  $loader->addPath(Feature::getOption('flynt-components', 0), 'Component');
  return $loader;
});

{{ include '@Component/BlockButton/index.twig' }}

To have it more structured we thought it would be helpful to have a grouped folder structure like this:

Components
  Block
    Button
    Image
  List
    Posts
    Users   

Then add the parent folders as namespaces:

add_filter('timber/loader/loader', function($loader) {
  $loader->addPath(Feature::getOption('flynt-components', 0) . '/Block', 'Block');
  $loader->addPath(Feature::getOption('flynt-components', 0) . '/List', 'List');
  // etc…
  return $loader;
});

To reference it like this in the twig templates:

{{ include '@Block/Button/index.twig' }}

Did you thought about this already? If so, why did you chose the current way? Before start working on a POC I thought asking for your thoughts first 🙏

Thanks!