fn-fal113 / relicsofcthonia

My entry for slimefun addon jam 2022 which add new relics in the nether waiting to be unearthed and dropped!

Welcome to my Github profile!

• I’m currently learning frameworks and langs, also went outside boundaries by doing some first person animation using blender

• Open to work as web and app developer mainly focusing on backend

Languages and Tools:

relicsofcthonia's Issues

Nether World Name

Describe the bug
If nether world name not same as world_nether, then the relic won't drop on mob kill and block break

To Reproduce (Important)
Steps to reproduce the behavior:

1. Open server.properties, change level-name name.
2. Open the server to see result.

Expected behavior
Can have config to setting nether world name.

Screenshots

Server Log

Environment (REQUIRED)

World protection creates easily farmable relics.

Describe the bug
Repearedly breaking natural netherrack in a protected area (world guard, factions, etc) will cause the plugin to drop many relics, because the block will not get removed after each break.

To Reproduce (Important)
Steps to reproduce the behavior:
Go to the nether. Create a world guard region that includes natural netherrack and have someone without permission to break it repeatedly break the block. This will not break the block due to protection, but will create many relics.

Fixable by changing this line to priority monitor: https://github.com/FN-FAL113/RelicsOfCthonia/blob/main/src/main/java/ne/fnfal113/relicsofcthonia/listeners/MiningListener.java#L29 .

Clearing "Condition" in lore

Describe the bug
When you place a relic and break it then relic will be without condition

To Reproduce (Important)
Steps to reproduce the behavior:

1. Place a relic
2. Break a relic
3. In inventory will be shown Condition: %

Expected behavior
It should not clear condition

Screenshots

Server Log

Environment (REQUIRED)

This Server uses the following setup of Slimefun:
Paper git-Paper-386 (MC: 1.18.2)
Slimefun DEV - 1015 (git 2c4f886f)
Metrics-Module #28
Java 17
Installed Addons: (15)
Networks vDEV - 37 (git f1915513)
CrystamaeHistoria vDEV - 75 (git 12c8d18f)
RelicsOfCthonia vDEV - 2 (git 3f8ef79c)
SlimefunWarfare vDEV - 80 (git 364331cf)
ExoticGarden vDEV - 78 (git 7f9a5f63)
ShopChestDoughPatch v1.0-SNAPSHOT
InfinityExpansion vDEV - 140 (git 0098d2fb)
CMILib v1.2.0.3
SFCalc vDEV - 37 (git dfc0fc41)
SimpleUtils vDEV - 15 (git 4250fd5e)
SlimefunIdConverter v1.0.0
ExtraHeads vDEV - 23 (git 0b59a770)
Galactifun vDEV - 63 (git 364ecbf5)
FluffyMachines vDEV - 118 (git 23a6b1c4)
CMI v9.2.0.4

• Server Software and Version (Spigot/Paper):
• Minecraft version: 1.18.2
• Slimefun version: DEV 1015
• RelicsOfCthonia version: DEV 2

RelicsOfCthonia bug

in version RelicsOfCthonia vDEV - 9 (git dfe76ab) is coming many items and is not working the percentage that was configured in version RelicsOfCthonia - DEV 8 (git a7ef6).jar did not have this problem

slimefun and addons version: https://prnt.sc/h6efV-Smhnvu

it is happening that the addon is not checking the percentages and is dropping a lot of items

video: https://www.youtube.com/watch?v=i5-oVyWiNcc

Drops happen in diabled worlds.

Describe the bug
Disabled items in a world (via SF per-world item list) does not stop drops from occurring.

To Reproduce (Important)
Steps to reproduce the behavior:

1. Open ./plugins/Slimefun/world-settings/world_nether.yml or any other world a drop can occur
2. Disable items
3. Go mine for items (I think mobs aren't dropping them, but may need more testing. I've killed many mobs on my own and nothing has dropped from them.

Expected behavior
I expect no drops at all from this or any other addon when disabled in the world in question, be it mobs or (in this case) blocks.

Screenshots
Not applicable

Server Log
Not applicable.

Environment (REQUIRED)

• Paper: 1.19.2 131
• Minecraft version: 1.19.2
• Slimefun version: SF Dev 1027 (96c873bd)
• RelicsOfCthonia version: vDev 6 (5ba8f97)