FodyTarget condition excluding use during 'DesignTimeBuild' breaks use with Live Unit Testing about fody

[tom-englert]

@richardhauer to me this looks good, should not have any side effects.
Can you provide a PR with this change?

[SimonCropp]

it was to fix this issue #349

[SimonCropp]

i would not like to use 'DesignTimeBuildto inferLive Unit Testing` since that would seem to be a side effect.

[richardhauer]

While DesignTimeBuild property does not imply LUT, the reverse is true - LUT does have the DesignTimeBuild property set, at least, removing the condition allows Fody to work in LUT.

WRT #349 it seems that blocking Fody for all design-time builds might be too broad. There may be a more specific way to get Fody to play nicely with NServiceBus and still work for LUT. Perhaps @davkean could be drawn on this topic?

In his linked document on the subject, @davkean states that:

Targets that dynamically change references, source files or compilation options must run during design-time builds to avoid unexpected behavior in Visual Studio.

... and seeing as this is the whole job of Fody it would seem (to me) that is exactly when it should be running. In which case a deeper look at the original problem in #349 might reveal an alternative, more specific approach to addressing the issue.

[davkean]

Design-Time builds don't produce binaries, Fody runs on top of a binary. Therefore cannot run in design-time builds.

[richardhauer]

@davkean Ah ok; is there a way you might suggest we can get Fody to work in an LUT scenario without resorting to removing the And $(DesignTimeBuild) != true condition clause? That's the real goal. There's very little information around on how the LUT system works, from what I've been able to find.

[davkean]

See: https://docs.microsoft.com/en-us/visualstudio/test/live-unit-testing-faq?view=vs-2019#customize-builds.

[richardhauer]

Righto. So update the condition to something along the lines of this?

Condition="Exists(@(IntermediateAssembly)) And ($(DesignTimeBuild) != true Or $(BuildingForLiveUnitTesting) == true) And $(DisableFody) != true"

Exclude Fody from the build chain if DesignTimeBuild unless also BuildingForLiveUnitTesting ?
@SimonCropp I can confirm that my LUT does work when the Condition attribute is updated as above. I suspect this will allow both the LUT case and the NServiceBus case to work, though I don't have a way to test the latter.

[richardhauer]

@tom-englert please see PR #1037

[SimonCropp]

thanks everyone for all the help. i will deploy this now