[Datapack] Incompatibility with Supplementaries about filledtothebrim

[Ultimushadow]

Hey no worries, modding can take a lot of time and it's probably for the best you aren't chronically online like some of us (me, the some of us)
I'll test it out now and see how it goes, thanks for the work!

[Ultimushadow]

Okay, it looks like everything is working as intended, for the most part! Shulker boxes and all colored variations are able to be nested into other shulker boxes including colored, Safes, Sacks, and colored Sacks from Supp Squared. I did notice a weird bit of interaction with the Supplementaries items though. When messing with the "nestable_when_empty" tag, when I did not have the safe/sack/colored sack items, I could nest empty and full items into other containers. When I did add those items to the tag, I couldn't add empty or full items into other containers. Maybe I'm doing something wrong though - I saw on the other issue report you guys were talking about tags and stuff, I currently have Supp 2.5.21, SuppSquared 1.1.6, and the FTTB version you just sent me running on 1.20.1 in case it's important.
At present, it's no longer that big a deal as the crash is avoided and the shulker nesting works as intended, I don't see my players needing to carry large amounts of sacks or safes the same way they carry shulker boxes, however, depending on whether or not this is specific to Supplementaries this might pose a problem with other mods that add containers.
I've yet to really test this by sticking it on a server and letting my players have a go at things so for now, I don't see the need to press you to pull your hair out over a minor issue and will probably just be using this mod as it is now, but I'll let you know if we run into anything!

[Ultimushadow]

Ticket looks good to me, if you find any progress I'll still be interested in updates so I'm good with leaving it open
As for the possible solution it definitely seems tricky, I have had a look in the code too far in but I wonder if there's a way for mod authors to opt in rather than you handling every implementation of storage item that can exist. Personally I see the most use with mods like supplementaries, ones that are pretty close to vanilla in terms of game design and could probably make their items compatible with your system without you having to put too much work in handling a ton of variation. Of course, I'm speaking purely from a design standpoint so I wouldn't be of much help for specifics
As for the time, don't worry about it, it comes with the territory and I'm glad you got to it at all since I wont have to drop it from my pack anymore!

[fooeyround]

Oh my, I am so sorry, I did not get a notification and have been away.. I'll fix it as soon as I can. Sorry.

[fooeyround]

@Ultimushadow Sorry for the delay, does this work? (Unzip and use the version you are running)

[fooeyround]

Yeah. That seems right based on the current implement. I need to rethink it to allow for modded items and such. It works for bundles and shulkers, but nothing else. I need to find a more dynamic way of doing things. Problem is, mods could technically name the NBT Compound anything. But I might just base it on Minecraft's Inventories code.

[fooeyround]

Leaving this open of course because of the datapack compatibly issues

[fooeyround]

Is the new title okay?

[fooeyround]

Also, again, sorry for the over 20 day wait. I was home for the first 10 🥲

[fooeyround]

Yeah. That's up to the supplementary dev(s), I'll ask them soon. Glad to see it can go back into your pack. I might have to try it out sometime :)