fooeyround / filledtothebrim

A Minecraft mod that allows you to put empty Shulker Boxes inside Shulker Boxes

Filled To The Brim

This Mod Was made in part with Fallen Breath's Multi Version Mod Template

This Mod allows empty Shulker Boxes to be put inside other Shulker Boxes.

This mod is data driven, using datapack tags to control the mod.

To Enable the mod you need to download this pack and enable it in game.

If you want to disable the mod with magenta boxes (for things like easier box sorting), you can get it here

If the mod does not work with the datapack, redownload the datapack and update the mod

(datapack v1 is for 1.2.2 and below, all further versions use v2)

filledtothebrim's Issues

[Datapack] Incompatibility with Supplementaries

Bug description

**Any mention of Supplementaries sack item also affects Supplementaries Safe item

Supplementaries adds its own "shulker box lite" in the form of the sack. These items have 9 slots and are severely underpowered compared to shulker boxes, however, FTTB seems to be messing with the tags Supplementaries uses or vice versa. With Supplementaries but without FTTB, empty sacks and shulker boxes can not be added to the inventories of other sacks or shulker boxes. With Supplementaries, FTTB, and the default datapack enabled, empty shulker boxes can't nest in other shulker boxes, and sacks (including ones with items) can be nested into shulker boxes without having touched anything in the datapack/tags. However, attempting to put anything into a sack immediately crashes the client.

Steps to reproduce

Fabric 1.20.1, FTTB 1.20-v1.2.5, Supplementaries 1.20-2.5.17 (and Supplementaries Squared 1.20-1.1.5 if it matters)
Log into a single player world, enable the datapack for FTTB, place down a sack from Supplementaries and attempt to put any item in.

Expected behavior

Sacks should accept items without crashing, shulker boxes should accept empty shulker boxes, and sacks should not be able to be put into shulker boxes without altering the default datapack

Actual behavior

Attempting to put items into a sack crashes the game, and sacks are able to be put into shulker boxes without changing anything about the default datapack, while shulker boxes cannot be nested

Relevant logs

The relevant crash from the log:

[06:11:51] [Render thread/ERROR] (Minecraft) Reported exception thrown!
net.minecraft.class_148: Container click
at net.minecraft.class_437.method_25412(class_437.java:414) ~[client-intermediary.jar:?]
at net.minecraft.class_312.method_1601(class_312.java:100) ~[client-intermediary.jar:?]
at net.minecraft.class_312.method_22686(class_312.java:169) ~[client-intermediary.jar:?]
at net.minecraft.class_1255.execute(class_1255.java:102) ~[client-intermediary.jar:?]
at net.minecraft.class_312.method_22684(class_312.java:169) ~[client-intermediary.jar:?]
at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43) ~[lwjgl-glfw-3.3.1.jar:?]
at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.3.1.jar:?]
at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3403) ~[lwjgl-glfw-3.3.1.jar:?]
at com.mojang.blaze3d.systems.RenderSystem.pollEvents(RenderSystem.java:201) ~[client-intermediary.jar:?]
at com.mojang.blaze3d.systems.RenderSystem.flipFrame(RenderSystem.java:212) ~[client-intermediary.jar:?]
at net.minecraft.class_1041.method_15998(class_1041.java:288) ~[client-intermediary.jar:?]
at net.minecraft.class_310.method_1523(class_310.java:1241) ~[client-intermediary.jar:?]
at net.minecraft.class_310.method_1514(class_310.java:802) ~[client-intermediary.jar:?]
at net.minecraft.client.main.Main.main(Main.java:250) ~[minecraft-1.20.1-client.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468) ~[fabric-loader-0.14.21.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.14.21.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.14.21.jar:?]
at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88) ~[NewLaunch.jar:?]
at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126) ~[NewLaunch.jar:?]
at org.prismlauncher.EntryPoint.main(EntryPoint.java:71) ~[NewLaunch.jar:?]
Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1937.method_8320(net.minecraft.class_2338)" because the return value of "net.minecraft.class_2586.method_10997()" is null
at net.minecraft.class_2627.handler$dgb001$filledtothebrim$canInsert(class_2627.java:532) ~[client-intermediary.jar:?]
at net.minecraft.class_2627.method_5492(class_2627.java) ~[client-intermediary.jar:?]
at net.mehvahdjukaar.supplementaries.common.utils.MiscUtils.isAllowedInShulker(MiscUtils.java:132) ~[supplementaries-1.20-2.5.17-fabric.jar:?]
at net.mehvahdjukaar.supplementaries.common.block.tiles.SafeBlockTile.method_5437(SafeBlockTile.java:241) ~[supplementaries-1.20-2.5.17-fabric.jar:?]
at net.mehvahdjukaar.supplementaries.common.inventories.DelegatingSlot.method_7680(DelegatingSlot.java:16) ~[supplementaries-1.20-2.5.17-fabric.jar:?]
at net.minecraft.class_1735.method_32755(class_1735.java:149) ~[client-intermediary.jar:?]
at net.minecraft.class_1703.method_30010(class_1703.java:412) ~[client-intermediary.jar:?]
at net.minecraft.class_1703.method_7593(class_1703.java:294) ~[client-intermediary.jar:?]
at net.minecraft.class_636.method_2906(class_636.java:450) ~[client-intermediary.jar:?]
at net.minecraft.class_465.method_2383(class_465.java:548) ~[client-intermediary.jar:?]
at net.minecraft.class_465.method_25406(class_465.java:512) ~[client-intermediary.jar:?]
at net.minecraft.class_312.method_1605(class_312.java:100) ~[client-intermediary.jar:?]
at net.minecraft.class_437.method_25412(class_437.java:409) ~[client-intermediary.jar:?]
... 19 more

Minecraft version

1.20.1

TemplateMod version

1.2.5

Other information

I can see that Supplementaries uses their own tag system, which I imagine could be modified to allow for empty sack/shulker box nesting.

I also messed around to experiment with what breaks, I managed to get items into a sack with FTTB disabled, relaunched the game with FTTB enabled again, and the sack with items was able to stack in a shulker box
I tried to use a hopper to push items into a sack which caused a ticking block entity, luckily Neruina stopped the game from crashing but it resulted in pretty much the same crash, just with a log of the hopper trying to push the item in. It could pull items out of a sack with items just fine though interestingly, I assume it doesn't need to check the tags to see what's allowed when that happens.

@MehVahdJukaar Any ideas on how this might be remedied?

Check list

• I have verified that the issue persists in the latest version of the mod.
• I have searched the existing issues and confirmed that this is not a duplicate.

Why do we hate magenta?

Motivation

I don't understand what you mean by "If you want to disable the mod with magenta boxes (for things like easier box sorting)"

Description

Please explain a little more, I'm not picking up what you're throwing down.

Other information

No response