forbeslindesay / acorn-globals Goto Github PK

View Code? Open in Web Editor NEW

45.0 45.0 26.0 67 KB

Use acorn to detect global variables in JavaScript

License: MIT License

JavaScript 100.00%

acorn-globals's People

Contributors

Stargazers

Watchers

acorn-globals's Issues

An in-range update of testit is breaking the build 🚨

The devDependency testit was updated from `3.0.0` to `3.1.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

testit is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 7 commits.

9408ef4 3.1.0
fcacc24 Update wtfnode and tests (#41)
9aa2f50 fix(package): update wtfnode to version 0.7.0 (#37)
b90f0b8 fix(package): update wtfnode to version 0.6.0 (#34)
8ac043d 3.0.1
12b523f Add Node 7, 8, and 9 support on Travis (#32)
fc0599e Release 3.0.0

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Why `class G { }` in `{ }` scope avoid `G;` treated as global?

{
    class G { }
}
G;

detect(above) // []

Which found in test/fixtures/class.js and used at test/index.js#L40.

In fact, class is equal to const, and it's scope is only { }, the G outside it doesn't refer to the class.

@TimothyGu Hi, would you help to explain? Thank you! (I found you in the commit f46e53c#diff-d57a8e08e9a4aea760326e450e1f9911.)

An in-range update of acorn-walk is breaking the build 🚨

The dependency acorn-walk was updated from `6.1.0` to `6.1.1`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

acorn-walk is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

error when detect destructuring assignment

'use strict';
const detect = require('acorn-globals');
detect(`
var { ...rest } = {};
`);

    switch (node.type) {
                 ^

TypeError: Cannot read property 'type' of undefined
    at declarePattern      (acorn-globals\index.js:58:18)
    at                     (acorn-globals\index.js:64:11)
    at Array.forEach       (<anonymous>)
    at declarePattern      (acorn-globals\index.js:63:25)
    at                     (acorn-globals\index.js:97:9)
    at Array.forEach       (<anonymous>)
    at VariableDeclaration (acorn-globals\index.js:96:25)
    at c                   (acorn-globals\node_modules\acorn-walk\dist\walk.js:45:18)
    at Object.skipThrough  (acorn-globals\node_modules\acorn-walk\dist\walk.js:183:37)
    at c                   (acorn-globals\node_modules\acorn-walk\dist\walk.js:44:22)

And also function f ({ ...rest }) { }.

class expression is treated incorrectly

const a = class b { };

const a = ( class b { } );

const a = { b: class b { } }.b;

const a = [ class b { } ][0];

b is treated as a global reference. @ForbesLindesay

I don't know how to fix this problem like the other which I directly open a PR (#46).

An in-range update of acorn is breaking the build 🚨

Version 5.3.0 of acorn was just published.

Branch	Build failing 🚨
Dependency	acorn
Current Version	5.2.1
Type	dependency

This version is covered by your current version range and after updating it in your project the build failed.

acorn is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

❌ dependency-ci An error occured Details

Commits

The new version differs by 36 commits.

621f869 Mark version 5.3.0
c313c55 Update links to the repository
e5ee27f Add test262 to travis
f1633b4 Add script for running test262 tests
a6ee903 Add SwitchCase to walk
fe9115f Change error message when await is found in a non-async block.
d20f46b Check pattern errors only if using expr as pattern
2b6ed51 Make bin/acorn point to a generated acorn file.
332cac5 Move semi parsing to parseClassMember
4eba230 Disallow escapes in contextual keywords
8c0bd0d Add tests for escape sequences in contextual keywords
a84648d Simplify getter/setter argument checks
f126864 Simplify parseClassMember
92cc877 Extract parseClassMember
d4efa35 Only consider double proto props an error in expression context

There are 36 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Browserify doesn't work anymore

// browser.js

require('./')

timothy_gu@ubuntu-lenovo:~/jade/acorn-globals$ ./node_modules/.bin/browserify browser.js 
Error: Cannot find module './state' from '/home/timothy_gu/jade/acorn-globals/node_modules/acorn/dist'
    at /home/timothy_gu/jade/acorn-globals/node_modules/browserify/node_modules/resolve/lib/async.js:55:21
    at load (/home/timothy_gu/jade/acorn-globals/node_modules/browserify/node_modules/resolve/lib/async.js:69:43)
    at onex (/home/timothy_gu/jade/acorn-globals/node_modules/browserify/node_modules/resolve/lib/async.js:92:31)
    at /home/timothy_gu/jade/acorn-globals/node_modules/browserify/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:77:15)

This broke Jade: https://travis-ci.org/jadejs/jade/jobs/56260858#L114-L141

An in-range update of acorn is breaking the build 🚨

Version 5.7.3 of acorn was just published.

Branch	Build failing 🚨
Dependency	acorn
Current Version	5.7.2
Type	dependency

This version is covered by your current version range and after updating it in your project the build failed.

acorn is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 6 commits.

910e62b Mark version 5.7.3
3442a80 Make generate-identifier-regex capable of rewriting src/identifier.js
22b22f3 Raise specific errors for unterminated template literals
1461c7c Fix a lint error
0c12f63 Fix tokenizing of regexps after .of
832c308 Fix 404 url

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Cannot specify ECMA version

Hello, me again.

I am using acorn-globals on valid ECMA 8 scripts, but since Acorn doesn't use ECMA 8 by default, I get parse errors.

My proposed solution is to add an options parameter to acorn-globals findGlobals that gets passed to acorn.parse. This solution would give flexibility beyond specifying an ECMA version.

What does VariablePattern refer to?

acorn-globals/index.js

Line 158 in 919f075

'VariablePattern': identifier,

What does VariablePattern refer to? I can't find it in estree spec

I see it's added in 46a3a9f#diff-168726dbe96b3ce427e7fedce31bb0bc

Note AST mutation

It should be noted in the Readme that acornGlobals(ast) will mutate ast, adding array of parents to Identifier nodes. These unexpected properties might trip folks that are walking the AST after running acornGlobals.

Alternatively, acornGlobals could deep clone the input, to avoid mutating it.

Unexpected token with version 1.0.7

Just npm installed a new keystone.js project, which has dependency on jade, which has dependency on with, which has dependency on this. After 2 hours of debugging found that v. 1.0.6 works just fine.

SyntaxError: Unexpected token (1:216)
  at Parser.pp.raise (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:1745:13)
  at Parser.pp.unexpected (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:2264:8)
  at Parser.pp.parseBindingAtom (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:1876:12)
  at Parser.pp.parseMaybeDefault (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:1920:23)
  at Parser.pp.parseBindingList (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:1896:23)
  at Parser.pp.parseFunctionParams (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:2776:22)
  at Parser.pp.parseFunction (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:2769:8)
  at Parser.pp.parseExprAtom (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:1129:19)
  at Parser.pp.parseExprSubscripts (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:1023:19)
  at Parser.pp.parseMaybeUnary (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:1004:19)
  at Parser.pp.parseExprOps (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:948:19)
  at Parser.pp.parseMaybeConditional (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:930:19)
  at Parser.pp.parseMaybeAssign (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:908:19)
  at Parser.pp.parseParenAndDistinguishExpression (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:1188:28)
  at Parser.pp.parseExprAtom (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:1111:19)
  at Parser.pp.parseExprSubscripts (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:1023:19)
  at Parser.pp.parseMaybeUnary (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:1004:19)
  at Parser.pp.parseExprOps (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:948:19)
  at Parser.pp.parseMaybeConditional (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:930:19)
  at Parser.pp.parseMaybeAssign (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:908:19)
  at Parser.pp.parseExpression (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:882:19)
  at Parser.pp.parseStatement (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:2461:23)
  at Parser.pp.parseTopLevel (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:2379:21)
  at Object.parse (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/node_modules/acorn/dist/acorn.js:101:12)
  at reallyParse (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/index.js:24:18)
  at unwrapReturns (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/index.js:90:13)
  at addWith (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/node_modules/with/index.js:77:37)
  at parse (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/lib/index.js:149:9)
  at Object.exports.compile (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/jade/lib/index.js:205:16)
  at compileTemplate (/Users/patrikholcak/dev/test/node_modules/keystone/lib/core/render.js:38:15)
  at [object Object].render (/Users/patrikholcak/dev/test/node_modules/keystone/lib/core/render.js:43:5)
  at module.exports (/Users/patrikholcak/dev/test/node_modules/keystone/admin/routes/views/home.js:5:11)
  at Layer.handle [as handle_request] (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/layer.js:95:5)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:131:13)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at Route.dispatch (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:112:3)
  at Layer.handle [as handle_request] (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/layer.js:95:5)
  at /Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/index.js:277:22
  at Function.process_params (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/index.js:330:12)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/index.js:271:10)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:121:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at exports.keystoneAuth (/Users/patrikholcak/dev/test/node_modules/keystone/lib/session.js:214:2)
  at Layer.handle [as handle_request] (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/layer.js:95:5)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:131:13)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:125:14)
  at Route.dispatch (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/route.js:112:3)
  at Layer.handle [as handle_request] (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/layer.js:95:5)
  at /Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/index.js:277:22
  at param (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/index.js:349:14)
  at param (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/index.js:365:14)
  at Function.process_params (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/index.js:410:3)
  at next (/Users/patrikholcak/dev/test/node_modules/keystone/node_modules/express/lib/router/index.js:271:10)
  at /Users/patrikholcak/dev/test/node_modules/keystone/node_modules/grappling-hook/index.js:198:10
  at doNTCallback0 (node.js:417:9)
  at process._tickCallback (node.js:346:13)

Unexpected token with version 3.1.0

Hi!
I get the following error and can't go on

SyntaxError: Unexpected token (8:1)
    at Parser.pp$4.raise (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:2488:13)
    at Parser.pp.unexpected (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:623:8)
    at Parser.pp$3.parseExprAtom (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:2011:10)
    at Parser.pp$3.parseExprSubscripts (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:1872:19)
    at Parser.pp$3.parseMaybeUnary (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:1849:17)
    at Parser.pp$3.parseMaybeUnary (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:1840:26)
    at Parser.pp$3.parseExprOps (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:1791:19)
    at Parser.pp$3.parseMaybeConditional (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:1774:19)
    at Parser.pp$3.parseMaybeAssign (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:1750:19)
    at Parser.pp$3.parseExpression (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:1722:19)
    at Parser.pp$1.parseStatement (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:777:45)
    at Parser.pp$1.parseTopLevel (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:672:23)
    at Parser.parse (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:529:15)
    at Object.parse (.........../node_modules/acorn-globals/node_modules/acorn/dist/acorn.js:3378:37)
    at reallyParse (.........../node_modules/acorn-globals/index.js:22:16)
    at findGlobals (.........../node_modules/acorn-globals/index.js:35:11)

Thanks

Version 10 of node.js has been released

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

More information on this issue

Greenkeeper has checked the engines key in any package.json file, the .nvmrc file, and the .travis.yml file, if present.

engines was only updated if it defined a single version, not a range.
.nvmrc was updated to Node.js 10
.travis.yml was only changed if there was a root-level node_js that didn’t already include Node.js 10, such as node or lts/*. In this case, the new version was appended to the list. We didn’t touch job or matrix configurations because these tend to be quite specific and complex, and it’s difficult to infer what the intentions were.

For many simpler .travis.yml configurations, this PR should suffice as-is, but depending on what you’re doing it may require additional work or may not be applicable at all. We’re also aware that you may have good reasons to not update to Node.js 10, which is why this was sent as an issue and not a pull request. Feel free to delete it without comment, I’m a humble robot and won’t feel rejected 🤖

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

acorn-globals is dependent on vulnerable version of acorn

Per https://www.npmjs.com/advisories/1488 , acorn v6 is vulnerable. This package (acorn-globals) is used by jsdom. In turn jsdom is used by a lot of other packages, including jest.

I am not familiar with this package, but I will try to investigate what I can do help with an upgrade.

Here is what many people are seeing when they use npm audit:

                       === npm audit security report ===                        

                                                                                
                                 Manual Review                                  
             Some vulnerabilities require your attention to resolve             
                                                                                
          Visit https://go.npm.me/audit-guide for additional guidance           
                                                                                
                                                                                
  Moderate        Regular Expression Denial of Service                          
  Package         acorn                                                         
  Patched in      >=7.1.1                                                       
  Dependency of   jest [dev]                                                    
                                                                                
  Path            jest > @jest/core > @jest/reporters > jest-runtime >          
                  jest-config > jest-environment-jsdom > jsdom > acorn-globals  
                  > acorn                                                       
                                                                                
  More info       https://npmjs.com/advisories/1488                             
                                                                                
                                                                                
  Moderate        Regular Expression Denial of Service                          
  Package         acorn                                                         
  Patched in      >=7.1.1                                                       
  Dependency of   jest [dev]                                                    

  Path            jest > jest-cli > @jest/core > @jest/reporters >              
                  jest-runtime > jest-config > jest-environment-jsdom > jsdom   
                  > acorn-globals > acorn                                       
                                                                                
  More info       https://npmjs.com/advisories/1488                             
                                                                                
                                                                                
  Moderate        Regular Expression Denial of Service                          
  Package         acorn                                                         
  Patched in      >=7.1.1                                                       
  Dependency of   jest [dev]                                                    
                                                                                
  Path            jest > @jest/core > jest-runner > jest-jasmine2 >             
                  jest-runtime > jest-config > jest-environment-jsdom > jsdom   
                  > acorn-globals > acorn                                       
                                                                                
  More info       https://npmjs.com/advisories/1488                             
                                                                                
                                                                                
  Moderate        Regular Expression Denial of Service                          
  Package         acorn                                                         
  Patched in      >=7.1.1                                                       
  Dependency of   jest [dev]                                                    
                                                                                
  Path            jest > jest-cli > @jest/core > jest-runner > jest-jasmine2 >  
                  jest-runtime > jest-config > jest-environment-jsdom > jsdom   
                  > acorn-globals > acorn                                       
                                                                                
  More info       https://npmjs.com/advisories/1488                             
                                                                                
                                                                                
  Moderate        Regular Expression Denial of Service                          
  Package         acorn                                                         
  Patched in      >=7.1.1                                                       
  Dependency of   jest [dev]                                                    
                                                                                
  Path            jest > @jest/core > jest-runner > jest-runtime > jest-config  
                  > jest-environment-jsdom > jsdom > acorn-globals > acorn      
                                                                                
  More info       https://npmjs.com/advisories/1488                             
                                                                                
  [...snip...]

question on walking scopes

I noticed this bit of code:

acorn-globals/index.js

Lines 108 to 112 in 4e8b85c

 for (var i = parents.length - 2; i >= 0 && parent === null; i--) { 

 if (isScope(parents[i])) { 

 parent = parents[i]; 

 } 

 }

It looks like it's walking parents for the first one not returning true for isScope(parent) ~~however the for-loop is still walking back the parents until null or i < 0~~. Would dig some more info on that loop please. Thanks!

Update:

Doh 🤦 . I got it.

Update to acorn 4.x?

Would be nice!

Seems to have broken with Acorn 1.1.0

At least, the tests are failing, and jsdom is breaking in similar ways: jsdom/jsdom#1131 acornjs/acorn#263

Acorn's fault but thought I'd bring it to your attention...

An in-range update of acorn is breaking the build 🚨

The dependency acorn was updated from `6.0.2` to `6.0.3`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

acorn is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

	for (var i = parents.length - 2; i >= 0 && parent === null; i--) {
	if (isScope(parents[i])) {
	parent = parents[i];
	}
	}

forbeslindesay / acorn-globals Goto Github PK

acorn-globals's People

Contributors

Stargazers

Watchers

Forkers

acorn-globals's Issues

The devDependency testit was updated from 3.0.0 to 3.1.0.

The dependency acorn-walk was updated from 6.1.0 to 6.1.1.

Version 5.3.0 of acorn was just published.

Version 5.7.3 of acorn was just published.

Version 10 of Node.js (code name Dubnium) has been released! 🎊

The dependency acorn was updated from 6.0.2 to 6.0.3.

Recommend Projects

Recommend Topics

Recommend Org

Jobs

The devDependency testit was updated from `3.0.0` to `3.1.0`.

The dependency acorn-walk was updated from `6.1.0` to `6.1.1`.

The dependency acorn was updated from `6.0.2` to `6.0.3`.