GithubHelp home page GithubHelp logo

Comments (7)

AlexAVL avatar AlexAVL commented on July 23, 2024 1

@jeffladiray I have just tested the new release and it's working perfectly. Thank you for fixing this and getting it out there so quickly.

from forest-express-mongoose.

AlexAVL avatar AlexAVL commented on July 23, 2024

I have just confirmed that re-adding these lines to src/adapters/mongoose.js fixes this issue in 7.8.3, but presumably it was removed to fix another issue?

if (fieldInfo.enum && fieldInfo.enum.length) {
  field.enums = fieldInfo.enum;
}

from forest-express-mongoose.

jeffladiray avatar jeffladiray commented on July 23, 2024

Hey @AlexAVL,
Looks like I'm the culprit here 😅

I'll take a look in our issue tracker to refresh my memory, but I remember that this small changes was actually a long term discussion.

While I'm looking for a deeper analysis of this issue, would you mind testing with the condition mentionned in the PR and tell me if it actually works on your end?

(fieldInfo.enum
        && Array.isArray(fieldInfo.enum)
        && fieldInfo.enumValues.length)

Thanks in advance

(As a side note, I also suggest you to open a ticket on our discourse community (Here) next time, we're more active there 🙌 )

from forest-express-mongoose.

AlexAVL avatar AlexAVL commented on July 23, 2024

Hi @jeffladiray,

Thanks for the quick response, and I'll remember Discourse for next time.

That snippet didn't quite work, because enumValues is not defined and trying to get a length for it throws an error. I guessed it might be a typo, and trying this one did work just fine:

if (fieldInfo.enum
  && Array.isArray(fieldInfo.enum)
  && fieldInfo.enum.length) {
  field.enums = fieldInfo.enum;
}

After adding that the values are in the forestadmin-schema.json and the UI works again.

The code that creates the mongoose schema and creates this situation is approximately this:

const possibleValues = ['value1', 'value2'];
const defaultValue = 'value1';

const configSchema = new mongoose.Schema(
  {
    subFieldName: {
      type: String,
      enum: possibleValues,
      default: defaultValue,
    },
  },
  { _id: false },
);

const itemSchema = new mongoose.Schema(
  {
    configuration: configSchema,
  },
  {
    timestamps: true,
  },
);

Thanks for your help with this.

from forest-express-mongoose.

forest-bot avatar forest-bot commented on July 23, 2024

🎉 This issue has been resolved in version 7.8.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

from forest-express-mongoose.

jeffladiray avatar jeffladiray commented on July 23, 2024

The fix is released. Let me know if you're still experiencing the issue 👍

from forest-express-mongoose.

forest-bot avatar forest-bot commented on July 23, 2024

🎉 This issue has been resolved in version 8.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

from forest-express-mongoose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.