GithubHelp home page GithubHelp logo

Comments (7)

penfold42 avatar penfold42 commented on June 5, 2024

A bit of both - if you edit the host name it triggers a field validation that enables the save button

from espixelstick.

forkineye avatar forkineye commented on June 5, 2024

@patdelaney By not allowed to save, do you mean the button being disabled? The page now does hostname validation, so if you have a hostname with invalid characters the save button will be disabled.

from espixelstick.

penfold42 avatar penfold42 commented on June 5, 2024

There's a bug here - the button is disabled by default even if a valid host name is already present.

If I just want to change the SSID, I still need to make a tiny edit to the host name to enable the button

from espixelstick.

forkineye avatar forkineye commented on June 5, 2024

@penfold42 Ah, thanks! I'll fix it next time I get a chance to work on the code

from espixelstick.

penfold42 avatar penfold42 commented on June 5, 2024

I can probably do it - I'll add validation for ssid and key too

from espixelstick.

penfold42 avatar penfold42 commented on June 5, 2024

I can confirm #58 fixes this

from espixelstick.

forkineye avatar forkineye commented on June 5, 2024

@penfold42 Thanks! I'll merge the PR's this weekend if not sooner.

from espixelstick.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.