fornewid / placeholder

Placeholder for Jetpack Compose ⏳

Hi there 👋

placeholder's Issues

Placeholder seems to extend to other elements

Describe the bug

It seems that placeholder also applies to other elements (I don't know why), where it isn't applied.

To Reproduce

I don't know exactly how to reproduce it, but the project in the recording below is this one: https://github.com/maicol07/GameLibrary

Expected behavior

Placeholder is only applied to elements where the modifier is applied

Screenshots

Example (see the home navbar item and the FAB when seeing a game):
https://github.com/fornewid/placeholder/assets/9463142/fda2efe2-4f6a-4216-96fd-9be6ff38124b

Environment

• Android OS version: Android 13
• Device: Zenfone 8 Flip
• material-motion-compose version: Not used

Rename release on github to align with version name on maven

Hi! Thanks for extracting this as a separate library!

While migrating I struggled to resolve the dependencies, and it was only when I opened the maven source (https://mvnrepository.com/artifact/io.github.fornewid/placeholder-material) that I noticed that I should use 1.0.0-rc as version code instead of v1.0.0-rc which is the name of the release here on github (https://github.com/fornewid/placeholder/releases). Also the badge in the readme has the v prefix. It would be very helpful if these aligned with the version published to maven. Thanks!

Allow to set only one placeholder for container

Hi,
can you add support for containers composables (like Columns)?
Currently, placeholdering a column means applying a placeholder to the entire column block (and results in a single placeholder block) and it doesn't show what's inside (due to this, placeholder must be applied to every child element). It would be great if the shimmer applied to an element would understand what are their children and apply it to them
There is another shimmer library which does it successfully, but it doesn't provide all the effects your library has: https://github.com/ValeryPonomarenko/compose-shimmer
Thanks!