founddrama / bjcp-viewer Goto Github PK

Consider adding the local/regional specialty styles to the web app

Example: <impression> element should be "first" (after any optional <preamble>) on any given style node like how the styles are otherwise presented in the BJCP source material.

Steps to reproduce

1. Load web app at https://founddrama.github.io/bjcp-viewer/
2. Select any style (e.g., 4A)

• Expectation: https://founddrama.github.io/bjcp-viewer/4A
• Actual: https://founddrama.github.io/4A

Reason this is a problem

"Deep link" of https://founddrama.github.io/4A won't work!

Follow-up to #3

Consider re-factoring this history listener in StyleGuideApp such that it does not depend on location.keys. This would open up the ability to conditionally use HashRouter and support deep-links on the gh-pages deployment.

Examples:

• 9A. Doppelbock (Pale + Dark examples)
• 20C. Imperial Stout (American + English examples)

Similar support was added for #9 ... Could likely use that as the basis for this.

Mostly re: annotations in the vital stats block (e.g., "OG: varies with base style, typically above-average")

Related to #8

Also seems like #9 might generate a generalized solution for all three issues

RE: table vs. standard vs. super strengths and pale vs. dark variants -- find a way to work in the varying bands for SRM, OG, FG, and ABV. Likely to mean a change in the XML format, and then the XML-to-JSON converter ... and then also to the view layer.

Relates to #8

RE: "(varies w/ fruit)" annotation in vital stats block. Find a way to incorporate the annotation somehow.