foundersandcoders / css-gallery-challenge Goto Github PK

What do you reckon about adding a brief explanation comment in the solution about the "font-size: 0" added to the gallery class?

It could include a link, e.g. https://css-tricks.com/fighting-the-space-between-inline-block-elements/

Please comment the exercise number 3 solution based on the pseudo element :before and :after.
Introduce a more economical solution based on background repeat.

Hey @njsfield Is the reference to brackets just a personal preference in terms of text editors? Or is there something in the challenge that makes brackets preferable?

If students don't already have it installed, they may end up spending a portion of this hour downloading something new, because they think they need it.

I don't really know anything about brackets. If it's particularly good, maybe you want to raise an issue in master-reference suggesting that we add it to the installation list? 🤷‍♀️ Just a suggestion.

Please fix a typo in index.html file (or altenatively rename the normalize.css file).
CSS link to normalize.css file is spelled normalise.css.

option 2 (active maintainer) chosen by @njsfield

Clone instructions point to njsfield's old repo url. This needs to be updated with the new url under fac's org.

The reference to njsfield being a maintainer can also be removed.

I think it will be very good if the students can get an introduction on why they need to plan theitr websites "mobile first" (better practice, most of the browsing will be done from mobiles, etc.), and the importance of the <meta name="viewport" content="width=device-width" initial-scale="1"> line in the html file @njsfield, please if you agree, let me know if you want to make the relavant changes or ask me to make a PR.

Needs to be
git clone https://github.com/njsfield/css-gallery-challenge
otherwise encounter auth problem

Move solutions and hints from branches to a new directory on master