foundry-rs / forge-template Goto Github PK

Hey guys,

Thanks for putting this together. I'm new to dapptools and this is a great starting point. I'm having some issues deploying to a remote node though. I run deploy like

ETH_FROM=0x35754fd45136f2a9996a75cf2955315c9cd35054 make deploy-rinkeby

Locally I get:

--rpc-url https://eth-rinkeby.alchemyapi.io/v2/***
curl: (22) The requested URL returned error: 400

On Alchemy it shows the failed request:

{"jsonrpc": "2.0", "id": 1, "error": {"code": -32601, "message": "Unsupported method: eth_sendTransaction. Alchemy does not hold users' private keys. See available methods at https://docs.alchemy.com/alchemy/documentation/apis"}}

Any ideas what I might be doing wrong? I imported the account using ethsign.

As another note: When I run ethsign it lists an account but the address is different from MM. I tried reimporting for sanity and it says the account already exists. I guess it is using a different derivation path? I tried using that address as from but it fails too.

The forge submodule is fixed at commit 40977d9 which is quite old, features are missing and it does not match with the current documentation out of the box.

Can be fixed using git submodule update --remote --merge, adding this command to the readme could be useful

@gg2001 introduced scripts to check for pettier and solhint conformance in #19, we should add them as steps to CI so they get run automatically

Running into this error when trying to install

curl https://dapp.tools/install | sh

Package ‘ghc-8.10.4’ in /nix/store/xxx-nixpkgs-release-21.05/pkgs/development/compilers/ghc/8.10.4.nix:254 is not supported on ‘aarch64-darwin’, refusing to evaluate.

If I'm understanding it correctly, GreeterTest is never actually instantiated, it's only being inherited by the contracts in the .t.sol files

As-is the directory structure means that the VS Code solidity plugin can't find any open zeppelin contracts:

After moving (see below) all checks out.

git mv lib/openzeppelin-contracts lib/@openzeppelin

If you don't compile before you deploy, the ABI in common.sh will be null, and result in an error. I think ideally the common.sh would have a function to check to see if the file has already been compiled... or it just always compiles before it tries to deploy.

Right now, this template works great if you just want to deploy 1 contract. However, a lot of people would be interested in deploying many contracts. For example:

Per the README.md

Contracts can be deployed via the make deploy command. Addresses are automatically written in a name-address json file stored under out/addresses.json.

If I have two files that I deploy, they will be overwritten on subsequent deployments. Additionally, the deploy scripts really only work with one contract.

Love the project, hopefully these are good bits of feedback.

I'm running a fully shell script that calls the uniswap address with some custom transaction data. It crashes, so I put a seth call --debug $unicontract $unicalldata. Now, it says 'hevm: @openzeppelin/contracts/drafts/IERC20Permit.sol: openBinaryFile: does not exist (No such file or directory)'. Any idea why this happens? I grabbed a generic IERC20Permit.sol off github and stuck it in that directory under node_modules, but no beans.

GasNow is shutting down on October 18th, we need to find another gas price API before then to prevent estimate_gas from breaking :/

Hello, I've been working on a new test implementation and every time I try to run make test, this is the error result I'm given:

dapp test # --ffi # enable if you need the ffi cheat code on HEVM
dapp---use: Could not find solc-0.8.7 in your path or nix store.
Temporarily installing solc-0.8.7...
Tip: run nix-env -f https://github.com/dapphub/dapptools/archive/master.tar.gz -iA solc-static-versions.solc_0_8_7 for a lasting installation of this version.
error: could not set permissions on '/nix/var/nix/profiles/per-user' to 755: Operation not permitted
make: *** [test] Error 1

I've tried using chmod to change the permissions on the /nix directory myself, but it doesn't seem to work. Perhaps this issue is simply on my end and has nothing to do with this template, but I thought I'd post here to see if anyone has any ideas anyways.