franzen / babelphish Goto Github PK

like string, binary, list and map (maybe some more that I forgot).

Boolean default value failed for divine in ruby. I had to fix it (6373edb) for ruby, but since it wasn't covered by the test suite, I guess it still can be a problem in other places. Also make sure we have at least one instance of each possible type in the tests.

In Generated Java File:

• Neet to import:
  • java.io.ByteArrayInputStream
  • java.io.ByteArrayOutputStream
  • java.io.IOException
  • java.nio.charset.Charset
  • java.util.ArrayList
  • java.util.HashMap
• In writeInt32: 0xFFFFFFFF needs to be 0xFFFFFFFFL
  • 0xFFFFFFFF = -1 while 0xFFFFFFFFL = 4.294.967.29 "Max Value"
• In writeIpNumber:
  • split(".") needs to be split(".") because split function takes (String regex)
  • Need check of if v.equals("")
    • Integer.parseInt(bs[i]) raise error because of bs contains empty value. (bs = [""])
• In writeBinary: 0xFFFFFFFF needs to be 0xFFFFFFFFL
• In readBinary:
  • "return readBytes((int) readInt32(data), data)" raise error because of readInt32(data) = -1 "EOF",
    it needs to be "return readBytes((int) c, data)"

In Generated Ruby File:

• In write_binary: it takes either list or string while read_binary always return string.