Two presses of RCtrl key causes FreeRDP window to lose focus, even when separated by other key presses about freerdp

[akallabeth]

@bebras123 to set right control as hotkey (and automatically ungrab if no other shortcut is pressed)

{
    "SDL_KeyModMask": ["KMOD_RCTRL"],
    "SDL_Grab": "SDL_SCANCODE_RCTRL"
 }

[akallabeth]

right control is the ungrab key so this is expected.

[whitpa]

That behavior is not documented anywhere, as far as I can tell. It's also weird - why does it have to be pressed twice, and why not as a double-tap only?

Regardless, this behavior is unwanted by one of our customers. How can it be turned off (without source code modification, or ugly hacks such as xmodmap)? I don't see any related command line switch.

[akallabeth]

@whitpa yes, documentation always needs improvement :/
as for the hitting twice, that is indeed a bug, should be at first press/release

there is also currently no configuration for this (only had time to add a config file for sdl-client)

[akallabeth]

ok, added manpage/help text for xfreerdp for keyboard shortcut handling.
also fixed the twice thing.

[bebras123]

Hi, after this fix RCtrl does not ungrab anymore. Do i have to create some configuration at
/home/username/.var/app/com.freerdp.FreeRDP/config/FreeRDP/FreeRDP/sdl-freerdp.json to make ungrab work with RCtrl?
If so example would be nice as there is no sdl-freerdp.json file in the provided path.

I am running freerdp flatpak run com.freerdp.FreeRDP /u:xxx /v:xxx /f /clipboard +auto-reconnect /log-level:DEBUG
Version 3.4.0, Linux Mint 21.3, x11, Cinnamon 6.0.4

[akallabeth]

@bebras123 this bug was for xfreerdp and you are using sdl-freerdp.
read the help text or manpage of sdl-freerdp for keyboard shortcuts.

[bebras123]

@akallabeth, huge thanks, provided configuration works as I want