freifunkbremen / meshviewer Goto Github PK

5 Ghz, 2.4 Ghz, Lan

Köpfe rollen lassen

Expected Behavior

When one or both nodes from a link have been filtered either by the nodes or the statistics I would expect the link to disappear as well.

Current Behavior

In Bremen the links don't disappear when one or both nodes have been filtered which makes for a very weird picture when most nodes have been hidden.
Only applies to the Bremen setup. Regensburg is not affected.

Steps to Reproduce (for bugs)

1. open map
2. go to statistics tab or use the node filter
3. apply a filter which only affects one side/node of a link AND not the links itself (online/offline)
4. watch buggy magic

Bei den Node-Infos [1] haben wir Direktlinks zu Grafana, weil die Diagramme langsamer (oder garnicht) laden.
Das Gleiche hätte ich gerne bei den Link-Infos [2].

[1] https://map.bremen.freifunk.net/#!/en/map/ec086bf8fa6c
[2] https://map.bremen.freifunk.net/#!/en/map/ec086bf8fa6c-a42bb0b0f1ae

The FFHB Meshviewer currently reads data from nodes.json from statistics.clients.wifi24 element etc. to display the client types in more detail. However, this breaks other consumers of the nodes.json file; for example http://freifunk-karte.de expects statistics.clients to be an integer. There might be other consumers which cannot cope with this modified nodes.json either (eg. https://play.google.com/store/apps/details?id=de.appwerft.freifunker).

To solve this, I suggest that the Meshviewer first tries to read these per-type details from a different element, for example from statistics.clients_by_type.wifi24 etc.
Then the nodes.json could be generated to contain a the total number of clients in statistics.clients and the details below statistics.clients_by_type. The file would then remain compatible at least with freifunk-karte.de.

This would of course also require changes in the nodes.json generator process (yanic?).

Also, with this change the Meshviewer would be able to support the FFHB nodes.json and the FFRGB nodes.json; so I guess the code could be upstreamed then.