frisoft / ateam

frisoft

Frisoft website

ateam's Issues

Enable --include-reviewed-by-me automatically when --only-mine is used

When I need to see only my PRs, I don't want to exclude the ones I auto-reviewed.

Problem with getting authors

After running:

RUST_BACKTRACE=1 ateam pr --org... --blame --tests-regex ... --label ... --regex-not ... --exclude-label ...

Got this error:

thread '<unnamed>' panicked at 'Can't get the authors for PROJECT_FILE, src/client/blame.rs:26:27
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

I get this error time to time for always different files.

I collected full backtrace but I think it can't help (RUST_BACKTRACE=full):

thread '<unnamed>' panicked at 'Can't get the authors for PROJECT_FILE', src/client/blame.rs:26:27
stack backtrace:
   0:        0x10307cc54 - __mh_execute_header
   1:        0x10309affe - __mh_execute_header
   2:        0x103076056 - __mh_execute_header
   3:        0x10307ecd9 - __mh_execute_header
   4:        0x10307e7c0 - __mh_execute_header
   5:        0x10307f345 - __mh_execute_header
   6:        0x10307ee85 - __mh_execute_header
   7:        0x10307d0b8 - __mh_execute_header
   8:        0x10307edea - __mh_execute_header
   9:        0x1030b1c8b - __mh_execute_header
  10:        0x102d8d6d6 - __mh_execute_header
  11:        0x102da8ac6 - __mh_execute_header
  12:        0x102d897df - __mh_execute_header
  13:        0x102da276c - __mh_execute_header
  14:        0x102da8bd0 - __mh_execute_header
  15:        0x102da2710 - __mh_execute_header
  16:        0x102da8bd0 - __mh_execute_header
  17:        0x102da94cf - __mh_execute_header
  18:        0x102db99ea - __mh_execute_header
  19:        0x102d928d3 - __mh_execute_header
  20:        0x102dd0ad4 - __mh_execute_header
  21:        0x102d9ab68 - __mh_execute_header
  22:        0x102dd317a - __mh_execute_header
  23:        0x102da8d64 - __mh_execute_header
  24:        0x102da1e68 - __mh_execute_header
  25:        0x102da90e9 - __mh_execute_header
  26:        0x102da1e68 - __mh_execute_header
  27:        0x102da90e9 - __mh_execute_header
  28:        0x102dbba7c - __mh_execute_header
  29:        0x102d92019 - __mh_execute_header
  30:        0x1030ad8cf - __mh_execute_header
  31:        0x103016081 - __mh_execute_header
  32:        0x1030188e3 - __mh_execute_header
  33:        0x103018fb9 - __mh_execute_header
  34:        0x1030855ed - __mh_execute_header
  35:     0x7fff204638fc - __pthread_start

Wrong approvals count

Sometimes it does not count some approvals.

Missing newline after output

Add --requested option

--requested => --query 'review-requested:yourusername'

Also, the "requested" PRs should increase the score.

Simplify GH query

When the query string is too complex, GH returns an empty list, probably just because an internal time out is triggered. GH bug?

A workaround is avoiding conditions like the following in the query string:
-author:frisoft
-reviewed-by:frisoft

The conditions may be replaced by a post query filter on the resulting list of PRs.

Replace discontinued failure crate with anyhow

Replace discontinued failure crate with anyhow: https://github.com/dtolnay/anyhow

Missing version info

Check token and organisation access

If the GH token is expired the error is not clear: "missing response data".

Unfortunately, GH does not return any specific error if the token is expired or invalid. However, I could at least add some other text:
"Missing response data. Check your Github token".

Also, if the token is valid but not authorised by an organisation, GH does not return any result. No error is reported.
I may introduce a step to access some organisation details (org name from --org or --repo) to verify there is a proper authorisation.

PAT potentially not authorized

If ateam works but it constantly returns table with no results, it might be because we did not authorize with our organization as shown in image above. If there is not result, rather then printing empty table, we should show text saying something like "No results(check if you organised your PAT with organization.)"

Better helper

The -h does not give any description of the pr and followup subcommand. It should.