frsource / light-scrollbar Goto Github PK

Hi Szymon, 👋 Phrase sends regards. We ran into minor bug with scrollbar.

Describe the bug
When user clicks on scrollbar ( or grab it and scroll with it ) and then release mouse, scrollbar stays active, so when user tries to select text in different element the scroll follows mouse move. Video should describe it better - https://share.getcloudapp.com/4gu4drPW

To Reproduce
Steps to reproduce the behavior:

1. Go to the example page https://www.frsource.org/light-scrollbar/examples/default.html
2. Click on scrollbar once ( or grab and scroll with it )
3. Try to select text in sidebar

Expected behavior
Content in attached container is scrolled

Screenshots
Content in attached container is no affected by mouse interactions outside of container

Please complete the following information:

• Version - latest - 1.4.14
• Browser - Chrome

Additional context
I tried to fix it by changing line 396 from

outerElement.addEventListener("click", clickHandler);

to

outerElement.addEventListener("mousedown", clickHandler);
outerElement.addEventListener("mouseup", mouseUpHandler);

I hoped it would help as click event fires after mouseup, but it helped only partially. For some reason y-axis scrollbar was more responsive to this change, but x-axis didn't change it behavior at all, especially when I tried to select text under the attached element ( before mount, after mount sections )

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• chore(deps): update cypress-io/github-action digest to 307a235
• fix(deps): update dependency @frsource/frs-hide-scrollbar to v2.0.14

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Hi Szymon, me again 👋

Describe the bug
Scrollbar calculates --ls-bar-y-top variable wrong when it has a lot of content.

To Reproduce
Steps to reproduce the behavior:

1. In docs, click on Add Dynamically item button at least 70 times ( a bit masochistic approach 😄 ) or just add v-for with at least 100 elements in scrollbarTemplate.vue - <span v-for="it in 100" :key="it">Some Content<br/></span>
2. Look at both examples - inner and outside
3. Scrollbar is positioned higher than container

Expected behavior
Scrollbar is positioned at container top and doesn't go higher

Screenshots

Please complete the following information:

• Happens in Ubuntu and Mac ( probably Win too )
• All browsers