fullchee / courseography

Courseography is a tool created by David Liu and Ian Stewart-Binks to guide students through their undergraduate careers.

Hi! I'm Fullchee! 👋

(pronounced Full of Cheese 🧀)

💼   I work with React and Django at Forma.ai in Toronto 🇨🇦

At Forma.ai, I:

• build React dashboards
  • so sales reps know how much they get paid and why
• write SQL queries from business logic
• develop on a Django backend to send data to the frontend

I've taken the lead in building up our company's Storybook to boost dev productivity.

💻   I like building apps with TypeScript, React, Node.js, Python and Postgres!

• Porfolio
• Email 📧
• LinkedIn
• Resume

courseography's Issues

Pressing the Info Box: When do I need to add H1 to the end

In setupTests.js

This works

fetchMock.get('/course?name=aaa100', aaa100CourseInfo);

But this doesn't

fetchMock.get('/course?name=aaa100H1', aaa100CourseInfo);

PR: fake-course-info

make sure that the updated info is good

waiting for the updated infobox tests

Refactor setupGraph to TestGraph

Waiting for node-tests to be merged in

Figure out why the bool was okay even though the localStorage was set

Snapshot test for Hybrid Node

In Node.test.js, I am having difficulty setting up a snapshot test.

I have decided to put this on hold since the node props will likely be different after the refactoring phase for the react-draw tool.

I get the following error

    TypeError: Cannot read property 'current' of undefined

      43 |           console.log(svg.nodes)
      44 |         }
    > 45 |         if (svg.nodes.current[element] !== undefined) {
         |                       ^
      46 |           return svg.nodes.current[element].isSelected();
      47 |         } else if (svg.bools.current[element] !== undefined) {
      48 |           return svg.bools.current[element].isSelected();

      at current (js/components/graph/Node.js:45:23)

Here are my current node props that I copied from

it("should match shallow snapshot", () => {
const nodeProps = {
      "JSON": {
        "graph": 1,
        "height": 24,
        "type_": "Hybrid",
        "text": [{
          "graph": 1,
          "rId": "text103",
          "text": "(H101)",
          "pos": [596.555968, 59.379107999999995],
          "fill": "",
          "align": "begin"
        }],
        "width": 52.768799,
        "stroke": "",
        "pos": [600.585648, 41.51310800000002],
        "fill": "#888888",
        "id_": "h108"
      },
      "className": "hybrid",
      "hybrid": true,
      "parents": ["aaa101"],
      "childs": ["aaa201"],
      "inEdges": [],
      "outEdges": ["p6"],
      "svg": {
        "props": {
          "start_blank": false,
          "edit": false,
          "initialDrawMode": "draw-node"
        },
        "context": {},
        "refs": {},
        "updater": {},
        "state": {
          "labelsJSON": [],
          "regionsJSON": [],
          "nodesJSON": [{
            "graph": 1,
            "height": 30,
            "type_": "Node",
            "text": [{
              "graph": 1,
              "rId": "text102",
              "text": "AAA101",
              "pos": [596.555968, 25.379107999999995],
              "fill": "",
              "align": "begin"
            }, {
              "graph": 1,
              "rId": "text103",
              "text": "(H101)",
              "pos": [596.555968, 34.379107999999995],
              "fill": "",
              "align": "begin"
            }],
            "width": 65,
            "stroke": "",
            "pos": [594.294128, 10.09390799999999],
            "fill": "#5dd5b8",
            "id_": "aaa101"
          }],
          "edgesJSON": [],
          "highlightedNodes": [],
          "timeouts": [],
          "fceCount": 0,
          "width": 1217.9941,
          "height": 646.78271,
          "zoomFactor": 1,
          "horizontalPanFactor": 0,
          "verticalPanFactor": 0,
          "mouseDown": false,
          "buttonHover": false,
          "onDraw": false,
          "drawMode": "draw-node",
          "drawNodeID": 0,
          "draggingNode": null
        }
      }
    };
const wrapper = shallow(<Node {...nodeProps} />);
    expect(wrapper).toMatchSnapshot();

What really connects a Hybrid Node and the associated node?

testData.js

In shapes

Test out `jest.advancetimersbytime`

This will be useful in the infobox.

It'll also remove any issues if you end a test with a mouseOut event

Accessing undeclared variables in graph?

Refactor Course.js out of the public folder

• Need to understand how Webpack works

🐞BUG: Clicking and switching between graphs crashes the graph

cannot read property isSelected

PR: Fake Course Info - Update test data

Waiting for the PRs to subside for Courseography.

PR: Remove async from describe blocks

A result of a misunderstanding.

Why this PR

describe blocks don't need to be async

Jest will fail async describe blocks in the future.

https://github.com/Courseography/courseography/compare/master...Fullchee:rm-async-describe?expand=1

Edge Tests

Merge my edge tests.

Document what 'active', 'overridden', 'inactive' mean visually

Active

Inactive

Missing

Overridden

Hovering over

Git Bisect and find the commit that introduced this in the info box

Appears when you click on the info box.

Uncaught (in promise) TypeError: Cannot read property 'sort' of undefined
    at app.js:26489

Bug in Search, it won't search and it crashes in search.js.jsx

it crashes on the course.fallSession which is undefined

InfoBox Tests

import fetchMock from "fetch-mock";
import testData from "./__mocks__/testData";
import aaa100CourseInfo from './__mocks__/aaa100-course-info.js';

fetchMock.get(
  "http://localhost:8000/get-json-data?graphName=Computer+Science",
  testData
);
fetchMock.get("http://localhost/course?name=aaa100", aaa100CourseInfo);
fetchMock.get("/course?name=aaa100", aaa100CourseInfo);