fullstackhero / docs Goto Github PK

on running the command
dotnet ef migrations add "brand_extend" --project ./src/Migrators/Migrators.PostgreSQL/ --context ApplicationDbContext -o Migrations/Application

return error
Unable to create an object of type 'ApplicationDbContext'. For the different patterns supported at design time, see https://go.microsoft.com/fwlink/?linkid=851728

the command provided in documentation
dotnet ef migrations add "brand_extend" --project .././Migrators/Migrators.PostgreSQL/ --context ApplicationDbContext -o Migrations/Application

returns
No project was found in directory '.././Migrators/Migrators.PostgreSQL/'.

is that a known bug
I am trying to use this template for my MVP
Please help me if I am doing something wrong
thanks

The readme of this project says to create a GT_TOKEN secret, but I actually just did a pull request without doing that.

That probably shouldn't be in the readme, or otherwise the readme should also explain why exactly this is necessary.

Hi, first of all, great project!

When I found it I was interested on how you integrated .NET Core identity into it but I got confused. Hope you can clarify my doubts. I can see you have in the migration files

modelBuilder.Entity("FSH.WebApi.Infrastructure.Identity.ApplicationRole", b =>
                {
                    b.Property<string>("Id")
                        .HasColumnType("nvarchar(450)");

                    ...

                    b.Property<string>("TenantId")
                        .IsRequired()
                        .HasMaxLength(64)
                        .HasColumnType("nvarchar(64)");

                    b.HasKey("Id");

                    b.HasIndex("NormalizedName", "TenantId")
                        .IsUnique()
                        .HasDatabaseName("RoleNameIndex")
                        .HasFilter("[NormalizedName] IS NOT NULL");

                   ...

but you haven't added any additional properties to ApplicationRole or any other classes

public ApplicationRole(string roleName, string? description = null)
        : base(roleName)
    {
        Description = description;
        NormalizedName = roleName.ToUpperInvariant();
    }

So my question is, did you generate the migration files manually? How is TenantId appearing in the ApplicationRole entity? If yes, why didn't you customize Identity classes to receive these new properties?

My other question is, do all Identity User and Role methods work taking into account the TenantId? I'm asking this because I didn't find any UserStore or RoleStore customizations to deal with this property with CRUD operations.

Thank you and please keep up with this project!

on the project structure page it is stated that

Note that the Application project does not depend on any other project.
...
Note that the Domain project does not depend on any other project.

I would assume that to be true for the domain but maybe not so much for the application project

Checking the actual source code for the application.csproj seems to imply that the application actually depends on domain as expected

    <ItemGroup>
        <ProjectReference Include="..\Domain\Domain.csproj" />
        <ProjectReference Include="..\Shared\Shared.csproj" />
    </ItemGroup>

The documentation on project structure refers to the Core/Application project as having no dependencies.

Note that the Application project does not depend on any other project.

This is no longer a true statement.

Looking at Application.csproj:

<ItemGroup>
    <ProjectReference Include="..\..\Core\Domain\Domain.csproj" />
    <ProjectReference Include="..\..\Shared\Shared.DTOs\Shared.DTOs.csproj" />
</ItemGroup>

But also we see the dependency in the interfaces of the services in the Application project. For example, in the IBrandService.cs interface

public interface IBrandService : ITransientService
{
    Task<PaginatedResult<BrandDto>> SearchAsync(BrandListFilter filter);
    // ...
}

the argument and template type in the returned object are from the shared project.

I feel this is important for new comers to know and understand why this dependency exists. For instance, I found it a little confusing as to why services in the application layer are returning DTO types, and not Domain types.

Updating the documentation to reflect the current state of the template and extending the rationale for these choices would be super helpful and appreciated!!!