futuredapp / funtastykit

A collection of Swift utilities and protocols used in our projects

FuntastyKit

The FuntastyKit for iOS contains:

• MVVM-C architecture used at Futured, the template for this architecture can be found at https://github.com/futuredapp/MVVM-C-Templates.
• Some regularly used UIKit extensions.
• Protocols for simple initialization from XIB files, storyboards and for handling keyboard.
• Hairline constraint for one-pixel designs.

Installation

If you want to use CocoaPods for dependency management, add following line to your Podfile:

pod 'FuntastyKit', '~> 2.3'

If you also want to use IBInspectable extensions also add:

pod 'FuntastyKit', '~> 2.3', subspecs: ['IBInspectable']

When using Swift package manager add following line to your Package.swift file or add the repository using Xcode:

.package(url: "https://github.com/futuredapp/FuntastyKit.git", from: "2.3.0")

Note on the name

The name of the framework comes from the name of our company before rebranding, Funtasty. Now, we are called Futured, but FuturedKit will be very probably based on SwiftUI instead of UIKit.

Contributors

If you have any questions or issues, please contact the current maintainer:

• Matěj K. Jirásek, [email protected]

Over the years many inside and outside contributors made improvements to this library, namely:

• Petr Zvoníček
• Matěj K. Jirásek
• Patrik Potoček
• Roman Podymov
• Radek Doležal
• Tomáš Babulák
• Mikoláš Stuchlík
• Marek Staňa
• Martin Pinka
• Adam Salih
• Adam Bezák

License

FuntastyKit is available under the MIT license. See the LICENSE file for more info.

funtastykit's Issues

Remove unused push modal template

Promising coordinator

We have several implementation of guaranteeing/promising cvoordinator which is returning value during stop.

A subspec with dependency on PromiseKit was proposed and I personally agree this is a good idea and could help to add more PromiseKit related architecture components to FuntastyKit.

Example implementation on which can we build upon can be taken from here:

https://github.com/thefuntasty/kartel-ios/pull/40

Show view controller memory leak

Show view controller, when used in split view controller, causes memory leak due to strong reference between sourceViewController (UIViewController) of detail view controller and viewController (UISplitViewController) of master view controller.

Fix Swift package manager support for Xcode 11

Wrong keyboard handling

KeyboardHeightConstraint is controlled only by notifications .UIKeyboardWillHide and .UIKeyboardWillShow which is not enough. Keyboard can change its height without show/hide (eg. when you switch to emoji keyboard or any custom keyboard).

It's better to use .UIKeyboardWillChangeFrame

Potential reference cycle in PushCoordinator

In few our projects we noticed whole VC hierarchies can leak.

Typical use-case is when we want to change full hierarchy/window (deep link etc.) If all the push coordinators aren't popped then the navigation controller with whole stack of pushed view controllers is leaked.

We should make the navigation controller on push coordinator weak. Be aware, it is breaking change.

Divide this library into two

Separate this library into:

• ArchitectureKit
• UIKit

Add subspec for IBInspectable

IBInspectable extensions are crashing Interface builder. A proposed solution is to add a subspec for the extensions so it is easy to disable them.

Constraints provided only work when used from interface builder

We need to use different mechanism than awakeFromNib to make them work when used when using auto-layout from code.

Add .swiftlint.yml

@mkj-is please add a .swiftlint.yml file with some reasonable configuration.

Deprecate current version of ServiceHolder

We currently do not prefer using service holder provided in FuntastyKit and use simple struct or final class instead. We could deprecate or even remove the ServiceHolder in the next release.

Update Readme

Guidelines: https://www.notion.so/futured/Open-source-de0c451bc858458d8e26c2b968514642