GithubHelp home page GithubHelp logo

Comments (3)

fxn avatar fxn commented on August 28, 2024

Hey!

I don't fully understand the situation. Let me ask you some questions.

I understand from the description that dor-services-client uses Zeitwerk, and dor-services does not. I also understand that dor-services depends on dor-services-client. So, at some point dor-services performs a require of some file from dor-services-client that defines its loader. Is that all right?

If yes, I do not get why the configured loader above has a root directory .../sul-dlss/dor-services/lib. That directory does not seem right for dor-services-client. Which is the explanation for that?

Can you also share the source code that instantiates and configures the Zeitwerk loader, and where is it located?

from zeitwerk.

jcoyne avatar jcoyne commented on August 28, 2024

I think the problem was that we made our lib a relative require by zeitwerk. Making it an absolute path seems to have fixed the issue: https://github.com/sul-dlss/dor-services-client/pull/65/files

from zeitwerk.

fxn avatar fxn commented on August 28, 2024

Oh yes, that is something to be careful about in gems.

Glad you found it.

from zeitwerk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.