fynnschapdick / contactbook Goto Github PK

Hi Fynn,

I noticed you are using my PhoneNumber library in your project and just thought it might be useful to mention something based upon how you are using it.

In CreateContactRequestValidator, whilst you are checking that the input can be parsed, it doesn’t necessarily mean the input (which you currently store in the Contact) is in exactly E.164 format as the parsing will ignore formatting and also parses inputs using the RFC3966 format so you might want to consider running the input through the parse method and actually storing the result of PhoneNumber.Parse(mobile).ToString() when you create the contact record.

If you test with the following inputs you will see what I mean:

Submitting +492111234567 will succeed per your existing test and result in +492111234567 being saved but the following will also succeed but result in the raw input being stored +49-211-1234567 and tel:+49-211-1234567.