g-truc / website Goto Github PK

Item 12 says this about OpenGL error handling:

However, OpenGL doesn’t guarantee the implementation behavior after an error.

From OpenGL 4.5, folio page 16:

Currently, when an error flag is set, results of GL operation are undefined only if an OUT_OF_MEMORY error has occurred. In other cases, there are no side effects unless otherwise noted; the command which generates the error is ignored so that it has no effect on GL state or framebuffer contents. Except as otherwise noted, if the generating command returns a value, it returns zero. If the generating command modifies values through a pointer argument, no change is made to these values.

The same text appears in both OpenGL ES 2.0 and desktop OpenGL 2.0. Commands that generate most errors have well-defined behavior in pretty much every version of OpenGL.

These are editorial issues with your Effective OpenGL document. Grammar, spelling, wording, that sort of thing.

• The PDF lacks a proper table of contents. That is, the kind you can bring up on the side in a PDF viewer. Also, the built-in TOC has no links to the specific locations.

• There appear to be many links in the document, but none of them actually work in the PDF viewer.

• [x]

  such as Playstation libgnm

  I believe you meant "libgcm".

• [x]

  so why not using OpenGL like a

  Consider "so why not use OpenGL..."

• [x]

  Alternatively, OpenGL 3.3, GL_ARB_texture_swizzle and GL_EXT_texture_swizzle provides a slightly different approach allowing to setup all components at once as shown in listing 2.2.

  The "allowing to setup" phrasing is a bit awkward, and "provides" should be singular. Consider rephrasing as follows:

  Alternatively, OpenGL 3.3, GL_ARB_texture_swizzle and GL_EXT_texture_swizzle provide another means to setup all components at once as shown in listing 2.2.

• [x]

  In this section, we call a texture alpha, a single component texture which data is accessed in the shader with the alpha channel (.a, .w, .q).

  Consider rephrasing this as follows:

  In this section, let the term "texture alpha" refer to a single component texture whose data in the shader comes only from the alpha channel (.a, .w, .q).

• [x]

  sRGB  textures  have  been  introduced  to  OpenGL...

  With  OpenGL  ES,  it  has  been  introduced  with...

  The "have/has been introduced" phrasing is inconsistent with prior statements, and it is somewhat awkward besides. It would be better to say that it "was introduced", as prior sections do.

• [x]

  the  none  linear  property

  Your probably meant "the non-linear property".

• [x]

  This  is  the  case  for  BPTC,  ASTC  or ETC2  however  for  older  compression  formats,  the  situation  is  more  complex.

  There should probably be a semicolon before "however".

• [x]

   sRGB8  provides  a  better  precision  where  it  matters  the most  for  the  eyes  sensibility  and  tackle  perfectly  some  use  cases  just  particle  systems  rendering.

  The last phrase, starting with "tackle" doesn't seem to make sense. sRGB images tackle some use cases like particle systems?

• [x]

  alternative  to  checking  versions  and  extensions,  consists  in  creating  a  texture

  Consider "consists of creating".

• [x]

  to  initial  a  table

  Consider "to initialize a table".

• [x]

   alternative  consists  in  emulating

  Consider "alternative consists of emulating".