gabrielittner / lazythreetenbp Goto Github PK

I'm using a library in my app which has a dependency on org.threeten:threetenbp:1.3.4. After adding LazyThreeTenBP, my build broke with:

Error:com.android.builder.merge.DuplicateRelativeFileException: More than one file was found with OS independent path 'org/threeten/bp/format/ChronologyText.properties'

After investigating, it seems that LazyThreeTenBP has a compile dependency on treetenbp's no-tzdb artifact, which breaks my dependency resolution and results in both artifacts being bundled. I can easily fix this by excluding that library's dependency, but it might be nicer if LazyThreeTenBP had an api dependency on ThreeTenBP instead, and relied on the app to depend on it explicitly.

Hey 👋
I wasn't sure if the library is still maintained so I allowed myself to fork it and adjust it to my needs and I think I spotted an issue you should be aware of. It seems like the published artifact contains GeneratedZoneIdsProvider which comes from sources:

Here's how the diff looks like:

doesn't seem significant, but it felt like worth reporting here. It isn't intended, right?

Everything needs test. The compiler and provider could probably borrow from threetenbp for that.

What would be the difference in using this with no-tzdb or using https://github.com/JakeWharton/ThreeTenABP?

Generally not a huge problem because the API is stable but it would be nice to get rid of it at least for runtime. Maybe there is a way without copying a lot of code.

Runtime:

• uses org.threeten.bp.zone.StandardZoneRules.readExternal(DataInputStream) to read tz data from file

Compiler:

• uses org.threeten.bp.zone.TzdbZoneRulesCompiler to parse input data
• uses org.threeten.bp.zone.StandardZoneRules.writeExternal(DataOutput) to write tz data to file

2022b has been released 2022-08-10 and its corresponding new rule could be effective as early as September 10th, 2022.
https://www.iana.org/time-zones

org.threeten.bp.zone.ZoneRulesProvider tries to load available providers using ServiceLoader in a static initializer block. That's not needed on Android. From some quick measurements costs up to 20ms for doing nothing. The measurement was done by calling ZoneRulesProvider.getAvailableZoneIds() before the tz initialization (the method itself is basically a no-op in that case but triggers the block).

https://github.com/ThreeTen/threetenbp/blob/master/src/main/java/org/threeten/bp/zone/ZoneRulesProvider.java#L84

Need support for newer version of the 1.6.8 tz db, as I have bumped up the library which caused some errors for timezones not supported.

Plus I am not sure downgrading the tz db version will cause some downgrade issues/problems