gabsource / oc-scaffold-translation-plugin Goto Github PK

Hi.
I use your plugin a lot so I've created an included a polish translation file. Hope you'll find this usefull.

pl.zip

Hi,

actually this is a useful plugin, but all the calls to trans() are unneccessary. October will automatically look up these in the language files - there is no need for the trans in Components, Plugin-files, etc

Example: https://github.com/rainlab/blog-plugin/blob/master/components/Categories.php#L30-L31

Hello,

Thank you for your awesome plugin. I've got a question though, can bring PR if you are willing.

Basically, you scaffold controller with delete button and onDelete method like this:

public function index_onDelete()
{
    if (($checkedIds = post('checked')) && is_array($checkedIds) && count($checkedIds)) {
        foreach ($checkedIds as ${{lower_singular_model}}Id) {
            if (!${{lower_singular_model}} = {{model}}::find(${{lower_singular_model}}Id)) continue;
                ${{lower_singular_model}}->delete();
        }
    }
    (...)
}

and it does what should rarely be done: makes singular queries in loop, also loads whole model with find and does some non required checks. That makes it super slow, for 120 records at once I've got like 5 seconds deletion time.

My suggestion would be to use:

if (($checkedIds = post('checked')) && is_array($checkedIds) && count($checkedIds)) {
  {{model}}::whereIn('id', $checkedIds)->delete();  
}

so results would be like

if (($checkedIds = post('checked')) && is_array($checkedIds) && count($checkedIds)) {
  Model::whereIn('id', $checkedIds)->delete();
}

Rationale:

• You do not really need to confirm that model exists and load it with find when you just want to delete it.
• You do not need to spam database with queries when you want one operation to go and have array of ids.
• There is HUGE speed difference:

Loop method for 120 records: 5116 ms (red on screenshot)
Wherein method for 120 records: 121ms (green on screenshot)

Let me know if you would be willing to accept PR for this?