gadfly361 / re-pressed Goto Github PK

Currently, all keys are ignored if pressed inside of a select, input, or textarea. However, it would be useful to be able to record and dispatch off of certain keys (like enter, arrows, or tab, etc.).

I think the solution here is to either:

• add a whitelist of keys that are never ignored, like {:always-listen-keys [{:which 13}]
• add flags to listen to select, input, and textarea, like {:ignore-select? false}, where it defaults to true.

Hi, I am not sure if it is a bug. But whenever I press keys in an input element, a warning re-frame: Subscribe was called outside of a reactive context occurs.

To reproduce:

1. run command lein new re-frame <app-name> +re-pressed
2. change main-panel in views.cljs to

(defn main-panel [] [:input])

3. press a key in the input element

When using a key sequence to dispatch an event, the key sequence is incorrectly compared against the most recent keys in reverse order

For example, this

[
 [ [:some-event-id]
   [{:which 72} ;; h
    {:which 87} ;; w
]

Would incorrectly dispatch [:some-event-id] when w then h is pressed, and not when h and then w is pressed.

Thank you for this library but to include jquery to modern react app is not the best practice. This lib will be nicer for me when it doesn't not depend on jquery

(reg-global-interceptor trim-v)

This won't let re-pressed work.
I am not sure if this is re-pressed concern but I believe there might be a way to make it compatible.