gahag / bgrep Goto Github PK

An option like greps "-m 1" option would be nice.

I noticed that you're not using the default rust style guidelines.
It would be better to use rustfmt to format your code so that coding style can be unified among different contributors.

You can add a rustfmt.toml for some custom configuration, such as tab_spaces = 2, the full configurations can be found at Configurations.md.

(I am not a native speaker, so please forgive me if there is any offense in my words.)

The current version of the code seems to try to load the whole file into memory which fails for large files.
E.g. in my case I get the following error:
memory allocation of 5404574964 bytes failed

It would be great if the code would read the file sequentially / piece by piece.