Issue with PR #127 about ansible-galaxy-extras

[drosofff]

https://github.com/galaxyproject/ansible-galaxy-extras/blob/master/templates/startup.sh.j2#L81

It looks like we end up with reports_auth.conf.source in /etc/nginx/conf.d/ without reports_auth.conf and this crashes nginx when the handler for restarting nginx is called

Actually, when is the startup.sh script run on the target when using the playbook ?

[abretaud]

Oops, sorry about that!
Would it work if we created a default empty reports_auth.conf from https://github.com/galaxyproject/ansible-galaxy-extras/blob/master/tasks/nginx.yml?

[drosofff]

Probably. But there is maybe also some adaptations to make in the nginx.conf.j2 in that case ?
Apart from that, I change https://github.com/galaxyproject/ansible-galaxy-extras/blob/master/tasks/nginx.yml#L14 with

    - { src: 'nginx_reports_auth.conf.j2',  dest: '{{ nginx_conf_directory }}/reports_auth.conf' }

And it turns around the issue since the startup.sh script is not run unless you build a docker container, does it make sense ? So yes, maybe just templating another (empty ?) reports_auth.conf.j2 in the nginx.yml task as you propose would be sufficient.

The purpose of an intermediate reports_auth.conf.source file is not clear to me since I don't see clearly the purpose. But I guess that you already fight with an issue about that !

[abretaud]

I think just having an empty file should be enough.
I did this change because we need to make the auth part of the nginx conf file optional, and the nginx if does not do what you'd expect from a normal if.
Instead of the if, I include a file (nginx_reports_auth.conf) that is empty (no auth) or contains the basic_auth settings (if auth is enabled)

Is there an easy way to reproduce your problem?

[drosofff]

Is there an easy way to reproduce your problem?

Pretty easy.

• spin off a VM with ansible=2.2.1.0
• git clone https://github.com/ARTbio/GalaxyKickStart.git
• cd GalaxyKickStart
• ansible-galaxy install -r requirements_roles.yml -p roles
• ansible-playbook -i inventory/galaxykickstart galaxy.yml

And you will see nginx crashing when the handler reloads nginx

[drosofff]

Ubuntu 14.04 !