GithubHelp home page GithubHelp logo

galoisinc / arm-asl-parser Goto Github PK

View Code? Open in Web Editor NEW
10.0 10.0 1.0 166 KB

Parsing tools for ARM's ASL

License: BSD 3-Clause "New" or "Revised" License

Haskell 40.70% ANTLR 15.27% Java 41.13% Shell 0.15% Makefile 2.75%

arm-asl-parser's People

Contributors

benjaminselfridge avatar danmatichuk avatar m10f avatar ryanglscott avatar travitch avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

uslsteen

arm-asl-parser's Issues

`Makefile` fails due to undeclared `bash` dependency

This part of the Makefile requires bash syntax to work due to the use of [[ ... ]], which is a bash builtin:

arm-asl-parser/Makefile

Lines 67 to 71 in afbeff2

define PARSETARGET
${PARSEDIR}/$(1).sexpr: ${ASLDIR}/$(1).asl | ${PARSEDIR}
cd ${ASL_PARSER} && \
./gradlew -q run --args="$(2) $$(abspath $$<)" > $$(abspath $$@) && \
[[ -s $$(abspath $$@) ]] || (rm -f $$(abspath $$@) && exit 1)

Despite this, the Makefile does not declare an explicit dependency on bash. As a result, it will fail if Makefile defaults to /bin/sh, as it does on my machine:

$ make all
cd xml && tar zxf A64_v85A_ISA_xml_00bet9.tar.gz && tar zxf ISA_v85A_A64_xml_00bet9.tar.gz
cd xml && tar zxf AArch32_v85A_ISA_xml_00bet9.tar.gz && tar zxf ISA_v85A_AArch32_xml_00bet9.tar.gz
cd asl-parser-java && ./gradlew -q run --args="defs /home/rscott/Documents/Hacking/Haskell/asl-translator/submodules/arm-asl-parser/asl/arm_defs.asl" > /home/rscott/Documents/Hacking/Haskell/asl-translator/submodules/arm-asl-parser/asl-parsed/arm_defs.sexpr && [[ -s /home/rscott/Documents/Hacking/Haskell/asl-translator/submodules/arm-asl-parser/asl-parsed/arm_defs.sexpr ]] || (rm -f /home/rscott/Documents/Hacking/Haskell/asl-translator/submodules/arm-asl-parser/asl-parsed/arm_defs.sexpr && exit 1)
/bin/sh: 1: [[: not found
make: *** [Makefile:76: asl-parsed/arm_defs.sexpr] Error 1

The solution is simple: declare an explicit bash dependency like so:

diff --git a/Makefile b/Makefile
index 44d8f50..82f8f99 100644
--- a/Makefile
+++ b/Makefile
@@ -1,3 +1,5 @@
+SHELL := /bin/bash
+
 .PHONY: default clean realclean
 default: all

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.