gamernetwork / egx-titling Goto Github PK

At the moment, passing in an invalid day to setDay() does not throw an exception. It will, however, error when you try to call a function like upNext() and it can't find a start time for the day:

setDay('mahergenflergen');
undefined
upNext();
slides.html:808 Uncaught TypeError: Cannot read property 'timestart' of undefined
    at getCountdown (slides.html:808)
    at updateCountdown (slides.html:796)
    at startCountdown (slides.html:789)
    at upNext (slides.html:347)
    at <anonymous>:1:1

This should error as soon as possible so the user knows exactly what they have done wrong and how to rectify it

I'm not sure about the names of these functions as, unlike all the other functions, these don't do much to explain what will appear on the screen.

It would be nice to have semantic names for these (like the others) rather than ones that refer to the placement, as lowerLeft() actually shows a description of what's showing so maybe nowShowing() would be better? lowerRight() shows what's up next so maybe upNextSmall() or something like that?

Not saying we should settle on those names but I think it makes sense to have that kind of consistency across the function names.

Some of the functions have negative parameters, like no_countdown, which makes calling the functions confusing - if I want a countdown, should I pass it true as in 'yes that's true i want no countdown', or false as in 'false, no i don't want want a countdown'. I think it makes way more sense for the parameter to be called show_countdown and pass it true if you want it, and false if you don't