games50 / mario Goto Github PK

Hello,

This is a recurring issue, as already discussed within fifty-bird: games50/fifty-bird#2
As I explained there, the physics of the gravity calculation is wrong, and causes the gravity to be "too strong" for machines that run with FPS higher than 60

In this repo the mistake happens here

when adding the gravity to the player's dy it is not multiplied by dt, and the dy is decreased by gravity every frame, when the frame rate is higher, the gravity is stronger and at my machine (144 fps) the player simply can't jump over columns

as with fifty-bird, I prefer to suggest a solution and not just complain, see my Pull Request: #4

The GenerateTileSets function in src/Util.lua wrongly splits the quads.

This is the picture of all quads in gFrames['tilesets'][1].

It can be easily fixed by changing line number 54 and 55 in src/Util.lua
from this
for y = sizeY * (tilesetY - 1) + 1, sizeY * (tilesetY - 1) + 1 + sizeY do
for x = sizeX * (tilesetX - 1) + 1, sizeX * (tilesetX - 1) + 1 + sizeX do

to this
for y = sizeY * (tilesetY - 1) + 1, sizeY * (tilesetY - 1) + sizeY do
for x = sizeX * (tilesetX - 1) + 1, sizeX * (tilesetX - 1) + sizeX do