gamethis / ansible_role_wsus_server Goto Github PK

Checklist for initial Release of 1.0.0

Thoughts for initial 1.0.0 are the following needed?
Should we go ahead and tag the repo now or after the following are added?

• Documentation Review
• Formating
• Idiomatic
• variable changes

Hi,

this role tries to import a role named "reboot" in https://github.com/gamethis/ansible_role_wsus_server/blob/master/tasks/install.yml#L28

however, meta/main.yml file does not specify a dependency on any such role:
https://github.com/gamethis/ansible_role_wsus_server/blob/master/meta/main.yml

thus, this role fails to run with the error:

ERROR! the role 'reboot' was not found in /home/$USER/gitlab/platforms/wsus/roles:/home/$USER/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles:/home/$USER/gitlab/platforms/wsus

The error appears to be in '/home/$USER/.ansible/roles/wsus_server/tasks/install.yml': line 28, column 11, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

  import_role:
    name: reboot
          ^ here

I am not sure what that role was supposed to do, but there is a simple win_reboot module available - could this broken role dependency perhaps be removed and win_reboot used directly instead?

Thanks

To help with pull requests and issues add control files and folders to help in classifying and standardizing pull requests and issues.

Hello @gamethis

I opened #2 a month ago and so far no response. I was forced to fork this role into a private repository and I made many many fixes and improvements to my fork that I would like to contribute back upstream here so that everyone can benefit from them - but I was wondering whether you are still maintaining this role, if not I would ask you to please archive the repository so that new people who find this role and may want to use it are aware of its abandoned state.

If you are back and interested in PRs I can make many separate ones for every fix and improvement I made.

I am thinking of adding a testing suite into the repo.

was thinking of doing a molecule test suite with docker image for testing against. Need to validate that wsus can be configured on windows docker image if it can will add if not will go vagrant route.
alternatively we could put in a vagrant box and test.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.