gaoding-inc / stateshot Goto Github PK

Current Behavior

history.push(state).then(() => {
  console.log(history.length) // 2
})
history.pushSync(state)

In this case history.length should be 1 since sync push is expected to clear the pending state.

Rollup need a few more setup but is better in bundle size. It can also fix the webpack require error.

Makes sense since we may make hashFunc replaceable.

Add a index.d.ts to support usage in typescript.

1、看了你们这个库的实现原理分析，大致理解是你们这个库应该是快照式撤销重做类库？
2、图片处理涉及到distructive 和 non-destructive操作，还有添加图层类操作，图层与原图一起变换操作等一系列操作，那么用你们这个库怎么实现？或者你们有类似的示例吗？

const history = new History()
const state = { a: 1, b: 2 }
history.pushSync({ ...state })
history.pushSync({ ...state, ...{ a: 2 } })
history.pushSync({ ...state, ...{ a: 3 } });
history.undo();
history.undo();
let r1 = history.get();    // { a: 1, b: 2, children: undefined }
history.pushSync({ ...state, ...{ c: 1 } });
let r2 = history.get();
let r3 = history.length;   // 3  应该等于2
history.undo();
let r4 = history.get();    // { a: 1, b: 2, children: undefined }

存在的几点问题

1. 默认的defaultRule会使得get方法返回值中带有children字段
2. history.length值应该是this.$records.filter(record => record).length,r3应该为2

Using libs like immer to replace our hash implementation is promising and trivial. Another options needed.

Current implementation is error-prone.

A history.length getter makes sense.

JSFiddle or Glitch is enough.

Snippet for "dumping" history records:

// in chrome console
copy(oldHistoryStore)

// in reproduction page
const data = { ... } // paste
history.$index = data.$index
history.$records = data.$records
history.$chunks = data.$chunks