GithubHelp home page GithubHelp logo

gaqzi / chrome-open-in-spotify-client Goto Github PK

View Code? Open in Web Editor NEW
27.0 27.0 6.0 714 KB

Instead of opening open.spotify.com links in the browser they will always be opened in Spotify

Makefile 12.93% JavaScript 85.95% HTML 1.12%

chrome-open-in-spotify-client's People

Contributors

dependabot[bot] avatar gaqzi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

chrome-open-in-spotify-client's Issues

Versioning

Summary

Version on chrome extension store is still using 1.3 that no longer works

Are there any plans to update this to 1.4.1?

error opening playlists from web

The extension works great w/ all open.spotify.com links I've tested but when it tries to load an embedded playlist from the web into the desktop player I get this error:

"There was a problem displaying this view! This view either does not exist or an error has occurred." If I disable the extension the playlists load on the web site as expected.

Here are a couple examples:

https://www.reddit.com/r/spotify/comments/8opjis/back_to_the_80s_i_best_of_synthwave_and_retrowave/

https://www.reddit.com/r/spotify/comments/8ou5qh/mf_doom_48_timeless_songs_from_my_favorite_hiphop/

Current tab gets closed before Chrome gets chance to ask for permission

Hi,

First of all, thank you for this amazing extension. The extension shouldn’t be necessary in the first place but I’m thankful that it exists!

The issue

I’m on Chrome 67 on macOS Sierra. Just after installing the extension for the first time, I noted that opening a open.spotify.com link would seem to bring Chrome to the front but never open Spotify.

Analysis

A little debugging reveals that the redirect does work (in the sense that Chrome displays a modal pop-up in the new tab, asking for permission to open the Spotify app); however, the 100 ms timeout causes the current tab to be closed automatically before I even get to see that pop-up.

You can check this setting by locating your Preferences file (mine is in ~/Library/Application Support/Google/Chrome, on Windows the file seems to be in %LOCALAPPDATA%\Google\Chrome\User Data\Default) and looking at the .protocol_handler.excluded_schemes entry there. If .protocol_handler.excluded_schemes contains a spotify key with a value of false, Chrome will never ask for permission for the Spotify protocol handler. Otherwise, it will always ask for permission, which is the default.

That means the extension may not work for anyone who has never opened a spotify: link before nor ticked the never-ask-again box in the popup.

Proposed fix

No idea yet.

I’ve tried to use the navigationRequest, tabs, and webRequest APIs to emulate some kind of redirection-complete event but didn’t succeed.

Workaround

At the very least, I’d suggest to add a Known issues section to README.md with the following description:

If the extension appears to do nothing for you, type spotify: in the browser and hit Enter. Tick the box to allow Chrome to always open Spotify without asking. Finally, click Open Spotify to confirm.

Doesn't work with snap (?)

I have installed Spotify on Ubuntu 18.04 via the OS's store, which by default now installs a snap. There's two issues I'm experiencing, which may have to do with the fact that it's a snap:

  • the plugin launches a new Spotify instance every time a link is opened (instead of using the existing spotify instance)
  • the right playlist/album/artist isn't opened; it just launches Spotify's home screen

Not sure if you're able to support this at all, or if this would require action from Spotify's side. Thanks in any case for your work on this :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.