garynewby / pianokeyboard Goto Github PK

I see that currently labels for black keys aren't drawn. It'll help greatly if this feature exists.

Aloha!
Great library btw. Thanks!

I'd like to set only a few labels. the remaining show up as gray circles. If a label is "", perhaps remove the background circle?

With Xcode 9.4.1, attempting to read or modify the octave property on GNLPianoView gives the error: 'octave' is inaccessible due to 'internal' protection level.

Because octave is defined with var it defaults to internal access level. I think the intended code is public var as this accessor provides a way to change the keyboard octave.

https://github.com/garynewby/GLNPianoView/blob/d778eb88c515d9b9afcd1842f0f5ad14854da9fc/Source/GLNPianoView.swift#L62-L70

For example:

• To show the middle C key
• or to instruct the user which key to press

I would like to be able to :

• Display only Key name without Octave (e.g. , "C", "D",... instead of "C4", "D4"
  OR
• Display "Do", "Re", "Mi",...

I suggest:

pianoView.setKeyLabels(labels: [Int:String])

Where labels is a dictionary of [MidiNote : Label]

Alternatively, labels could be a simple array of a fixed size of 128, to set ALL labels.

Like the AudioKit synth One, i'd love for a way to have a key pressed down and not released if a "hold" flag is set.

Sometimes if I play chords or move fast on the keyboard keys get stuck.
I think it has to do with the "touchUpOutside" gesture.

Or in your UIGestureRecognizer implementation you should implement the ".canceled" state.

I'll have a look in your code.

Otherwise, thanks, it's an awesome drop in keyboard.

Thanks for adding the latch feature.
can you make it so that in latch mode, the keys become more like toggle buttons? So in latch mode key 'K' is pressed, it stays pressed. But pressing it again should release it.
Thanks!
Also, making the latch variable inspectable will help identify which state the keyboard is in for showing UI etc.
Thanks!

For visually impaired users,
From documentation, it seems that element.accessibilityTraits = .allowsDirectInteraction seems to be the way to go?
setting the property on the keboardView doesn't seem to work. I tried with the imageLayer -- same thing - no go.
This will be a very useful feature from an accessibility perspective.

Hello, I am trying to run your demo but it will not play any sound? My device is in ring mode i cross check all things. what will be the issue ?

This worked great before. I have a keyboard that changes number of keys based on screen size. If numberOfKeys change, the keyboard layout is off, till a key is pressed and it redraws.

Sorry for the newbie question, but is it possible to use this component in a swiftui contentview e.g. something like

import SwiftUI
import PianoKeyboard

struct ContentView: View {
    var body: some View {
        VStack {
            PianoKeyboard()
            Text("Hello, world!")
                .padding()
        }
    }
}

In the above I get the error Static method 'buildBlock' requires that 'PianoKeyboard' conform to 'View'?

I cannot get the project to run.

Issue

I added this package via SPM on the Example app, but PianoKeyboardView did not appear. What do I need to do additionally?

ScreenShot

Device / OS

iPhone 13 / iOS 16.4.1