gasolin / aframe-href-component

A Hyper Link component for A-Frame, turning object to a html linkable element

• The Mobile/Web Engineer and the Tech writer
• Check my 🎩 resume and 🖋 blog

aframe-href-component's Issues

wait to trigger href action until the child animation end

http://codepen.io/team/mozvr/pen/RrxgwE

Browser installation does not work - link unactive

https://rawgit.com/gasolin/aframe-href-component/master/dist/aframe-href-component.min.js seems to be 404

click event not at the same spot

Hi there,

I'm using aframe-href-component together with https://github.com/jeromeetienne/AR.js/
Here's the example https://ar-cards.nico.dev/
You can launch the AR Experience with this Barcode:
https://github.com/artoolkit/artoolkit5/blob/master/doc/patterns/Matrix%20code%203x3%20(72dpi)/20.png

On desktop it works as expected. But on mobile it doesn't. And what I found out so far is that the click event is triggered somewhere more on the right than the actual icon:

Does anyone have/had the same issue? Or does anyone know why this happens?

find way to trigger animation before go to url

Ref
https://github.com/begeeben/aframe-website/blob/gh-pages/js/main.js

Remove event listener in `remove` method

There's a click event listener added in init. It should get removed in remove.

improve example

add fuze cursor example
http://codepen.io/team/mozvr/pen/RrxgwE

Hash logic perpaps too prescriptive

I may want to change the hash of the page for reasons unrelated to A-Frame entities (e.g., a URL for #siteInfo).

IMO, the logic should be simplified to check if URL starts with a #, and then set window.location.hash. Otherwise, window.location.href.

Also, if you're going to support jumping to A-Frame entities based on their ids, perhaps add separate logic (IMO a separate component) that actually uses a hashchange listener.